sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.31k stars 449 forks source link

sage -unzip #19484

Closed 6bdad4c1-1e26-4f2f-a442-a01a2292c181 closed 8 years ago

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago

As discussed on sage-devel [1], we lack a way to unzip files.

This very short python script does the job.

Nathann

[1] https://groups.google.com/d/topic/sage-devel/1uoTUsQ29Sw/discussion

Component: distribution

Author: Nathann Cohen

Branch/Commit: 727ac93

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/19484

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago

Branch: public/19484

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Commit: 465d83c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

465d83ctrac #19484 - sage -unzip
mkoeppe commented 8 years ago
comment:3

See also #18781.

dimpase commented 8 years ago
comment:4

Replying to @mkoeppe:

See also #18781.

Right, this was the ticket I meant when I posted in sage-devel on this.

vbraun commented 8 years ago
comment:5

Can we at least put sage-unzip into build/bin/ and not expose it via a sage -unzip command line argument? It has no mathematical purpose, its just an internal tool for building Sage packages.

vbraun commented 8 years ago
comment:6

And I agree that there are lots of stupid command line options like sage --twisted. I don't think that means that we should add more out-of-scope commandline options.

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago
comment:7

I thought that it would make more sense in the general bin folder. This is where one would find 'unzip' if we had chosen to package it.

As Dima raised, one can already find many non-mathematical 'utilities' in the general bin/ folder. Some examples: g++,cython,cythonize,python,scons,git, ...

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago
comment:8

And I agree that there are lots of stupid command line options like sage --twisted. I don't think that means that we should add more out-of-scope commandline options.

Oh. Well I have no strong objection to the removal of sage -unzip. I just thought that all sage-something had to be exposed as "sage -something". How would you want it to appear?

Nathann

vbraun commented 8 years ago
comment:9

There is no reason to expose everything as commandline option. There is no sage --fix-pkg-checksums (i hope). The script using sage-unzip can just call it directly.

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago
comment:10

There is no reason to expose everything as commandline option. There is no sage --fix-pkg-checksums (i hope).

Err... That's #18947.

The script using sage-unzip can just call it directly.

Okayokay. So I'll remove that line, I do not mind much.

Nathann

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

35f2e34trac #19484: No sage -unzip
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 465d83c to 35f2e34

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

727ac93trac #19484: sage-unzip
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 35f2e34 to 727ac93

vbraun commented 8 years ago

Reviewer: Volker Braun

6bdad4c1-1e26-4f2f-a442-a01a2292c181 commented 8 years ago
comment:14

Cooool! Thanks,

Nathann

vbraun commented 8 years ago

Changed branch from public/19484 to 727ac93