remove expired deprecations in sage/combinat

d4d9e38a-6e64-40d7-a7f7-bd828eb9e0db commented 9 years ago

A grep of the word deprecation in the source code of sage/combinat indicates that there are many functions which have expired. All warnings which were placed there with the intention of eventually removing them. We will clean up some of this code and remove deprecations which have been in Sage for at least one year (the focus will be on those that have been merged since two years).

Code deprecated from:

merged in sage-5.X: #8920 (5.8.beta2), #14140 (5.9.beta3), #14101 (5.12.beta4), #14496 (5.10.beta2), #14673 (5.10.rc1), #14772 (5.12.beta3), #14875 (5.13.beta0), #15142 (5.13.beta0), #15327 (5.13.beta3)
merged in sage-6.X: #13872 (6.1.beta?), #15473 (6.1.beta?), #15882 (sage-6.2.beta?), #6637 (6.3.beta?), #16446 (6.3.beta?), #16472 (sage-6.3.beta?), #16553 (sage-6.3.beta?), #16933 (sage-6.4.beta?)

CC: @sagetrac-fwclarke @AndrewAtLarge @anneschilling @darijgr @VivianePons @hivert @fchapoton @sagetrac-chrisjamesberg @saliola @ghseeli @sagetrac-sage-combinat @zabrocki @nthiery @sagetrac-alubovsky @tscrim @simon-king-jena @bsalisbury1 @videlec @staroste @nathanncohen @brettpim

Component: combinatorics

Keywords: deprecate

Author: Mike Zabrocki

Branch/Commit: a97a800

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/19513

videlec commented 8 years ago

comment:34

You removed some deprecation released in sage-6.4 (from 04/14/15)... One year deprecation implies that this should not be merged until 04/14/16 which is in 6 months. This concerns this modification

-        if compact is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(16933, 'compact argument is deprecated.')

videlec commented 8 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
 A grep of the word `deprecation` in the source code of `sage/combinat` indicates that there are many functions which have expired.  All warnings which were placed there with the intention of eventually removing them.  We will clean up some of this code and remove deprecations which have been in Sage for at least one year (the focus will be on those that have been merged since two years).

-Code deprecated from: #6637, #14101, #14140, #14772, #16472, #15142, #14496, #15473, #14673, #13872, #15882, #8920
+Code deprecated from:
+- merged in sage-5.X: #8920 (5.8.beta2), #14140 (5.9.beta3), #14101 (5.12.beta4), #14496 (5.10.beta2), #14673 (5.10.rc1), #14772 (5.12.beta3), #14875 (5.13.beta0), #15142 (5.13.beta0), #15327 (5.13.beta3)
+- merged in sage-6.X: #13872 (6.1.beta?), #15473 (6.1.beta?), #15882 (sage-6.2.beta?), #6637 (6.3.beta?), #16446 (6.3.beta?), #16472 (sage-6.3.beta?), #16553 (sage-6.3.beta?), #16933 (sage-6.4.beta?)

jdemeyer commented 8 years ago

comment:35

Sage 6.4 was released 14 november 2014, so it's more than 1 year ago.

jdemeyer commented 8 years ago

comment:36

See http://www.sagemath.org/changelogs/sage-6.4.txt

jdemeyer commented 8 years ago

comment:37

14 april 2015 is the release date of Sage 6.6

videlec commented 8 years ago

comment:38

Thanks Jeroen for the corrections! I used the dates from trac milestones that were obviously wrong. I fixed them. And I can set this ticket to positive review!

videlec commented 8 years ago

Reviewer: Vincent Delecroix

vbraun commented 8 years ago

Changed branch from public/ticket/19513 to a97a800

sagemath / sage

remove expired deprecations in sage/combinat #19513