search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 481 forks source link

trac.sagemath.org should allow to unsubscribe from notifications #19832

Closed 7e1f74a4-af29-4dae-ba12-80219fea04c8 closed 8 years ago

7e1f74a4-af29-4dae-ba12-80219fea04c8 commented 8 years ago

Currently (2016-01), trac.sagemath.org sends notifications even after a user removes himself from the CC list. This is irritating to the user and seems like a local misconfiguration of the notification subsystem (see http://trac.sagemath.org/wiki/TracNotification).

The configuration should be fixed, so that only people actually in CC (or other such fields) are notified.

As a current stopgap measure, I propose that users are not added to new tickets, but are alerted of a new ticket that may interest them through other means, e.g., by adding a link to the new ticket in a new comment of a related ticket in which the user is listed in CC.

Relevant upstream ticket: http://trac.edgewall.org/ticket/9971. The solution suggested in comment 14 there does not seem to apply to Sage's trac, as no Notification preferences are present in the Preferences.

Upstream: None of the above - read trac for reasoning.

CC: @slel @embray @jondo

Component: website/wiki

Keywords: trac email notifications

Issue created by migration from https://trac.sagemath.org/ticket/19832

7e1f74a4-af29-4dae-ba12-80219fea04c8 commented 8 years ago

Description changed:

--- 
+++ 
@@ -3,3 +3,5 @@
 The configuration should be fixed, so that only people actually in CC (or other such fields) are notified.

 As a current stopgap measure, I propose that users are not added to new tickets, but are alerted of a new ticket that may interest them through other means, e.g., by adding a link to the new ticket in a new comment of a related ticket in which the user is listed in CC.
+
+Relevant upstream ticket: http://trac.edgewall.org/ticket/9971
7e1f74a4-af29-4dae-ba12-80219fea04c8 commented 8 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,4 @@
 As a current stopgap measure, I propose that users are not added to new tickets, but are alerted of a new ticket that may interest them through other means, e.g., by adding a link to the new ticket in a new comment of a related ticket in which the user is listed in CC.

 Relevant upstream ticket: http://trac.edgewall.org/ticket/9971
+The solution suggested in comment 14 there does not seem to apply to SAGE's trac, as no Notifications preferences are present in the preference screen.
slel commented 8 years ago
comment:4

Note: this issue was also discussed in a 2015-02 sage-devel thread.

7e1f74a4-af29-4dae-ba12-80219fea04c8 commented 8 years ago
comment:5

Replying to @slel:

Note: this issue was also discussed in a 2015-02 sage-devel thread.

Thanks, surfing through to the mentioned cases for Django and Trac itself, the final solution was in both cases to turn off always_notify_updater. I suggest that as a fix for Sage as well.

To make sure contributors know about this, a general mail should be sent out and people should be added to the (then functional) Cc list for the tickets they now get mail for and are put on Cc whenever 'touching' a ticket, so that doing nothing doesn't change the system's behavior. However, from that point on, people could remove themselves from the Cc list.

dimpase commented 8 years ago
comment:6

Erik, could you look into this?

embray commented 8 years ago
comment:7

https://trac.sagemath.org/prefs/notification

I don't think this should be the place for issues with the Trac site though.

dimpase commented 8 years ago
comment:9

Replying to @embray:

https://trac.sagemath.org/prefs/notification

I don't think this should be the place for issues with the Trac site though.

Do you mean to say it just works now?

embray commented 8 years ago
comment:10

Users can change their ticket subscription policies there.

7e1f74a4-af29-4dae-ba12-80219fea04c8 commented 8 years ago
comment:11

Replying to @embray:

Resolution set to wontfix Status changed from new to closed

It is fixed by the now-presence of the notification preferences, so "closed fixed", I'd say.

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 8 years ago
comment:12

Replying to @embray:

Users can change their ticket subscription policies there.

That's not a solution to the problem, since you cannot unsubscribe from arbitrary tickets (unless you limit your "global" notifications to "Notify: Ticket that I'm listed in the CC field is modified", and manually add yourself to the cc-list of all those tickets you want to receive notifications for in the future, never forgetting to do so when you just comment on a ticket, and not missing any ticket you previously participated in, and relying on not anybody ever messing up these lists).

embray commented 8 years ago
comment:13

Well, if you want to permanently unsubscribe from all updates to a specific ticket there might be a Trac plugin for that but I don't know.

slel commented 8 years ago
comment:14

@embray: At https://trac.edgewall.org/ticket/9971#comment:7 there is a suggestion to turn "always_notify_updater" into "always_cc_updater", would that be an option? Or would the act of un-cc-ing oneself then count as updating, and cc one again?

slel commented 8 years ago
comment:15

Related documentation at Trac

Related open tickets at Trac

Related closed tickets at Trac

Question about the TracNotification page on Sage trac's wiki: https://trac.sagemath.org/wiki/TracNotification

Does it reflect the current version of Trac at trac.sagemath.org?

slel commented 8 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,18 @@
-Currently, trac.sagemath.org sends notifications even after a user removes himself from the CC list. This is irritating to the user and seems like a local misconfiguration of the notification subsystem (see http://trac.sagemath.org/wiki/TracNotification).
+Currently (2016-01), trac.sagemath.org sends notifications even after a user
+removes himself from the CC list. This is irritating to the user and seems like
+a local misconfiguration of the notification subsystem
+(see http://trac.sagemath.org/wiki/TracNotification).

-The configuration should be fixed, so that only people actually in CC (or other such fields) are notified.
+The configuration should be fixed, so that only people actually in CC
+(or other such fields) are notified.

-As a current stopgap measure, I propose that users are not added to new tickets, but are alerted of a new ticket that may interest them through other means, e.g., by adding a link to the new ticket in a new comment of a related ticket in which the user is listed in CC.
+As a current stopgap measure, I propose that users are not added to new tickets,
+but are alerted of a new ticket that may interest them through other means, e.g.,
+by adding a link to the new ticket in a new comment of a related ticket in which
+the user is listed in CC.

-Relevant upstream ticket: http://trac.edgewall.org/ticket/9971
-The solution suggested in comment 14 there does not seem to apply to SAGE's trac, as no Notifications preferences are present in the preference screen. 
+Relevant upstream ticket: [http://trac.edgewall.org/ticket/9971](http://trac.edgewall.org/ticket/9971).
+The solution suggested in 
+[comment 14 there](https://trac.edgewall.org/ticket/9971#comment:14)
+does not seem to apply to Sage's trac,
+as no Notification preferences are present in the Preferences.
dimpase commented 8 years ago
comment:16

Replying to @embray:

Well, if you want to permanently unsubscribe from all updates to a specific ticket there might be a Trac plugin for that but I don't know.

How hard would it be to implement? Basically, 3 things (I certainly do not know anything about trac source, so perhaps this is fundamentally wrong picture) :

(this can be filed under ODK WP7 :-))

83660e46-0051-498b-a8c1-f7a7bd232b5a commented 8 years ago
comment:17

Replying to @dimpase:

Replying to @embray:

Well, if you want to permanently unsubscribe from all updates to a specific ticket there might be a Trac plugin for that but I don't know.

How hard would it be to implement? Basically, 3 things (I certainly do not know anything about trac source, so perhaps this is fundamentally wrong picture) :

  • a button/toggle to cc/un-cc yourself on a ticket

Yes, please. (Which bug tracker does not have this feature?)

And this may in addition make manually editing the CC field obsolete, if there are both "cc me" and "cc someone else" buttons.

  • a persistent list of unsubscribers (people who un-cc themselves), attached to the ticket
  • a filter in the notification email dispatcher that checks the recipients against the latter list

(this can be filed under ODK WP7 :-))

YES!

embray commented 8 years ago
comment:18

I guess--don't you all have e-mail clients with ignore thread features? I just never have a problem with this.

dimpase commented 8 years ago
comment:19

Replying to @embray:

I guess--don't you all have e-mail clients with ignore thread features?

no, I don't think so. Besides, this is error-prone and wasteful way to deal with this. If you delete a thread it would delete ignoring flag too; if ticket subject gets changed it would trickle through again. Etc..

I just never have a problem with this.

jondo commented 8 years ago
comment:20

The [/prefs/notification notification preferences here] show the following among the default rules:

  • Notify: Ticket that I previously updated is modified
  • Notify: Ticket that I'm listed in the CC field is modified

How can I now just switch off the first rule, leaving the second one fully working?

The page also says:

Configure subscription rules to override them. Example: The subscription rule "Notify: Any ticket changes" overrides the default rule "Never notify: I update a ticket".

This sounds as if adding the rule "Never notify: Ticket that I previously updated is modified" would also override the rule "Notify: Ticket that I'm listed in the CC field is modified". This is not want I want.

(By the way, having "Notify: Ticket that I previously updated is modified" as default rule breaks the operation of un-CCing oneself from a ticket.)