Decoders and types for linear codes

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.43k stars 479 forks source link

Decoders and types for linear codes #20001

Closed 1861b8a9-77f0-4f35-8431-8514a75b40d1 closed 7 years ago

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 8 years ago

Decoders objects in coding theory are associated with a list of types, which are a list of keywords describing to the user the specificites of the underlying decoding algorithm.

For now, the types are not listed nor defined anywhere.

This ticket proposes to create a proper list of types and their definitions.

CC: @sagetrac-dlucas @ClementPernet @jlavauzelle @sagetrac-danielaugot

Component: coding theory

Keywords: rd3

Author: David Lucas, Johan Rosenkilde

Branch/Commit: 6e9c1dc

Reviewer: Johan Rosenkilde

Issue created by migration from https://trac.sagemath.org/ticket/20001

c53d2d39-fa84-47d4-8395-7b4533678d88 commented 8 years ago

comment:1

Could you please mention the files you intend to point out in the sage directory tree ?

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 8 years ago

comment:2

Hello,

I intend to create a list of types and their definitions in decoder.py (sage.coding.decoder), under the generic method decoder_type.

Actually, I originally did that in #19897, but after a discussion in #19623, we found that defining precisely types for decoders wasn't such an easy thing, hence this ticket.

David

0606207b-931f-4eb8-aaff-b4a0f8d02780 commented 8 years ago

comment:4

Hi,

I do not clearly understand what is asked for.

Is a type something like "always_succes", "unique", "list" and so on ? I would then rather call that a property, since it is not a sage type.

Should that be done with a codes.decoders.decoder_types() call, which lists all decoder "types" , with an extremely clear docstring when querying with codes.decoders.decoder_types? ?

Daniel

bdba68b0-6998-4b11-97bd-1e93cfe969fa commented 8 years ago

comment:5

I put my comments in the Issue #151 that Johan pointed out to me. It gives a suggestion on redefining the decoder types.

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

Branch: u/dlucas/decoder_types

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

comment:7

I pushed a table which contains a list of decoder types and their definitions. Open for review.

New commits:

37e738f Table for decoder types

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

Commit: 37e738f

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

Changed keywords from none to rd3

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

Author: David Lucas

johanrosenkilde commented 7 years ago

Changed branch from u/dlucas/decoder_types to u/jsrn/decoder_types

johanrosenkilde commented 7 years ago

Changed commit from 37e738f to 6e9c1dc

johanrosenkilde commented 7 years ago

comment:9

I made some improvements:

Some reformulations.
Used simpler table format for future modifications.
The doc was not present on Decoder instances (which is where most users will see them). I wrote introspection code which propagates the doc of decoder_type to _instance_decoder_type to fix this.

If you're OK, let's get this thing in the air!

New commits:

`70e6052`	`Reformulated some elements. Simpler table format`
`6e9c1dc`	`Don't duplicate doc-string in decoder_type and _instance_decoder_type`

johanrosenkilde commented 7 years ago

Changed author from David Lucas to David Lucas, Johan Rosenkilde

johanrosenkilde commented 7 years ago

Reviewer: Johan Rosenkilde

1861b8a9-77f0-4f35-8431-8514a75b40d1 commented 7 years ago

comment:11

I'm OK, setting to positive review.

David

vbraun commented 7 years ago

Changed branch from u/jsrn/decoder_types to 6e9c1dc