sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.34k stars 452 forks source link

Deprecate support for finite rings in `LinearCode` #20387

Open johanrosenkilde opened 8 years ago

johanrosenkilde commented 8 years ago

Purportedly, LinearCode supports making codes over finite rings. The documentation states only that the ring needs to support "various methods" such as matrices over the ring has a rank function.

However, the underlying assumption in almost all of the code in LinearCode is and has always been that the code is over a finite field. Just because one or two random methods don't (currently) blow up on a code over a finite ring doesn't mean we should claim to support finite rings since all the other functions do blow up or, worse, return wrong or non-sensical results. No-one writing methods for LinearCode is ever thinking of finite rings.

Concrete functions that don't properly work over (most) finite rings: dimension, cardinality, automorphism_*, unencode, canonical_representative, characteristic_polynomial, parity_check_matrix. And there are many more.

The only sensible way forward is to honestly say that we don't support finite rings. If someone really needs finite rings, it is clear that this is yet to be implemented, and that person would hopefully do it. Note that #19345 provides a step in this direction.

CC: @sagetrac-dlucas @ppurka

Component: coding theory

Keywords: linear_code, finite_ring, ring_code

Issue created by migration from https://trac.sagemath.org/ticket/20387

TISHANG-1 commented 1 year ago

where I can find the codebase for these functions: dimension, cardinality, automorphism_*, unencode, canonical_representative, characteristic_polynomial, parity_check_matrix. And there are many more.

kostino commented 11 months ago

@johanrosenkilde Are finite rings still not supported, or has anything changed? Thank you!