search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 481 forks source link

html() of graphics doesn't work #20560

Open vbraun opened 8 years ago

vbraun commented 8 years ago

Basic offender:

html(plot(sin))

spits out TeX wrapped in <script>, can't work. Should probably be <img> with a data URI.

Related casualties are tables having plots as entries:

html(table([[1, plot(sin)]]))

is broken graphics and deprecation warnings.

CC: @kcrisman @paulmasson

Component: user interface

Author: Volker Braun

Branch/Commit: u/vbraun/html_of_graphics @ 8e3170d

Issue created by migration from https://trac.sagemath.org/ticket/20560

vbraun commented 8 years ago

Branch: u/vbraun/html_of_graphics

vbraun commented 8 years ago

Author: Volker Braun

vbraun commented 8 years ago

New commits:

11c75c9Enable saving to in-memory file-like objects
531533cAdd _html_() method for Graphics objects
vbraun commented 8 years ago

Commit: 531533c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 531533c to 3c19131

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3c19131Fix doctest
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8e3170dFix doctest
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 3c19131 to 8e3170d

vbraun commented 8 years ago
comment:5

doctests pass now...

53959995-fd20-47f5-85e6-5e769b863d1f commented 8 years ago
comment:6

Attempting to merge to existing branch gives message:

STDOUT: Auto-merging src/sage/structure/sage_object.pyx
STDOUT: CONFLICT (content): Merge conflict in src/sage/structure/sage_object.pyx
STDOUT: Automatic merge failed; fix conflicts and then commit the result.

Branch currently red.

53959995-fd20-47f5-85e6-5e769b863d1f commented 8 years ago
comment:7

Merge conflict with 7.4.beta5