search

sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.
https://www.sagemath.org
Other
1.14k stars 405 forks source link

Graphic.append() does not update xmin, xmax etc. #206

Closed e13df781-8644-42aa-9d66-1e8d332e25bb closed 16 years ago

e13df781-8644-42aa-9d66-1e8d332e25bb commented 17 years ago

If I add a bunch of graphics primitives to a Graphic object using the Graphic append() method, the __xmax, __xmin, __ymax, __ymin attributes are not updated. Therefore when I try to plot the graphic, nothing shows up. Code for the correct behaviour can be found in the Graphic.__add__() method.

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/206

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 16 years ago
comment:2

http://sage.math.washington.edu/home/rlmill/xmin.patch

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 16 years ago
comment:3

The correct behaviour is not quite that in Graphic.add(), since this is adding two Graphics objects. The reason for this bug is that primitives don't usually remember their xmin/max values, and if they do it's inconsistent.

williamstein commented 16 years ago
comment:5

After a massive amount of discussion, we decided that there should be no Graphic.append method. It just doesn't even make sense. So we removed it and closed this bug.