sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.32k stars 453 forks source link

Added more examples of simplicial complexes #20734

Closed 16bee037-a40f-49da-80f6-39ef26539405 closed 8 years ago

16bee037-a40f-49da-80f6-39ef26539405 commented 8 years ago

Added functionality for shifted simplicial complexes and Rudin's and Ziegler's nonshellable 3-balls.

Depends on #20732

Component: algebraic topology

Keywords: simplicial complex, days74

Author: Jeremy Martin

Branch/Commit: 0880145

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20734

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

2a6f8faAdded examples of simplicial complexes: shifted complexes and Rudin's and Ziegler's balls
a61464fMerge commit '8a5627bd36d289cd2208a44fb9bbc24b0875b117' of git://trac.sagemath.org/sage into SimplicialComplexChanges
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 8a5627b to a61464f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

882c55fAdded functionality for shifted simplicial complexes, Rudin's and Ziegler's nonshellable 3-balls, and the dunce hat.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from a61464f to 882c55f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

2ef8ebaAdded functionality for shifted simplicial complexes, Rudin's and Ziegler's nonshellable 3-balls, and the dunce hat.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 882c55f to 2ef8eba

16bee037-a40f-49da-80f6-39ef26539405 commented 8 years ago
comment:5

Doctests added.

16bee037-a40f-49da-80f6-39ef26539405 commented 8 years ago

Changed keywords from simplicial complex to simplicial complex, days74

videlec commented 8 years ago
comment:7

Many failing doctests (see the patchbot report):

sage -t --long src/sage/homology/examples.py  # 18 doctests failed
tscrim commented 8 years ago

Dependencies: #20732

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fbc0a60Reviewer changes and fixes.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 2ef8eba to fbc0a60

tscrim commented 8 years ago

Reviewer: Travis Scrimshaw

tscrim commented 8 years ago
comment:10

If my changes are good, you can set a positive review.

16bee037-a40f-49da-80f6-39ef26539405 commented 8 years ago
comment:11

Changes look good to me.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from fbc0a60 to 0880145

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

0880145fix two minor grammar/typo issues
vbraun commented 8 years ago

Changed branch from public/homology/simplicial-examples to 0880145