Closed williamstein closed 16 years ago
Attachment: 9124.patch.gz
The attached patch 9124.patch (based on 2.11) implements several completely generic group algorithms, including discrete log, which goes some way towards the issues raised in this ticket.
Many of these functions were first written for elliptic curves over finite fields and then made generic. They work in additive and multiplicative groups. There is one new file sage/groups/generic.py; some older versions which used to be in sage/rings/arith.py have been removed; other changes are just those necessary for all doctests to pass.
So far I have not attepmted to use these functions everywhere they could be (even in the elliptic curve code) since I wanted this to be reviewed first.
On specific question: would this generic code benefit from being done in cython? If so that would be very well worth doing.
Excellent work! The code looks nice and is well-documented. All tests pass as well.
Merged in Sage 3.0.alpha1
Component: basic arithmetic
Issue created by migration from https://trac.sagemath.org/ticket/210