search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

Standardize patches in fricas, frobby #21721

Closed jdemeyer closed 8 years ago

jdemeyer commented 8 years ago

The packages fricas and frobby use non-standard patching.

CC: @embray @dimpase

Component: packages: experimental

Author: Jeroen Demeyer

Branch/Commit: 683e7b9

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21721

jdemeyer commented 8 years ago

Branch: u/jdemeyer/standardize_patches_in_fricasfrobbygap3

jdemeyer commented 8 years ago

New commits:

683e7b9Standardize patches in fricas and frobby
jdemeyer commented 8 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-The packages `fricas`, `frobby`, `gap3` use non-standard patching.
+The packages `fricas` and `frobby` use non-standard patching.
jdemeyer commented 8 years ago

Commit: 683e7b9

mantepse commented 8 years ago
comment:3

I think that fricas shouldn't need the patch anymore, at least with #21377 (but I admit, I cannot package)

mkoeppe commented 8 years ago
comment:5

Cc'ing dimpase, who probably has a script that created the frobby patches.

dimpase commented 8 years ago
comment:6

Replying to @mkoeppe:

Cc'ing dimpase, who probably has a script that created the frobby patches.

no, I think I simply used git to create/update patches.

Otherwise, this simply moves things around, right?

mkoeppe commented 8 years ago
comment:7

This ticket edits the patch to make it -p1 instead of -p0 Wouldn't it be better if there was a public git of the modified frobby, and a script that regenerated the patches?

jdemeyer commented 8 years ago
comment:8

I don't think that we ever use scripts in Sage to generate patches...

mkoeppe commented 8 years ago
comment:9

I know that we don't (with some exceptions), but my point is that it would be better if we did. Our patch management seems ad-hoc (in contrast for example to Debian's tools and documented workflow for this) and few people seem to be aware of git format-patch, which can be used to create a set of patches.

dimpase commented 8 years ago
comment:10

I used git format-patch yesterday for the 1st time :-)

mkoeppe commented 8 years ago
comment:11

Nice. Let's add a short section on how to manage patchsets with git format-patch to the developers' guide...

mkoeppe commented 8 years ago
comment:12

This is #21781.

mkoeppe commented 8 years ago

Reviewer: Matthias Koeppe

vbraun commented 8 years ago

Changed branch from u/jdemeyer/standardize_patches_in_fricasfrobbygap3 to 683e7b9