saraedum commented 7 years ago

Based on the sage package https://github.com/mclf/mac_lane.

Depends on #21782 Depends on #23166 Depends on #23167 Depends on #21879 Depends on #23185 Depends on #23203 Depends on #23204 Depends on #23211 Depends on #23188 Depends on #21879 Depends on #23186 Depends on #23191 Depends on #21996 Depends on #23190 Depends on #23495 Depends on #23483 Depends on #23510 Depends on #23525 Depends on #23620 Depends on #23642 Depends on #23965 Depends on #23966

Component: commutative algebra

Keywords: discrete valuations, valuations, function fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87

Author: Julian Rüth

Branch: 24807e3

Reviewer: GaYee Park, Stefan Wewers, David Roe, Padmavathi Srinivasan, Shiva Chidambaram

Issue created by migration from https://trac.sagemath.org/ticket/21869

5f43a73d-8f1c-4922-9ba6-900149275da1 commented 7 years ago

comment:45

Ran the test and found the error:

sage -t src/sage/rings/function_field/function_field.py # 7 doctests failed

5f43a73d-8f1c-4922-9ba6-900149275da1 commented 7 years ago

Reviewer: GaYee Park

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -8,7 +8,6 @@

[ ] function_field/function_field_valuation.py -[ ] padics/discrete_value_group.py [ ] padics/padic_valuation.py [-] valuation/README.md [x] valuation/init.py

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -8,6 +8,7 @@

[ ] function_field/function_field_valuation.py +[x] padics/discrete_value_group.py [ ] padics/padic_valuation.py [-] valuation/README.md [x] valuation/init.py

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics

saraedum commented 7 years ago

comment:48

Replying to @sagetrac-gpark:

Ran the test and found the error:

sage -t src/sage/rings/function_field/function_field.py # 7 doctests failed

Did you run the tests with all the dependencies applied? About 50 tests fail for me. That's expected (since the dependencies are not in yet.)

saraedum commented 7 years ago

Changed reviewer from GaYee Park to GaYee Park, Stefan Wewers

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -7,7 +7,7 @@
 Please check off `[x]` the following when you think that a file is in good shape (modulo the comments that you made.) Or put a `[-]` if it needs substantial work. You can put your name next to file to tell others that you are already having a look at it.

-[ ] function_field/function_field_valuation.py +[ ] function_field/function_field_valuation.py (Stefan Wewers) [x] padics/discrete_value_group.py [ ] padics/padic_valuation.py [-] valuation/README.md

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -26,6 +26,10 @@
 [ ] valuation/valuations_catalog.py
 [ ] valuation/value_group.py (Padmavathi)

+ +## Testing + +Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in ~/Src/sage-mac_lane/ to try this package out.

Necessary changes

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -29,7 +29,7 @@

 ## Testing

-Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out.
+Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)

 # Necessary changes

saraedum commented 7 years ago

comment:53

The following errors are expected. I am working on them.

----------------------------------------------------------------------
sage -t --warn-long 39.1 src/sage/rings/valuation/limit_valuation.py  # 52 doctests failed
sage -t --warn-long 39.1 src/sage/rings/valuation/gauss_valuation.py  # 1 doctest failed
sage -t --warn-long 39.1 src/sage/rings/valuation/valuation_space.py  # 2 doctests failed
sage -t --warn-long 39.1 src/sage/rings/valuation/mapped_valuation.py  # 42 doctests failed
sage -t --warn-long 39.1 src/sage/rings/valuation/valuation.py  # 9 doctests failed
sage -t --warn-long 39.1 src/sage/rings/valuation/inductive_valuation.py  # 13 doctests failed
sage -t --warn-long 39.1 src/sage/rings/valuation/augmented_valuation.py  # 16 doctests failed
----------------------------------------------------------------------

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -27,10 +27,6 @@
 [ ] valuation/value_group.py (Padmavathi)

-## Testing

-Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)

Necessary changes

Fix bugs in Sage

@@ -52,6 +48,7 @@

ZZ does not map onto QQ #23186
~~ZpCA shifts are broken~~
add default implementation of inverse_of_unit() #23191 +17. R[x]→S[x] is injective/surjective if R→S is #23495

Add new features to Sage

New features that the code needs to work

saraedum commented 7 years ago

Changed dependencies from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -26,6 +26,9 @@
 [ ] valuation/valuations_catalog.py
 [ ] valuation/value_group.py (Padmavathi)

+ +## Testing +Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in ~/Src/sage-mac_lane/ to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)

Necessary changes

saraedum commented 7 years ago

comment:57

Sorry, I somehow reverted some changes to the ticket description. Not sure how this happened.

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -29,6 +29,19 @@

 ## Testing
 Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)
+
+## Known Issues
+
+Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:
+
+```
+sage -t --warn-long 39.1 src/sage/rings/function_field/function_field_valuation.py  # 126 doctests failed
+sage -t --warn-long 39.1 src/sage/rings/valuation/valuation.py  # 9 doctests failed
+sage -t --warn-long 39.1 src/sage/rings/valuation/limit_valuation.py  # 52 doctests failed
+sage -t --warn-long 39.1 src/sage/rings/valuation/mapped_valuation.py  # 42 doctests failed
+sage -t --warn-long 39.1 src/sage/rings/valuation/inductive_valuation.py  # 13 doctests failed
+sage -t --warn-long 39.1 src/sage/rings/valuation/augmented_valuation.py  # 10 doctests failed
+```

 # Necessary changes

roed314 commented 7 years ago

Description changed:

--- 
+++ 
@@ -22,7 +22,7 @@
 [ ] valuation/scaled_valuation.py
 [ ] valuation/trivial_valuation.py
 [ ] valuation/valuation.py
-[ ] valuation/valuation_space.py
+[ ] valuation/valuation_space.py (David)
 [ ] valuation/valuations_catalog.py
 [ ] valuation/value_group.py (Padmavathi)

97c6bb53-f41c-439e-86ad-17ede0c4af9a commented 7 years ago

Description changed:

--- 
+++ 
@@ -7,7 +7,7 @@
 Please check off `[x]` the following when you think that a file is in good shape (modulo the comments that you made.) Or put a `[-]` if it needs substantial work. You can put your name next to file to tell others that you are already having a look at it.

-[ ] function_field/function_field_valuation.py (Stefan Wewers) +[x] function_field/function_field_valuation.py (Stefan Wewers) [x] padics/discrete_value_group.py [ ] padics/padic_valuation.py [-] valuation/README.md

97c6bb53-f41c-439e-86ad-17ede0c4af9a commented 7 years ago

comment:61

I have had a look at function_field_valuation. I have already worked with the code a lot, and it is working fine, and the documentation is extensive and clear. But I have only tested the latest standalone version.

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests

saraedum commented 7 years ago

Changed reviewer from GaYee Park, Stefan Wewers to GaYee Park, Stefan Wewers, David Roe

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

9fd8733 fix import

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from c0a81c8 to 9fd8733

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 9fd8733 to e1e65a5

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e1e65a5 fixed typo

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from e1e65a5 to 9c16a1b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

9c16a1b undo .valuation() shortcut

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 9c16a1b to 119f245

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

119f245 It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 119f245 to 7ea9874

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7ea9874 fix doctests

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -35,12 +35,15 @@
 Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:

-sage -t --warn-long 39.1 src/sage/rings/function_field/function_field_valuation.py # 126 doctests failed -sage -t --warn-long 39.1 src/sage/rings/valuation/valuation.py # 9 doctests failed -sage -t --warn-long 39.1 src/sage/rings/valuation/limit_valuation.py # 52 doctests failed -sage -t --warn-long 39.1 src/sage/rings/valuation/mapped_valuation.py # 42 doctests failed -sage -t --warn-long 39.1 src/sage/rings/valuation/inductive_valuation.py # 13 doctests failed -sage -t --warn-long 39.1 src/sage/rings/valuation/augmented_valuation.py # 10 doctests failed +sage -t --warn-long 61.0 src/sage/rings/number_field/order.py # 1 doctest failed +sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_quotient_ring.py # 2 doctests failed +sage -t --warn-long 61.0 src/sage/rings/valuation/valuation.py # 7 doctests failed +sage -t --warn-long 61.0 src/sage/rings/valuation/augmented_valuation.py # 6 doctests failed +sage -t --warn-long 61.0 src/sage/rings/valuation/inductive_valuation.py # 7 doctests failed +sage -t --warn-long 61.0 src/sage/rings/morphism.pyx # 2 doctests failed +sage -t --warn-long 61.0 src/sage/rings/polynomial/skew_polynomial_element.pyx # 8 doctests failed +sage -t --warn-long 61.0 src/sage/rings/padics/padic_generic.py # 2 doctests failed +sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_ring_homomorphism.pyx # 1 doctest failed


 # Necessary changes

saraedum commented 7 years ago

New commits:

`9fd8733`	`fix import`
`e1e65a5`	`fixed typo`
`9c16a1b`	`undo .valuation() shortcut`
`119f245`	`It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space`
`7ea9874`	`fix doctests`

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests

saraedum commented 7 years ago

Changed dependencies from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 7ea9874 to 0c60cb7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`3fd4140`	`add doctest output`
`0c60cb7`	`fix valuation parameters`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 0c60cb7 to 2010014

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

2010014 restricting to ZZ, we need to know the prime

saraedum commented 7 years ago

Description changed:

--- 
+++ 
@@ -35,15 +35,13 @@
 Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:

+sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_quotient_ring.py # 2 doctests failed +sage -t --warn-long 61.0 src/sage/rings/valuation/augmented_valuation.py # 6 doctests failed sage -t --warn-long 61.0 src/sage/rings/number_field/order.py # 1 doctest failed -sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_quotient_ring.py # 2 doctests failed sage -t --warn-long 61.0 src/sage/rings/valuation/valuation.py # 7 doctests failed -sage -t --warn-long 61.0 src/sage/rings/valuation/augmented_valuation.py # 6 doctests failed sage -t --warn-long 61.0 src/sage/rings/valuation/inductive_valuation.py # 7 doctests failed sage -t --warn-long 61.0 src/sage/rings/morphism.pyx # 2 doctests failed sage -t --warn-long 61.0 src/sage/rings/polynomial/skew_polynomial_element.pyx # 8 doctests failed -sage -t --warn-long 61.0 src/sage/rings/padics/padic_generic.py # 2 doctests failed -sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_ring_homomorphism.pyx # 1 doctest failed


 # Necessary changes

saraedum commented 7 years ago

New commits:

`3fd4140`	`add doctest output`
`0c60cb7`	`fix valuation parameters`
`2010014`	`restricting to ZZ, we need to know the prime`

saraedum commented 7 years ago

Changed work issues from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`e5ef4d8`	`do not catch everything`
`efe2490`	`Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 2010014 to efe2490

roed314 commented 7 years ago

Changed dependencies from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495

roed314 commented 7 years ago

Changed reviewer from GaYee Park, Stefan Wewers, David Roe to GaYee Park, Stefan Wewers

sagemath / sage

A framework for discrete valuations in Sage #21869

Necessary changes

-## Testing

-Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)

Necessary changes

Fix bugs in Sage

Add new features to Sage

Necessary changes

sagemath / sage

A framework for discrete valuations in Sage #21869

Necessary changes

-## Testing

-Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in ~/Src/sage-mac_lane/ to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)

Necessary changes

Fix bugs in Sage

Add new features to Sage

Necessary changes

-Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in `~/Src/sage-mac_lane/` to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)