Closed saraedum closed 7 years ago
Description changed:
---
+++
@@ -4,9 +4,14 @@
sage: f(x) = 1
sage: TestSuite(f.parent()).run()
AttributeError
+sage: 'sum' in dict(f.parent())
+True
+sage: f.parent().sum
+AttributeError
+This is because this symbolic ring does not call its super classes __init__
and therefore it does not inherit correctly the methods of its category.
-Also, some tests do not pass because the factory is not properly used: +Also, some tests do not pass because the pickling provided by factory is not properly used:
sage: f.parent()._test_pickling()
The tests in symbolic/
pass. Let's see what the patchbot thinks.
The commits should make sense one by one. The reviewer might want to review them individually.
Looks good once patchbot approves.
Reviewer: David Roe
Changed branch from u/saraedum/properly_initialize_symbolic_rings to 36c6bb0
Currently
This is because this symbolic ring does not call its super classes
__init__
and therefore it does not inherit correctly the methods of its category.Also, some tests do not pass because the pickling provided by factory is not properly used:
Component: symbolics
Author: Julian Rüth
Branch/Commit:
36c6bb0
Reviewer: David Roe
Issue created by migration from https://trac.sagemath.org/ticket/21893