search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.48k stars 488 forks source link

giac has undeclared dependency on libpng #22163

Closed jdemeyer closed 7 years ago

jdemeyer commented 7 years ago

CC: @frederichan-IMJPRG

Component: packages: standard

Keywords: atelierpari2017

Author: Jeroen Demeyer

Branch: 015a7d8

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/22163

jdemeyer commented 7 years ago

Branch: u/jdemeyer/giac_has_undeclared_dependency_on_libpng

jdemeyer commented 7 years ago

New commits:

015a7d8giac depends on libpng
jdemeyer commented 7 years ago

Commit: 015a7d8

jpflori commented 7 years ago

Reviewer: Jean-Pierre Flori

jpflori commented 7 years ago
comment:4

Does GIAC use -lpng1x rather than -lpng? Or should we patch?

frederichan-IMJPRG commented 7 years ago
comment:5

during the spkg built my Makefile have this:

LIBS = -lrt -lpthread -ldl -lpng -lm -lmpfi -lmpfr -lgmp 
LIBTERMCAP = -ltermcap
jdemeyer commented 7 years ago
comment:6

We probably should patch. But that's not an issue for this ticket.

jpflori commented 7 years ago
comment:7

Ok so let's already merge this.

jdemeyer commented 7 years ago

Changed keywords from none to atelierpari2017

jpflori commented 7 years ago
comment:9

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

frederichan-IMJPRG commented 7 years ago
comment:10

Replying to @jpflori:

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

vbraun commented 7 years ago

Changed branch from u/jdemeyer/giac_has_undeclared_dependency_on_libpng to 015a7d8

edd8e884-f507-429a-b577-5d554626c0fe commented 7 years ago

Changed commit from 015a7d8 to none

edd8e884-f507-429a-b577-5d554626c0fe commented 7 years ago
comment:12

Replying to @frederichan-IMJPRG:

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

For what it worth, for Sage Debian Live, i compile giac (from within Sage) with xcas support, by installing the system's fltk, remove the --disable flag and the nofltk-check.patch, so i guess for such a graphical use, png support could be useful.

What would be a correct patch (so that i can add it to SDL until it get fixed) ?