sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.43k stars 479 forks source link

allow sympy algorithm in solve #22322

Closed kcrisman closed 6 years ago

kcrisman commented 7 years ago

What it says. See e.g. this post for why.

Depends on #23990 Depends on #24104 Depends on #24062

CC: @rwst @mforets @sagetrac-tmonteil @EmmanuelCharpentier

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 8e1e240

Reviewer: Emmanuel Charpentier

Issue created by migration from https://trac.sagemath.org/ticket/22322

rwst commented 7 years ago

Reviewer: Emmanuel Charpentier

rwst commented 7 years ago
comment:47

@EmmanuelCharpentier I hope you don't mind me adding your name.

vbraun commented 6 years ago
comment:49

On OSX:

**********************************************************************
File "src/sage/symbolic/relation.py", line 894, in sage.symbolic.relation.solve
Failed example:
    solve([x^2 - y^2/exp(x), y-1], x, y, algorithm='sympy')
Expected:
    [{y: 1, x: 2*lambert_w(1/2)}]
Got:
    [{x: 2*lambert_w(1/2), y: 1}]
**********************************************************************
File "src/sage/symbolic/relation.py", line 902, in sage.symbolic.relation.solve
Failed example:
    solve([x + y + z + t, -z - t], x, y, z, t, algorithm='sympy')
Expected:
    [{z: -t, x: -y}]
Got:
    [{x: -y, z: -t}]
**********************************************************************
File "src/sage/symbolic/relation.py", line 904, in sage.symbolic.relation.solve
Failed example:
    solve([x^2+y+z, y+x^2+z, x+y+z^2], x, y,z, algorithm='sympy')
Expected:
    [{y: -(z + 1)*z, x: z}, {y: -z^2 + z - 1, x: -z + 1}]
Got:
    [{x: z, y: -(z + 1)*z}, {x: -z + 1, y: -z^2 + z - 1}]
**********************************************************************
1 item had failures:
   3 of 112 in sage.symbolic.relation.solve
    [377 tests, 3 failures, 185.81 s]
----------------------------------------------------------------------
sage -t --long src/sage/symbolic/relation.py  # 3 doctests failed
----------------------------------------------------------------------
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 963cc0e to 8e1e240

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8e1e24022322: dict order-independent doctests
vbraun commented 6 years ago

Changed branch from u/rws/22322-1 to 8e1e240