sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.43k stars 478 forks source link

Add Jupyter kernel for Singular #22378

Closed jdemeyer closed 7 years ago

jdemeyer commented 7 years ago

Demo notebook: https://github.com/OpenDreamKit/OpenDreamKit/blob/master/WP4/D4.4/demo-singular.ipynb

Tarballs:

  1. https://pypi.python.org/packages/c9/cf/6707fc528d813bb3ecaf8803ad643e91c475b113973b43c15819fa3e9246/PySingular-0.9.1.tar.gz

  2. ftp://www.mathematik.uni-kl.de/pub/Math/Singular/misc/surf-1.0.6-gcc6.tar.gz

  3. https://pypi.python.org/packages/41/0a/14570ae37dcdfc7fe1b44fec1baf5200161a440941051722510425674ff5/jupyter_kernel_singular-0.9.2.tar.gz

CC: @nthiery @dimpase

Component: packages: optional

Author: Jeroen Demeyer

Branch: 48e3166

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/22378

jdemeyer commented 7 years ago

Description changed:

--- 
+++ 
@@ -1 +1,7 @@
+**Tarballs**:

+1. https://pypi.python.org/packages/c9/cf/6707fc528d813bb3ecaf8803ad643e91c475b113973b43c15819fa3e9246/PySingular-0.9.1.tar.gz
+
+2. ftp://www.mathematik.uni-kl.de/pub/Math/Singular/misc/surf-1.0.6-gcc6.tar.gz
+
+3. https://pypi.python.org/packages/41/0a/14570ae37dcdfc7fe1b44fec1baf5200161a440941051722510425674ff5/jupyter_kernel_singular-0.9.2.tar.gz
jdemeyer commented 7 years ago

Branch: u/jdemeyer/add_jupyter_kernel_for_singular

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c3b40a3Add jupyter_kernel_singular package
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Commit: c3b40a3

jdemeyer commented 7 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
+**Demo notebook**: https://github.com/OpenDreamKit/OpenDreamKit/blob/master/WP4/D4.4/demo-singular.ipynb
+
 **Tarballs**:

 1. https://pypi.python.org/packages/c9/cf/6707fc528d813bb3ecaf8803ad643e91c475b113973b43c15819fa3e9246/PySingular-0.9.1.tar.gz
dimpase commented 7 years ago
comment:6

appears to work on Linux. I'll check on OSX too, then we'll see (building/running surf might need testing in particular).

dimpase commented 7 years ago
comment:7

by the way, I see the following error messages on console:

[IPKernelApp] ERROR | No such comm target registered: jupyter.widget.version
// ** Could not find dynamic library: p_Procs_FieldZp.so (path /home/dima/Sage/sage-dev/local/bin/../libexec/singular/MOD:/home/dima/Sage/sage-dev/local/libexec/singular/MOD)
// ** Error message from system: /home/dima/Sage/sage-dev/local/bin/../libexec/singular/MOD/p_Procs_FieldZp.so: undefined symbol: omFreeToPageFault
// ** Singular will work properly, but much slower.
// ** See the INSTALL section in the Singular manual for details.
dimpase commented 7 years ago
comment:8

A dodgy macro [RS_CHECK_LIB(m, main) in configure.in leads to inability to build surf on OSX:

checking for main in -lm... no
configure: error: Sorry: can't link with library libm.\(a\|so\).

should be easy to fix...

dimpase commented 7 years ago

Work Issues: fix osx build of surf

jdemeyer commented 7 years ago
comment:9

Replying to @dimpase:

by the way, I see the following error messages on console:

// ** Could not find dynamic library: p_Procs_FieldZp.so (path /home/dima/Sage/sage-dev/local/bin/../libexec/singular/MOD:/home/dima/Sage/sage-dev/local/libexec/singular/MOD)
// ** Error message from system: /home/dima/Sage/sage-dev/local/bin/../libexec/singular/MOD/p_Procs_FieldZp.so: undefined symbol: omFreeToPageFault
// ** Singular will work properly, but much slower.
// ** See the INSTALL section in the Singular manual for details.

That's a known issue upstream.

jdemeyer commented 7 years ago
comment:10

Replying to @dimpase:

A dodgy macro [RS_CHECK_LIB(m, main) in configure.in leads to inability to build surf on OSX:

checking for main in -lm... no
configure: error: Sorry: can't link with library libm.\(a\|so\).

should be easy to fix...

The problem can be solved with --disable-cups. But it still leads to trouble further down, because of a missing -ljpeg, which is not part of Sage.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from c3b40a3 to 2ea9ef3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

2ea9ef3List surf dependencies, do not build by default
jdemeyer commented 7 years ago

Changed work issues from fix osx build of surf to none

dimpase commented 7 years ago
comment:13

shouldn't then surf be downgraded to experimental?

jdemeyer commented 7 years ago
comment:14

Replying to @dimpase:

shouldn't then surf be downgraded to experimental?

Well, the package works, it's just that it has dependencies which are not in Sage. So I don't know what the policy is for that...

dimpase commented 7 years ago
comment:15

shouldn't an optional package be available on all sage-supported platforms?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from 2ea9ef3 to 48e3166

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

48e3166Mark surf as experimental
dimpase commented 7 years ago
comment:17

OK.

vbraun commented 7 years ago
comment:18

Reviewer name

dimpase commented 7 years ago

Reviewer: Dima Pasechnik

vbraun commented 7 years ago

Changed branch from u/jdemeyer/add_jupyter_kernel_for_singular to 48e3166

jdemeyer commented 7 years ago
comment:21

Replying to @dimpase:

shouldn't an optional package be available on all sage-supported platforms?

For the record, rst2ipynb is also optional is not "available on all sage-supported platforms".

jdemeyer commented 7 years ago

Changed commit from 48e3166 to none

dimpase commented 7 years ago
comment:22

Replying to @jdemeyer:

Replying to @dimpase:

shouldn't an optional package be available on all sage-supported platforms?

For the record, rst2ipynb is also optional is not "available on all sage-supported platforms".

Really? Why?

jdemeyer commented 7 years ago
comment:23

Replying to @dimpase:

Replying to @jdemeyer:

Replying to @dimpase:

shouldn't an optional package be available on all sage-supported platforms?

For the record, rst2ipynb is also optional is not "available on all sage-supported platforms".

Really? Why?

Because it depends on pandoc which is not part of Sage.