sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.39k stars 473 forks source link

[with enthuisiastic positive review] get sloane_functions.py to 100% coverage #2275

Closed mwhansen closed 16 years ago

mwhansen commented 16 years ago

CC: @sagetrac-sage-combinat

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/2275

mwhansen commented 16 years ago
comment:1

Attachment: 2275.patch.gz

Here is a link: http://sage.math.washington.edu/home/mhansen/2275.patch

jaapspies commented 16 years ago
comment:2

I don't think this is a good idea:

All sloane_functions have extensive examples, but from design they are
placed just after the class declaration.
It feels stupid to have "internal" functions
starting with '__' or '_' documented with EXAMPLES!

Let us think at the effect on the reference manual.
I don't think it is a good idea to have internal functions like
__init, _repr and other "hidden" fuctions documented with examples
figuring in the Reference Manual.

If we want users of the OEIS to use Sage, we have to provide them with
adequate examples. Maybe raising the doctest coverage with 2% looks good
but it isn't in this case.

Adding some sloane-functions I was following the 'template'. So there
is, maybe, something wrong with the overall design.

Jaap
williamstein commented 16 years ago
comment:3

I disagree with Jaap here. I think getting coverage to 100% is a good idea.

jaapspies commented 16 years ago
comment:4

Replying to @williamstein:

I disagree with Jaap here. I think getting coverage to 100% is a good idea.

Generally spoken yes, but in this case I have my doubts.

Jaap

williamstein commented 16 years ago
comment:5

Looks superb to me.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
comment:6

Merged in Sage 2.10.3.rc1