py3 : about range in homology folder

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.38k stars 470 forks source link

py3 : about range in homology folder #22892

Closed fchapoton closed 7 years ago

fchapoton commented 7 years ago

part of #16081

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: f6a1c53

Reviewer: John Palmieri, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22892

fchapoton commented 7 years ago

New commits:

fd002ed some care for range in homology folder

fchapoton commented 7 years ago

Commit: fd002ed

fchapoton commented 7 years ago

Branch: u/chapoton/22892

jhpalmieri commented 7 years ago

Changed branch from u/chapoton/22892 to u/jhpalmieri/22892

jhpalmieri commented 7 years ago

Changed commit from fd002ed to f6a1c53

jhpalmieri commented 7 years ago

comment:3

Here are some proposed changes. I tried to modify things so that the code would accept Python 3 ranges in more places, rather than just converting to lists or tuples.

New commits:

f6a1c53 trac 22892: range for simplicial complexes and homology

fchapoton commented 7 years ago

comment:5

ok, looks good enough. Travis, do you agree ?

tscrim commented 7 years ago

comment:6

Indeed I do.

tscrim commented 7 years ago

Reviewer: John Palmieri, Travis Scrimshaw

vbraun commented 7 years ago

Changed branch from u/jhpalmieri/22892 to f6a1c53