Closed tscrim closed 6 years ago
Branch pushed to git repo; I updated commit sha1. New commits:
aaeb1c9 | Updating documentation. |
Branch pushed to git repo; I updated commit sha1. New commits:
4c17c8c | Merge branch 'public/lie_algebras/reprs_virasoro-23037' of git://trac.sagemath.org/sage into public/lie_algebras/reprs_virasoro-23037 |
There is one it.next
that should be next(it)
for py3 sake, no ?
and doc does not build, probably because of
+ this for `\{d_i \mid -10 \leq i < 10\}::
EDIT: typo "+ REFERNCES::"
Branch pushed to git repo; I updated commit sha1. New commits:
2fdd3e4 | Use next() and typo fixes. |
Yes, thanks. Fixed.
another issue here:
+ REFERENCES::
has too many colons
Branch pushed to git repo; I updated commit sha1. New commits:
4b9ef94 | No double colon on references. |
Good catch. Fixed.
Description changed:
---
+++
@@ -1,3 +1,3 @@
-We implement the chargeless representations and Verma modules for the Virasoro algebra. Along the way, we also add `witt` to the catalog, fix an issue with actions for Lie algebra elements, and change the bracket convention for the Witt and Virasoro algebras.
+We implement the chargeless representations and Verma modules for the Virasoro algebra. Along the way, we also add `witt` to the catalog and change the bracket convention for the Witt and Virasoro algebras.
A note on the change to the bracket convention: Our current bracket convention is non-standard with the rest of the literature and causes formulas to change in subtle ways. So the easiest thing to do is change it, and I think this will be better in the long run.
A strange sentence here in Verma modules:
+ The Virasoro algebra admits a triangle decomposition of
Maybe you mean of the shape
?
Otherwise, looks good.
Branch pushed to git repo; I updated commit sha1. New commits:
8dfb361 | Tweak documentation. |
Replying to @fchapoton:
A strange sentence here in Verma modules:
+ The Virasoro algebra admits a triangle decomposition of
Maybe you mean
of the shape
?
No, it is a triangular decomposition in the same way of simple Lie algebras or Lie groups by the root system (positive, negative, and 0 parts). I made some tweaks to the documentation; they probably don't help much, but maybe they do.
Otherwise, looks good.
Thank you very much for looking at this.
I understand the triangular decomposition, sure.
You introduced a typo : "trianglar"
I would simply remove the "of"
Branch pushed to git repo; I updated commit sha1. New commits:
999dcfb | Fixes in virasoro.VermaModule. |
Ah, sorry, I misunderstood your comment:11. Here is the fix from comment:14.
Reviewer: Frédéric Chapoton
Thanks. Then good to go.
Thank you again very much for the review!
Changed branch from public/lie_algebras/reprs_virasoro-23037 to 999dcfb
We implement the chargeless representations and Verma modules for the Virasoro algebra. Along the way, we also add
witt
to the catalog and change the bracket convention for the Witt and Virasoro algebras.A note on the change to the bracket convention: Our current bracket convention is non-standard with the rest of the literature and causes formulas to change in subtle ways. So the easiest thing to do is change it, and I think this will be better in the long run.
CC: @sagetrac-sage-combinat @darijgr
Component: algebra
Keywords: lie algebras
Author: Travis Scrimshaw
Branch/Commit:
999dcfb
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/23037