Slowness with unramified extensions of Qp

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.44k stars 480 forks source link

Slowness with unramified extensions of Qp #23172

Open xcaruso opened 7 years ago

xcaruso commented 7 years ago

I noticed that the methods residue and _div_ are ridiculously slow over Zq(p^n, prec) when prec is very large.

Note: the original purpose of the ticket seems to have been resolved due to improvements to expansion method.

Component: padics

Keywords: sd87, padicIMA, padicBordeaux

Author: Vishal Arul

Branch/Commit: u/roed/residue_speed @ f4cb405

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/23172

roed314 commented 7 years ago

Changed keywords from none to sd87

roed314 commented 6 years ago

Changed keywords from sd87 to sd87, padicIMA

roed314 commented 6 years ago

Branch: u/roed/residue_speed

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8ad3281 Add test for residue

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Commit: 8ad3281

365a0c67-81c0-4123-b354-fa6cea4e9402 commented 6 years ago

Changed branch from u/roed/residue_speed to u/varul/residue_speed

365a0c67-81c0-4123-b354-fa6cea4e9402 commented 6 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 I noticed that the methods `residue` and `_div_` are ridiculously slow over `Zq(p^n, prec)` when `prec` is very large.
+
+Note: the original purpose of the ticket seems to have been resolved due to improvements to expansion method.

365a0c67-81c0-4123-b354-fa6cea4e9402 commented 6 years ago

New commits:

15c3eb0 Made residue function faster

365a0c67-81c0-4123-b354-fa6cea4e9402 commented 6 years ago

Changed commit from 8ad3281 to 15c3eb0

365a0c67-81c0-4123-b354-fa6cea4e9402 commented 6 years ago

Author: varul

xcaruso commented 6 years ago

Reviewer: Xavier Caruso

xcaruso commented 6 years ago

comment:8

Looks good to me.

Positive review if the patchbot is happy.

xcaruso commented 6 years ago

Changed author from varul to Vishal Arul

xcaruso commented 6 years ago

comment:9

Patchbot says:

sage -t --long src/sage/rings/padics/padic_base_leaves.py  # 12 doctests failed
sage -t --long src/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py  # 37 doctests failed
sage -t --long src/sage/rings/padics/padic_extension_leaves.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/padic_valuation.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/local_generic.py  # 3 doctests failed
sage -t --long src/sage/rings/padics/padic_ZZ_pX_CR_element.pyx  # 5 doctests failed
sage -t --long src/sage/rings/valuation/gauss_valuation.py  # 1 doctest failed
sage -t --long src/sage/rings/padics/padic_generic.py  # 1 doctest failed

roed314 commented 5 years ago

Changed keywords from sd87, padicIMA to sd87, padicIMA, padicBordeaux

roed314 commented 5 years ago

Changed branch from u/varul/residue_speed to u/roed/residue_speed

roed314 commented 5 years ago

comment:13

I just merged in 8.9.beta9

New commits:

f4cb405 Merge branch 'u/varul/residue_speed' of git://trac.sagemath.org/sage into 23172_residue_speed

roed314 commented 5 years ago

Changed commit from 15c3eb0 to f4cb405