py3: cmp in continued fractions / Klyachko sheaves / coxeter3

[fchapoton]

as another step towards py3

CC: @tscrim @jdemeyer @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: d56f4c0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23366

[fchapoton]

New commits:

3f8d0f0

care for cmp in (coxeter3, Klyachko toric sheaves, continued fractions)

[fchapoton]

Commit: 3f8d0f0

[fchapoton]

Branch: u/chapoton/23366

[tscrim]

comment:3

ElementWrapper implements the _richcmp_ hook, so you do not need the @richcmp_method for CoxeterGroup.Element. Also, I thought @richcmp_method was passed down to subclasses, so I don't think they are needed for the subclasses. Maybe I'm mistaken?

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from 3f8d0f0 to d4baf13

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. New commits:

d4baf13

trac 23366 better use of richcmp_method

[fchapoton]

comment:5

Here is a better version, thanks.

Indeed, inheriting seems to be ok.

[fchapoton]

comment:6

failing doctests ...

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from d4baf13 to d56f4c0

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. New commits:

ae49526	Merge branch 'u/chapoton/23366' in 8.0.rc1
d56f4c0	trac 23366 fixing richcmp for continued fractions

[fchapoton]

comment:9

bot is morally green, please review

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:10

LGTM.

[vbraun]

Changed branch from u/chapoton/23366 to d56f4c0