search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.43k stars 479 forks source link

Exact ring attached to a p-adic ring or field #23507

Closed roed314 closed 7 years ago

roed314 commented 7 years ago

23331 introduced an exact_field method for p-adics. There should be a similar method exact_ring which returns ZZ.extension(self.defining_polynomial(exact=True)) (failing when the defining polynomial does not have integral coefficients).

Depends on #23331

Component: padics

Keywords: sd87

Author: Adele Bourgeois

Branch/Commit: 070b7e0

Reviewer: Sara Chari

Issue created by migration from https://trac.sagemath.org/ticket/23507

roed314 commented 7 years ago

Dependencies: #23331

1a94ad94-8b12-4894-9d6a-6cb84d530d00 commented 7 years ago

Branch: u/abourgeois/exact_ring_attached_to_a_p_adic_ring_or_field

1a94ad94-8b12-4894-9d6a-6cb84d530d00 commented 7 years ago

Commit: 070b7e0

1a94ad94-8b12-4894-9d6a-6cb84d530d00 commented 7 years ago

Last 10 new commits:

6ba62ddFix SEEALSO again
f6366b5Added exact_ring method
0b79df4gfg
b465407Added self argument in exact_ring
597cd38Added exact_ring method for extensions
1b86356Added an example
7d92776Added an example that raises a ValueError
86e1060Fix formatting of documentation
069a4b6More formatting of documentation
070b7e0Fix doctest
1a94ad94-8b12-4894-9d6a-6cb84d530d00 commented 7 years ago

Author: Adele Bourgeois

be5112bc-3711-490d-ac7a-45e6d0aa4f71 commented 7 years ago

Reviewer: Sara Chari

be5112bc-3711-490d-ac7a-45e6d0aa4f71 commented 7 years ago
comment:4

Looks good!

vbraun commented 7 years ago

Changed branch from u/abourgeois/exact_ring_attached_to_a_p_adic_ring_or_field to 070b7e0