Closed JohnCremona closed 16 years ago
Attachment: 8682.patch.gz
Attached patch 8682 fixes both issues: increases m by 1 and uses a dict() for fast lookup of the table.
Applied cleanly to 2.10.3.rc0 and passed sage -testall. Also,
sage: F.<w> = GF(121)
sage: v = w^120
sage: v.log(w)
0
works as it should. Recommend acceptance.
The two new patches to #2356 -- which have a positive review! -- need to be applied after this one. They do in fact supercede this one, there therefore this one gets another positive review by default. I'm sure I am breaking protocol by adding that myself but seriously!
Replying to @JohnCremona:
The two new patches to #2356 -- which have a positive review! -- need to be applied after this one. They do in fact supercede this one, there therefore this one gets another positive review by default. I'm sure I am breaking protocol by adding that myself but seriously!
Hi John,
I assume you refer to the two patches at #277 instead of "The two new patches to #2356 -- which have a positive review!". The positive review is fine in this case and not a breaking of protocol - we shouldn't and don't enforce rules for the sake of rules :)
I will merge both patches shortly and close the tickets assuming the patches apply.
Cheers,
Michael
Merged both in Sage 2.10.3.rc2
Merged the only patch in Sage 2.10.3.rc2 - sorry for the confusion - I meant ticket #277.
Marshall Buck reports (email to sage-support 2008-02-29):
Problem 1. Fails because the list sizes in the baby step giant step method are too small.
Example. [NB This particular example does not fail with 2.10.2]
bombs with:
This can be fixed by changing the append loop to make "g" to {{{range(m +1)}}} instead of
range(m)
. This makes g m+2 long and S2 m-long. Then {{{(m +2)*m >= ord}}}.Coments by John Cremona:
Note that this is related to #277
I already suggested using a dict for the lookup instead of using lists or sets
I will post a patch.
CC: marshbuck@gmail.com
Component: group theory
Issue created by migration from https://trac.sagemath.org/ticket/2356