Make FGP_Modules great again (work over PIDs different from ZZ)

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.38k stars 470 forks source link

Make FGP_Modules great again (work over PIDs different from ZZ) #24027

Open simonbrandhorst opened 7 years ago

simonbrandhorst commented 7 years ago

FGP_Module was written to model finitely generated modules over a principal ideal domain. Currently, only ZZ is tested and works. This ticket is to make it work for all PIDs

Issues:

.denominator() over number fields behaves differently from over ZZ.

Depends on #24031

Component: linear algebra

Branch/Commit: u/sbrandhorst/make_fgp_module_work_over_pids_different_fromzz @ b21796b

Issue created by migration from https://trac.sagemath.org/ticket/24027

simonbrandhorst commented 7 years ago

comment:2

sage: from sage.modules.fg_pid.fgp_module import *
sage: L.<w> = NumberField(x^2 - x + 2)
sage:  OL = L.ring_of_integers()
sage: V = OL**3; W = V.span([[0,w,0], [1,0,1-w]], OL)
sage: Q = FGP_Module(V,W)
sage: TestSuite(Q).run()
sage:

Runs now.

simonbrandhorst commented 7 years ago

Branch: u/sbrandhorst/make_fgp_module_work_over_pids_different_fromzz

simonbrandhorst commented 7 years ago

New commits:

b21796b Alternative for ._clear_denom() where it is not defined.

simonbrandhorst commented 7 years ago

Dependencies: #24031

simonbrandhorst commented 7 years ago

Commit: b21796b