Remove ContinuedFractionField

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.42k stars 478 forks source link

Remove ContinuedFractionField #24115

Closed jdemeyer closed 6 years ago

jdemeyer commented 7 years ago

Deprecated in #20012

Depends on #24337

Component: basic arithmetic

Author: Jeroen Demeyer

Branch/Commit: 3d47c2f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24115

jdemeyer commented 7 years ago

Branch: u/jdemeyer/remove_continuedfractionfield

fchapoton commented 7 years ago

Commit: dff6042

fchapoton commented 7 years ago

comment:2

needs review ?

New commits:

dff6042 Remove ContinuedFractionField

roed314 commented 7 years ago

comment:3

Wait, so if we're getting rid of ContinuedFractionField, what is the right way to get continued fractions for real numbers?

jdemeyer commented 7 years ago

comment:4

Replying to @roed314:

Wait, so if we're getting rid of ContinuedFractionField, what is the right way to get continued fractions for real numbers?

sage: continued_fraction(pi)
[3; 7, 15, 1, 292, 1, 1, 1, 2, 1, 3, 1, 14, 2, 1, 1, 2, 2, 2, 2, ...]

roed314 commented 7 years ago

comment:5

Okay. I think it would be useful to have continued_fraction methods on real numbers and elements of the symbolic ring, but that can be for another ticket.

jdemeyer commented 6 years ago

Dependencies: #24337

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3d47c2f Remove ContinuedFractionField

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from dff6042 to 3d47c2f

tscrim commented 6 years ago

Reviewer: Travis Scrimshaw

tscrim commented 6 years ago

comment:8

LGTM (the patchbot failure should be handled by #24337).

vbraun commented 6 years ago

Changed branch from u/jdemeyer/remove_continuedfractionfield to 3d47c2f