Open jdemeyer opened 6 years ago
Description changed:
---
+++
@@ -6,6 +6,8 @@
warning: sage/rings/padics/CR_template.pxi:779:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'CRElement'. This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:1396:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'. This may cause incorrect vtables to be generated.
warning: sage/rings/padics/FP_template.pxi:1096:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'FPElement'. This may cause incorrect vtables to be generated.
+warning: sage/rings/padics/padic_generic_element.pyx:279:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'pAdicGenericElement'. This may cause incorrect vtables to be generated.
+warning: sage/rings/padics/padic_generic_element.pyx:390:10: Compatible but non-identical C method '_mod_' not redeclared in definition part of extension type 'pAdicGenericElement'. This may cause incorrect vtables to be generated.
This is part of #23600.
Changed keywords from none to padicIMA
Author: Julian Rüth
Branch: u/saraedum/24609
Work Issues: is the patchbot happy?
I have not tested this, but the warnings are gone.
Minor nitpick, but could you use self, other
instead of self, right
?
The implementation uses right
. So I should change all the implementations as well I guess?
I don't care so much. Whatever you feel like.
Changed work issues from is the patchbot happy? to rename right to other; add p parameter to val_unit everywhere
This is part of #23600.
CC: @roed314
Component: padics
Keywords: padicIMA
Work Issues: rename right to other; add p parameter to val_unit everywhere
Author: Julian Rüth
Branch/Commit: u/saraedum/24609 @
a0bac48
Issue created by migration from https://trac.sagemath.org/ticket/24609