sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Expose some normaliz features #25091

Closed jplab closed 5 years ago

jplab commented 6 years ago

Using Normaliz can compute several things that are currently not interfaced. This ticket implements:

FOLLOWUP:

Depends on #27682 Depends on #27716

CC: @videlec @mo271 @mkoeppe @sebasguts @w-bruns @braunmath @tscrim

Component: geometry

Keywords: polytope, normaliz, IMA-PolyGeom

Author: Jean-Philippe Labbé, Matthias Koeppe

Branch/Commit: da05706

Reviewer: Travis Scrimshaw, Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/25091

jplab commented 6 years ago

Branch: u/jipilab/normaliz_features

jplab commented 6 years ago

Commit: e421ff8

jplab commented 6 years ago

Dependencies: #22984, #25090

jplab commented 6 years ago

Last 10 new commits:

737552dUpdating patch with upstream fix for wrong number of lattice points.
530302dMerge branch 'u/tscrim/upgrade_noramliz_pynormaliz-22984' of git://trac.sagemath.org/sage into u/tscrim/upgrade_noramliz_pynormaliz-22984
57d40b0Upgrade Normaliz to 3.5.2.
6ba442dAdding tests from [comment:24](#comment%3A24),25 of #22984.
183087aUpgrade PyNormaliz to 1.12
7f47ec9Adapted the polyhedron docstring
117e428Upgrade normaliz to 3.5.3
7057ef4Merge branch to get docstring adaptation
1b37e8bMerge branch 'develop' into test_normaliz
e421ff8First version of integral pts gen
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from e421ff8 to ac35212

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b6ae686Merge branch 'develop' of git://trac.sagemath.org/sage into t/25090/pynormaliz2
eaedcc2Update PyNormaliz to 1.14
ac35212Merge branch 'normaliz2' into normaliz_features
jplab commented 6 years ago

Changed branch from u/jipilab/normaliz_features to u/jipilab/some_normaliz_features

jplab commented 6 years ago

New commits:

bf8b172Merge branch 'u/mkoeppe/pynormaliz2'
jplab commented 6 years ago

Changed commit from ac35212 to bf8b172

jplab commented 6 years ago

Changed commit from bf8b172 to 9a6af25

jplab commented 6 years ago

New commits:

4dbdc7dUpdated the Cone calls format
0257596Merge branch 'pynormaliz2' into normaliz_features
9a6af25Added volume, first version
jplab commented 6 years ago

Changed branch from u/jipilab/some_normaliz_features to public/some_normaliz_features

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 9a6af25 to 3d3f64a

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3d3f64aHandle default behavior
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 3d3f64a to f376748

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

1dcef4c_init_from_normaliz_data: New, use it in _init_from_*representation
fcd8101Updated pynormaliz to 1.15
f376748Merge branch 'pynormaliz2' into normaliz_features
videlec commented 6 years ago
comment:7

Note that is_package_installed is being deprecated, see #20382

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from f376748 to 55c9a04

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

55c9a04Added Hilbert series
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 55c9a04 to 720dc04

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

720dc04Made tests pass
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 720dc04 to a4ddeac

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a4ddeacCropped feature methods
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

19d8539Polyhedron_normaliz: In verbose mode, write out normaliz format files
4cfcd14_normaliz_format: Fix last change
da8ae7aAdded data and cone methods to normaliz backend
44549faMerge branch 'pynormaliz2' into normaliz_features
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from a4ddeac to 44549fa

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 44549fa to e32c9fd

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e32c9fdAdded triangulate with normaliz
jplab commented 6 years ago

Description changed:

--- 
+++ 
@@ -6,3 +6,5 @@
 - Triangulations

 This ticket provides some new features.
+
+TO DO: Make the bridge with PointConfiguration `triangulate` and the triangulation via normaliz.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

45c39b8Some small edits
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from e32c9fd to 45c39b8

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 45c39b8 to 5679821

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

5679821Added handling the triangulation with point configurations
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b045cafAdapted inhomogeneous case
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 5679821 to b045caf

jplab commented 6 years ago

Description changed:

--- 
+++ 
@@ -3,8 +3,5 @@
 - Integral points generators
 - Volume
 - Euclidean volume
-- Triangulations
-
-This ticket provides some new features.
-
-TO DO: Make the bridge with PointConfiguration `triangulate` and the triangulation via normaliz.
+- Triangulation
+- Hilbert series
mkoeppe commented 6 years ago
comment:18

It's probably best to add all lattice-point related methods to Polyhedron_QQ_normaliz rather than Polyhedron_normaliz in anticipation of #25097 (which moves integral_points and integral_hull there).

jplab commented 6 years ago
comment:19

Replying to @mkoeppe:

It's probably best to add all lattice-point related methods to Polyhedron_QQ_normaliz rather than Polyhedron_normaliz in anticipation of #25097 (which moves integral_points and integral_hull there).

I see. Yes I can do that.

jplab commented 6 years ago
comment:20

Replying to @jplab:

Replying to @mkoeppe:

It's probably best to add all lattice-point related methods to Polyhedron_QQ_normaliz rather than Polyhedron_normaliz in anticipation of #25097 (which moves integral_points and integral_hull there).

I see. Yes I can do that.

As discussed with mkoeppe: The move of the rational polyhedron methods will be done in #25097. The merge should go without conflicts.

jplab commented 6 years ago
comment:21

Replying to @videlec:

Note that is_package_installed is being deprecated, see #20382

Oh! Wow! Thanks for the timely warning! I set it as a dependency. I will change the check once it is merged...

jplab commented 6 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 - Euclidean volume
 - Triangulation
 - Hilbert series
+
+TODO: Adapt the `is_package_installed` for the volume part (see #20382).
jplab commented 6 years ago

Changed dependencies from #22984, #25090 to #22984, #25090, #20382

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from b045caf to e7be14a

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e7be14aFixed some polytopes and added some tests
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from e7be14a to 3615f8d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

aa0e2caMerge branch normaliz3.5.3 and pynormaliz1.12 into sage8.2.rc2
2bbd8a6Update normaliz and pynormaliz
82d7190Merged old changes with latest versions
3615f8dMerge branch 'update_py_normaliz' into normaliz_features
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 3615f8d to 8bff81f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e44cebdMade tests pass for volume
8bff81fFixed the triangulation using normaliz
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

d0e2498Added the Ehrhart Series and Quasi-Polynomial
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 8bff81f to d0e2498

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

668fdfcAdded an example