More polynomials should know that they are irreducible

saraedum commented 6 years ago

Depends on #29266

Component: commutative algebra

Keywords: padicIMA

Work Issues: is the patchbot happy?

Author: Julian Rüth

Branch/Commit: u/soehms/25227 @ 8977f19

Issue created by migration from https://trac.sagemath.org/ticket/25227

saraedum commented 6 years ago

Branch: u/saraedum/irreducible

saraedum commented 6 years ago

Changed branch from u/saraedum/irreducible to none

saraedum commented 6 years ago

Branch: u/saraedum/25227

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Commit: 847a4e7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

847a4e7 Merge develop and 25227

saraedum commented 6 years ago

New commits:

`57e6d44`	`Teach more rings about irreducible polynomials`
`cf4bebf`	`Merge remote-tracking branch 'trac/u/saraedum/irreducible' into HEAD`
`847a4e7`	`Merge develop and 25227`

saraedum commented 6 years ago

Work Issues: docstrings

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`3cf6c75`	`Merge develop and 25227`
`93e8d51`	`Add docstrings for _is_irreducible_univariate_polynomial()`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 847a4e7 to 93e8d51

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d2bc6fe Add docstrings for _is_irreducible_univariate_polynomial()

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 93e8d51 to d2bc6fe

saraedum commented 6 years ago

Changed work issues from docstrings to is the patchbot happy?

fchapoton commented 6 years ago

comment:9

one doctest failing (typo)

and pyflakes plugin is not happy

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from d2bc6fe to 2d43fe7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`cacb467`	`silence pyflakes`
`2d43fe7`	`fix typo`

saraedum commented 6 years ago

New commits:

`cacb467`	`silence pyflakes`
`2d43fe7`	`fix typo`

New commits:

`cacb467`	`silence pyflakes`
`2d43fe7`	`fix typo`

roed314 commented 6 years ago

Changed keywords from none to padicIMA

fchapoton commented 5 years ago

comment:14

red branch => needs work

soehms commented 4 years ago

Changed branch from u/saraedum/25227 to u/soehms/25227

soehms commented 4 years ago

Changed commit from 2d43fe7 to 8977f19

soehms commented 4 years ago

comment:16

I rebase the implementation to 9.1.beta5 and insert a dependency to ticket #29266 which fixes a bug of #26421, since the latter one cause one of the doctest to fail.

Note, that the following doctests of the present ticket already worked under the previous stable release 8.1:

┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 8.1, Release Date: 2017-12-07                     │
│ Type "notebook()" for the browser-based notebook interface.        │
│ Type "help()" for help.                                            │
└────────────────────────────────────────────────────────────────────┘
sage: S.<t> = QQ[]
sage: R.<x> = S[]
sage: f = t*x
sage: f.is_irreducible()
False
sage: f = t*x + (t+1)
sage: f.is_irreducible()
True
sage: R.<x> = ZZ[]
sage: f = 2*x
sage: f.is_irreducible()
False
sage: f = 2*x + 3
sage: f.is_irreducible()
True
sage:

Therefore, they don't make clear what is improved by the corresponding implementation. I would replace these doctests by examples which don't work without the implementation of the ticket.

New commits:

`ffa9302`	`Merge branch 'u/saraedum/25227' of git://trac.sagemath.org/sage into more_polynomials_irreducible_25227`
`004c1c4`	`29266 initial version`
`8977f19`	`Merge branch 'factorization_integral_domain_29266' into more_polynomials_irreducible_25227`

soehms commented 4 years ago

Dependencies: #29266

sagemath / sage

More polynomials should know that they are irreducible #25227