sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.22k stars 425 forks source link

Clean up UniqueRepresentations in sage.algebra (part 2) #25389

Open embray opened 6 years ago

embray commented 6 years ago

This is like #25387 but adds UniqueRepresentation to classes that weren't using it (specifically in sage.algebras.quatalg) but looked like they could benefit.

Depends on #25388

Component: algebra

Author: Erik Bray

Branch/Commit: u/embray/misc/unique-repr/algebras-2 @ 9ea55d9

Reviewer: Nils Bruin

Issue created by migration from https://trac.sagemath.org/ticket/25389

embray commented 6 years ago

comment:2

Per nbruin's comments on #25388, it doesn't really make sense and/or is overkill to use UniqueRepresentation for quaternion algebras, and what I really want here is some hypothetical mix-in class that provides equality and hashing by some specific set of attributes of each instance--typically attributes whose values are provided to the __init__ (so long as they are hashable).

embray commented 6 years ago

Reviewer: Nils Bruin

embray commented 6 years ago

comment:3

25672 goes ahead and implements a `hash` for quaternion algebras. I believe this should ultimately be removed as in this ticket (alone with the `eq`), but first we need the hypothetical class I mention above.

embray commented 6 years ago

comment:4

I believe this issue can reasonably be addressed for Sage 8.4.

embray commented 5 years ago

comment:6

Retargeting some of my tickets (somewhat optimistically for now).

embray commented 5 years ago

comment:7

Moving all my in-progress tickets to 8.8 milestone.

embray commented 5 years ago

comment:8

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

embray commented 4 years ago

comment:9

Ticket retargeted after milestone closed

mkoeppe commented 4 years ago

comment:10

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

mkoeppe commented 3 years ago

comment:12

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

mkoeppe commented 3 years ago

comment:13

Setting a new milestone for this ticket based on a cursory review.

sagemath / sage

Clean up UniqueRepresentations in sage.algebra (part 2) #25389

25672 goes ahead and implements a __hash__ for quaternion algebras. I believe this should ultimately be removed as in this ticket (alone with the __eq__), but first we need the hypothetical class I mention above.

25672 goes ahead and implements a `hash` for quaternion algebras. I believe this should ultimately be removed as in this ticket (alone with the `eq`), but first we need the hypothetical class I mention above.