Upgrade to cryptominisat 5.6.6 (and make it an optional package again)

videlec commented 6 years ago

Update cryptominisat to 5.6.6.

Tarball at

https://github.com/msoos/cryptominisat/archive/5.6.6.tar.gz

(to be renamed cryptominisat-5.6.6.tar.gz)

Compilation issues which had caused cryptominisat to be downgraded from "optional" to "experimental" in Sage are fixed in the 5.6.x releases. Note that old installations have to be removed because of interference of header files (see e.g. issue 5).

CC: @sagetrac-tmonteil @embray @saraedum @slel

Component: packages: optional

Keywords: cryptominisat, upgrade

Author: Vincent Delecroix, Thierry Monteil

Branch/Commit: d483861

Reviewer: Jeroen Demeyer, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/25480

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`48338de`	`Merge branch 'u/tmonteil/25480' of trac.sagemath.org:sage into HEAD`
`d483861`	`#25480 : update a doctest after #26676 has been merged.`

edd8e884-f507-429a-b577-5d554626c0fe commented 5 years ago

comment:38

I updated a doctest coming from #26676 (which has been merged). Still needs review.

videlec commented 5 years ago

comment:39

builds fine and tests pass for me.

videlec commented 5 years ago

Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Vincent Delecroix

vbraun commented 5 years ago

Changed branch from u/tmonteil/25480 to d483861

sagemath / sage

Upgrade to cryptominisat 5.6.6 (and make it an optional package again) #25480