Move multi-variate polynomials to new coercion model

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.44k stars 480 forks source link

Move multi-variate polynomials to new coercion model #25558

Open jdemeyer opened 6 years ago

jdemeyer commented 6 years ago

CC: @AndrewAtLarge @tscrim @mwageringel

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/25558 @ 160624f

Issue created by migration from https://trac.sagemath.org/ticket/25558

jdemeyer commented 6 years ago

Dependencies: #25555

jdemeyer commented 6 years ago

Branch: u/jdemeyer/ticket/25558

jdemeyer commented 6 years ago

Commit: d6b2d6a

jdemeyer commented 6 years ago

New commits:

`e1bb9b6`	Replace `_coerce_` checks by has_coerce_map_from
`d6b2d6a`	`Move multi-variate polynomials to new coercion model`

jdemeyer commented 6 years ago

Changed dependencies from #25555 to #25555, #25563

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`a3559d8`	`Rename MPolynomialRing_generic -> MPolynomialRing_base`
`2717d6e`	`Move multi-variate polynomials to new coercion model`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from d6b2d6a to 2717d6e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 2717d6e to 160624f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

160624f Move multi-variate polynomials to new coercion model

jdemeyer commented 5 years ago

Changed dependencies from #25555, #25563 to none

Etn40ff commented 5 years ago

comment:10

In #26741 Jeroen mentioned that he might be too busy to work on this full time.

If the stars align properly I will try to be at "Calcul Mathématique Libre" and I would be happy to work on this there but, as I said, I might need some guidance to do so. Would any of the attendees be willing/able to provide it?

tscrim commented 5 years ago

comment:11

I will not be there, but I can try to be available remotely to work on it.

Etn40ff commented 5 years ago

comment:12

Thanks Travis, I hope I'll be able to be there.

jdemeyer commented 5 years ago

Dependencies: #27034

jdemeyer commented 5 years ago

comment:13

Said conference is this week but given that neither of you are here there is no real point in doing it right now.

dkrenn commented 5 years ago

comment:14

I am not sure what exactly will be done on this ticket, but FYI there was some low level stuff regarding conversion done at #21855 in src/sage/rings/polynomial/laurent_polynomial_ring.py (_split_dict_ functions).

(This comment is a result of mentioning this ticket here at #27255.)

Etn40ff commented 5 years ago

comment:15

Sorry for flying off the radars for a while but I had an unexpected change of job. The dust is still settling but I should be able to resume working on this whenever you want to.

embray commented 5 years ago

comment:16

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

dkrenn commented 5 years ago

comment:17

Are there any more concrete plans working on this ticket?

embray commented 5 years ago

comment:18

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

mkoeppe commented 3 years ago

comment:20

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

videlec commented 3 years ago

Changed dependencies from #27034 to none