Open saraedum opened 6 years ago
Description changed:
---
+++
@@ -1 +1,3 @@
Currently, a polynomial's `splitting_field()` is only implemented for finite fields and number fields. This can not be easily extended by user provided constructions such as Henselizations, https://github.com/MCLF/henselization.
+
+I'll also fix a bunch of documentation errors while I am at it…
Branch: u/saraedum/25938
New commits:
f01d916 | splitting_field() calls _splitting_field_univariate_polynomial() |
Work Issues: is the patchbot happy?
I only ran rudimentary doctests.
Changed keywords from none to padicIMA
Reviewer: David Roe
Changed work issues from is the patchbot happy? to none
Looks good!
sage -t --long src/sage/rings/number_field/number_field_base.pyx
**********************************************************************
File "src/sage/rings/number_field/number_field_base.pyx", line 423, in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
Failed example:
L
Expected:
Number Field in b with defining polynomial t^2 - 4*t + 6
Got:
Number Field in b with defining polynomial t^2 + 2
**********************************************************************
1 item had failures:
1 of 6 in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
[79 tests, 1 failure, 1.55 s]
----------------------------------------------------------------------
sage -t --long src/sage/rings/number_field/number_field_base.pyx # 1 doctest failed
----------------------------------------------------------------------
Currently, a polynomial's
splitting_field()
is only implemented for finite fields and number fields. This can not be easily extended by user provided constructions such as Henselizations, https://github.com/MCLF/henselization.I'll also fix a bunch of documentation errors while I am at it…
Component: padics
Keywords: padicIMA
Author: Julian Rüth
Branch/Commit: u/saraedum/25938 @
f01d916
Reviewer: David Roe
Issue created by migration from https://trac.sagemath.org/ticket/25938