splitting_field should call the base ring's _splitting_field_univariate_polynomial

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.3k stars 449 forks source link

splitting_field should call the base ring's _splitting_field_univariate_polynomial #25938

Open saraedum opened 6 years ago

saraedum commented 6 years ago

Currently, a polynomial's splitting_field() is only implemented for finite fields and number fields. This can not be easily extended by user provided constructions such as Henselizations, https://github.com/MCLF/henselization.

I'll also fix a bunch of documentation errors while I am at it…

Component: padics

Keywords: padicIMA

Author: Julian Rüth

Branch/Commit: u/saraedum/25938 @ f01d916

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25938

saraedum commented 6 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 Currently, a polynomial's `splitting_field()` is only implemented for finite fields and number fields. This can not be easily extended by user provided constructions such as Henselizations, https://github.com/MCLF/henselization.
+
+I'll also fix a bunch of documentation errors while I am at it…

saraedum commented 6 years ago

Branch: u/saraedum/25938

saraedum commented 6 years ago

New commits:

f01d916 splitting_field() calls _splitting_field_univariate_polynomial()

saraedum commented 6 years ago

Commit: f01d916

saraedum commented 6 years ago

Work Issues: is the patchbot happy?

saraedum commented 6 years ago

comment:4

I only ran rudimentary doctests.

saraedum commented 6 years ago

Changed keywords from none to padicIMA

roed314 commented 6 years ago

Reviewer: David Roe

roed314 commented 6 years ago

Changed work issues from is the patchbot happy? to none

roed314 commented 6 years ago

comment:6

Looks good!

vbraun commented 6 years ago

comment:7

sage -t --long src/sage/rings/number_field/number_field_base.pyx
**********************************************************************
File "src/sage/rings/number_field/number_field_base.pyx", line 423, in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
Failed example:
    L
Expected:
    Number Field in b with defining polynomial t^2 - 4*t + 6
Got:
    Number Field in b with defining polynomial t^2 + 2
**********************************************************************
1 item had failures:
   1 of   6 in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
    [79 tests, 1 failure, 1.55 s]
----------------------------------------------------------------------
sage -t --long src/sage/rings/number_field/number_field_base.pyx  # 1 doctest failed
----------------------------------------------------------------------