rubiks makefile should use MAKE

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.39k stars 473 forks source link

rubiks makefile should use MAKE #26250

Closed dimpase closed 6 years ago

dimpase commented 6 years ago

If your make is not GNU make, it breaks, as you cannot use MAKE to overwrite make.

Patch made by Li-Wen Hsu here

CC: @kiwifb

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: f99d86f

Reviewer: Li-Wen Hsu

Issue created by migration from https://trac.sagemath.org/ticket/26250

dimpase commented 6 years ago

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
 If your `make` is not GNU make, it breaks, as you cannot
 use `MAKE` to overwrite `make`.
+
+Patch made by Li-Wen Hsu [here](https://github.com/lwhsu/sagemath/commit/5bdcf0bcea2b9feab636e7e22961ba102f38816a)

dimpase commented 6 years ago

Author: Dima Pasechnik

dimpase commented 6 years ago

Branch: u/dimpase/rubiks_MAKE

dimpase commented 6 years ago

Commit: f99d86f

dimpase commented 6 years ago

comment:2

this is a part of #26249

lwhsu commented 6 years ago

Reviewer: Li-Wen Hsu

vbraun commented 6 years ago

Changed branch from u/dimpase/rubiks_MAKE to f99d86f