sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.43k stars 479 forks source link

py3: MInor sorting issue with Stanley-Reisner ring #26277

Closed jhpalmieri closed 6 years ago

jhpalmieri commented 6 years ago

Fix one doctest in Python 3 by sorting the generators of the polynomial ring used to define the Stanley-Reisner ring of a simplicial complex.

CC: @fchapoton @tscrim

Component: python3

Author: John Palmieri

Branch/Commit: 694fe31

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26277

jhpalmieri commented 6 years ago

Branch: u/jhpalmieri/stanley-reisner-sorting

jhpalmieri commented 6 years ago

New commits:

694fe31trac 26277: sort the generators in _stanley_reisner_base_ring.
jhpalmieri commented 6 years ago

Commit: 694fe31

jhpalmieri commented 6 years ago
comment:3

By the way, there are other Python 3 failures with Stanley-Reisner rings, of the form

File "src/sage/homology/simplicial_complex.py", line 86, in sage.homology.simplicial_complex
Failed example:
    X.stanley_reisner_ring()
Expected:
    Quotient of Multivariate Polynomial Ring in x0, x1, x2, x3 over Integer Ring by the ideal (x1*x3, x0*x2)
Got:
    Quotient of Multivariate Polynomial Ring in x0, x1, x2, x3 over Integer Ring by the ideal (x0*x2, x1*x3)

These have to do with how ideals for polynomial rings are printed, so it's coming from code in sage.rings.

fchapoton commented 6 years ago

Reviewer: Frédéric Chapoton

fchapoton commented 6 years ago
comment:4

ok

vbraun commented 6 years ago

Changed branch from u/jhpalmieri/stanley-reisner-sorting to 694fe31