search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.35k stars 462 forks source link

Upgrade to cypari2-2.0.3 #26442

Closed jdemeyer closed 5 years ago

jdemeyer commented 5 years ago

Tarball: https://files.pythonhosted.org/packages/64/bd/93fd5d8e7515a87be0f74958d0e1dd1b67ac0d009c0ca4d36be891e72c49/cypari2-2.0.3.tar.gz

Depends on #27060

CC: @videlec @defeo @kiwifb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: cd62d45

Reviewer: Vincent Delecroix, Timo Kaufmann

Issue created by migration from https://trac.sagemath.org/ticket/26442

jdemeyer commented 5 years ago

Changed dependencies from #26396 to #25292

jdemeyer commented 5 years ago

Changed dependencies from #25292 to #25292, #26493

jdemeyer commented 5 years ago

Changed dependencies from #25292, #26493 to #26396, #26493

jdemeyer commented 5 years ago

Branch: u/jdemeyer/upgrade_to_cypari2_2_0_0

jdemeyer commented 5 years ago

Commit: 6b70ed0

jdemeyer commented 5 years ago

Changed dependencies from #26396, #26493 to none

jdemeyer commented 5 years ago

New commits:

81947f6Use PARI clones instead of deepcopy_to_python_heap()
6b70ed0Upgrade to cypari2 version 2
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 6b70ed0 to e40bd8f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e40bd8fUpgrade to cypari2 version 2
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from e40bd8f to b4bcb4b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b4bcb4bUpgrade to cypari2 version 2
jdemeyer commented 5 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-This is not yet officially released, but work in progress.
+**Tarball**: https://files.pythonhosted.org/packages/a3/7b/2c617483bc33162e9059265b19cab905bf34d323f64082de4f4ea8d400cd/cypari2-2.0.0.tar.gz
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cec13a7Upgrade to cypari2 version 2.0.0
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from b4bcb4b to cec13a7

videlec commented 5 years ago
comment:12

Testing integer.pyx shows a "bad" behavior

File "rings/integer.pyx", line 6767, in sage.rings.integer.Integer.binomial
Failed example:
    for i in [1..10]:  # long time (5s)
        try:
            alarm(i/11)
            (2^100).binomial(2^22, algorithm='pari')
        except AlarmInterrupt:
            pass
Expected nothing
Got:
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16b53f3c40
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16aae64038
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a1af7f88
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a1af7f88
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a1af7f88
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a8ef7f88
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a4612528
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a4b0c988
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a22f7f88
    ERROR: inconsistent avma when removing Gen from PARI stack
    Expected: 0x7f16bcaf7fc8
    Actual:   0x7f16a37a5008
**********************************************************************
1 item had failures:
   1 of  16 in sage.rings.integer.Integer.binomial
    [1121 tests, 1 failure, 18.28 s]
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from cec13a7 to 486a112

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

486a112Upgrade to cypari2 version 2.0.1
jdemeyer commented 5 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-**Tarball**: https://files.pythonhosted.org/packages/a3/7b/2c617483bc33162e9059265b19cab905bf34d323f64082de4f4ea8d400cd/cypari2-2.0.0.tar.gz
+**Tarball**: https://files.pythonhosted.org/packages/a5/8a/c0cd4ace712745f6d40f35feeb6795812ea78a5ccb30cc176a57ef83ec34/cypari2-2.0.1.tar.gz
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 486a112 to 7905b39

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7905b39Upgrade to cypari2 version 2.0.1
jdemeyer commented 5 years ago
comment:18

ping?

videlec commented 5 years ago

Reviewer: Vincent Delecroix

videlec commented 5 years ago
comment:19

Good for me. Thanks for this new release of cypari2!

jdemeyer commented 5 years ago
comment:20

So positive review then?

videlec commented 5 years ago
comment:21

Indeed.

jdemeyer commented 5 years ago
comment:22

Thanks!

vbraun commented 5 years ago
comment:23

Is the testsuite supposed to work? (SAGE_DEBUG=yes)

[cypari-2.0.1] Testing cypari2.gen
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] 
[cypari-2.0.1] *** SIG 6 *** inside sig_on
[cypari-2.0.1] do_raise_exception(sig=6)
[cypari-2.0.1] PyErr_Occurred() = 0x11f4fb0
[cypari-2.0.1] Raising Python exception 0 ms after signal...
[cypari-2.0.1] ------------------------------------------------------------------------
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x5226)[0x7f47616ee226]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x5406)[0x7f47616ee406]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x48ae)[0x7f47616ed8ae]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x4a7f)[0x7f47616eda7f]
[cypari-2.0.1] /lib64/libpthread.so.0(+0x11fb0)[0x7f4765c6dfb0]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.6(+0x55d557)[0x7f47627fe557]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.6(+0x55d562)[0x7f47627fe562]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.6(+0x55d5c6)[0x7f47627fe5c6]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.6(gclone+0x28)[0x7f47627fe7cd]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cypari2/stack.so(+0x669c)[0x7f476190e69c]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cypari2/pari_instance.so(+0x21974d)[0x7f47630f774d]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cypari2/pari_instance.so(+0x21a203)[0x7f47630f8203]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cypari2/pari_instance.so(+0x21a0dc)[0x7f47630f80dc]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0xe2aca)[0x7f4765f5daca]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyObject_Call+0x7f)[0x7f4765ecd58a]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x164f67)[0x7f4765fdff67]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x1642a7)[0x7f4765fdf2a7]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0xb52b)[0x7f4765fd9663]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x1148)[0x7f4765fdc58f]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCode+0x41)[0x7f4765fce113]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x166ca8)[0x7f4765fe1ca8]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6145)[0x7f4765fd427d]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x1148)[0x7f4765fdc58f]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x1646c0)[0x7f4765fdf6c0]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x16428b)[0x7f4765fdf28b]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0xb52b)[0x7f4765fd9663]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x1148)[0x7f4765fdc58f]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x1646c0)[0x7f4765fdf6c0]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x16428b)[0x7f4765fdf28b]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0xb52b)[0x7f4765fd9663]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x1148)[0x7f4765fdc58f]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x1646c0)[0x7f4765fdf6c0]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x16428b)[0x7f4765fdf28b]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0xb52b)[0x7f4765fd9663]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x1148)[0x7f4765fdc58f]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCode+0x41)[0x7f4765fce113]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x1965a6)[0x7f47660115a6]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyRun_FileExFlags+0xb7)[0x7f476601152c]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyRun_SimpleFileExFlags+0x2e5)[0x7f476600fba1]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyRun_AnyFileExFlags+0x88)[0x7f476600f1db]
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(Py_Main+0xd2d)[0x7f476602b675]
[cypari-2.0.1] python(main+0x20)[0x400756]
[cypari-2.0.1] /lib64/libc.so.6(__libc_start_main+0xeb)[0x7f476512511b]
[cypari-2.0.1] python(_start+0x2a)[0x40067a]
[cypari-2.0.1] ------------------------------------------------------------------------
[cypari-2.0.1] Unhandled SIGSEGV: A segmentation fault occurred.
[cypari-2.0.1] This probably occurred because a *compiled* module has a bug
[cypari-2.0.1] in it and is not properly wrapped with sig_on(), sig_off().
[cypari-2.0.1] Python will now terminate.
[cypari-2.0.1] ------------------------------------------------------------------------
[cypari-2.0.1] make[4]: *** [Makefile:16: check] Segmentation fault (core dumped)
[cypari-2.0.1] make[4]: Leaving directory '/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/cypari-2.0.1/src'
[cypari-2.0.1] 
[cypari-2.0.1] real 0m2.838s
[cypari-2.0.1] user 0m2.261s
[cypari-2.0.1] sys  0m0.093s
[cypari-2.0.1] ************************************************************************
[cypari-2.0.1] Error testing package cypari-2.0.1
[cypari-2.0.1] ************************************************************************
[cypari-2.0.1] Please email sage-devel (http://groups.google.com/group/sage-devel)
[cypari-2.0.1] explaining the problem and including the log file
[cypari-2.0.1]   /mnt/disk/home/buildslave-sage/slave/sage_git/build/logs/pkgs/cypari-2.0.1.log
[cypari-2.0.1] Describe your computer, operating system, etc.
[cypari-2.0.1] If you want to try to fix the problem yourself, *don't* just cd to
[cypari-2.0.1] /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/cypari-2.0.1 and type 'make check' or whatever is appropriate.
[cypari-2.0.1] Instead, the following commands setup all environment variables
[cypari-2.0.1] correctly and load a subshell for you to debug the error:
[cypari-2.0.1]   (cd '/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/var/tmp/sage/build/cypari-2.0.1' && '/mnt/disk/home/buildslave-sage/slave/sage_git/build/sage' --sh)
[cypari-2.0.1] When you are done debugging, you can type "exit" to leave the subshell.
[cypari-2.0.1] ************************************************************************
make[3]: *** [Makefile:2124: /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/var/lib/sage/installed/cypari-2.0.1] Error 1
make[3]: Target 'all-sage' not remade because of errors.
make[3]: Leaving directory '/mnt/disk/home/buildslave-sage/slave/sage_git/build/build/make'
make[2]: *** [Makefile:1806: all-build] Error 2
make[2]: Target 'build-start' not remade because of errors.
make[2]: Leaving directory '/mnt/disk/home/buildslave-sage/slave/sage_git/build/build/make'
kiwifb commented 5 years ago
comment:24

It's supposed to work. The upstream repo is tested with travis and the test suite runs here on Gentoo. Is it a one off machine or a variety of machines?

jhpalmieri commented 5 years ago
comment:25

For what it's worth, it passes on OS X Mojave, although with some warnings:

Running the test suite for cypari-2.0.1...
python -u tests/rundoctest.py
================================================================================
Testing cypari2.closure
================================================================================
Testing cypari2.convert
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 72 bytes on the PARI stack
  compileflags, 1) in test.globs
================================================================================
Testing cypari2.gen
================================================================================
Testing cypari2.handle_error
  ***   user warning: test
================================================================================
Testing cypari2.pari_instance
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 158187944 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 390197216 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 275990048 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 375226304 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 288216680 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 416977632 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 444596288 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 343465920 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 379927792 bytes on the PARI stack
  compileflags, 1) in test.globs
/Users/jpalmier/Desktop/Sage/git/sage/local/lib/python2.7/doctest.py:1315: RuntimeWarning: cypari2 leaked 398485936 bytes on the PARI stack
  compileflags, 1) in test.globs
================================================================================
Testing cypari2.stack
================================================================================
Testing cypari2.string_utils
================================================================================
Testing autogen.doc
================================================================================
Testing autogen.generator
================================================================================
Testing autogen.parser
================================================================================
Testing autogen.paths
================================================================================
Summary result for cypari2:
   attempted = 1291
   failed = 0
kiwifb commented 5 years ago
comment:26

I have the warnings on linux too. Different numbers but same warnings. However nothing is fatal unlike Volker's log.

jdemeyer commented 5 years ago
comment:27

Replying to @vbraun:

Is the testsuite supposed to work? (SAGE_DEBUG=yes)

Is that error reproducible? I cannot immediately reproduce it. If it's not reproducible, it might be a random race condition, unrelated to SAGE_DEBUG.

vbraun commented 5 years ago
comment:28

lets give it another try...

jdemeyer commented 5 years ago
comment:29

If you do reproduce the problem, please let me login to that machine to debug.

jdemeyer commented 5 years ago
comment:30

Never mind, I managed to reproduce it after building all of Sage with SAGE_DEBUG=yes.

jdemeyer commented 5 years ago
comment:31

Somehow the test suite runs out of memory with SAGE_DEBUG=yes. This out-of-memory condition is not processed properly, leading to a crash.

jdemeyer commented 5 years ago
comment:32

This fails whenever Python is compiled with SAGE_DEBUG=yes.

timokau commented 5 years ago
comment:33

I assumed this was only an issue with SAGE_DEBUG, so I updated cypari2 on nix. It tested fine locally, but I see a segfault when doctesting sage on our buildserver: https://nix-cache.s3.amazonaws.com/log/f72zl576819vraijymr4dpx9kp4jim4q-sage-tests-8.4.drv

jdemeyer commented 5 years ago
comment:34

That does indeed look like the same problem. I have not spent much time on fixing it, but I will.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 7905b39 to e949ce9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e949ce9Upgrade to cypari2 version 2.0.1
jdemeyer commented 5 years ago
comment:36

I don't know what happened, but I can no longer reproduce the problem mentioned at [comment:23]

If somebody else can, please be so kind to give me access to that machine to debug the problem.

timokau commented 5 years ago
comment:37

It was a semi-random error and I was able to reproduce it once ([comment:33]). I think immediately going positive_review just because it doesn't reproduce right now is a bad idea.

jdemeyer commented 5 years ago
comment:38

Maybe the upgrade to PARI-2.11.1 (#26725) fixed something?

jdemeyer commented 5 years ago
comment:39

Replying to @timokau:

It was a semi-random error

I believe that the error with SAGE_DEBUG=yes was a reproducible non-random error. It may or may not be the same bug as the one you encountered on nix.

jdemeyer commented 5 years ago
comment:40

Replying to @timokau:

I think immediately going positive_review just because it doesn't reproduce right now is a bad idea.

So what do you suggest instead?

timokau commented 5 years ago
comment:41

Replying to @jdemeyer:

Maybe the upgrade to PARI-2.11.1 (#26725) fixed something?

Maybe.

Replying to @jdemeyer:

Replying to @timokau:

It was a semi-random error

I believe that the error with SAGE_DEBUG=yes was a reproducible non-random error. It may or may not be the same bug as the one you encountered on nix.

It showed up immediately after the update though and never again after I reverted it. SAGE_DEBUG wasn't involved, but it probably had something to do with load, core count or something else thats different on a dedicated buildserver.

Replying to @jdemeyer:

Replying to @timokau:

I think immediately going positive_review just because it doesn't reproduce right now is a bad idea.

So what do you suggest instead?

I'll try to see if I can reproduce the error. Not sure when I'll get to it though. There is no hurry for this upgrade right?

videlec commented 5 years ago
comment:42

build works fine but sage -f -c cypari fails

[cypari-2.0.1] Running the test suite for cypari-2.0.1...
[cypari-2.0.1] make[2]: Entering directory '/opt/sage-py3-clang/local/var/tmp/sage/build/cypari-2.0.1/src'
[cypari-2.0.1] python -u tests/rundoctest.py
[cypari-2.0.1] Traceback (most recent call last):
[cypari-2.0.1]   File "tests/rundoctest.py", line 11, in <module>
[cypari-2.0.1]     import cypari2
[cypari-2.0.1]   File "/opt/sage-py3-clang/local/var/tmp/sage/build/cypari-2.0.1/src/cypari2/__init__.py", line 1, in <module>
[cypari-2.0.1]     from .pari_instance import Pari
[cypari-2.0.1] ImportError: No module named pari_instance
[cypari-2.0.1] make[2]: *** [Makefile:16: check] Error 1
jdemeyer commented 5 years ago
comment:43

Replying to @videlec:

build works fine but sage -f -c cypari fails

How did that happen? Is that Sage installation broken somehow? Can you provide the full install log for cypari?

jdemeyer commented 5 years ago
comment:44

I tried again to reproduce the problem and I did manage but only after make distclean. Maybe I did something wrong yesterday...

Anyway, it seems that the problem is 100% reproducible now so I can work on it.

timokau commented 5 years ago
comment:45

Great! Thanks for re-checking. Hopefully the solution will also apply to the (probably related) problem I was seeing.