Bug in parallelization on manifolds

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.47k stars 488 forks source link

Bug in parallelization on manifolds #26777

Closed 309a26b2-e8cb-4cec-ac13-3c5452d05479 closed 6 years ago

309a26b2-e8cb-4cec-ac13-3c5452d05479 commented 6 years ago

During parallelization introduced in #26168, a variable which is passed to the parallel function was not always defined.

CC: @egourgoulhon

Component: calculus

Author: Marco Mancini

Branch/Commit: 123872b

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/26777

309a26b2-e8cb-4cec-ac13-3c5452d05479 commented 6 years ago

Branch: public/manifolds/bug_in_26168

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Commit: 123872b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

123872b resolved BUG

egourgoulhon commented 6 years ago

Reviewer: Eric Gourgoulhon

egourgoulhon commented 6 years ago

comment:4

Tested against http://nbviewer.jupyter.org/github/sagemanifolds/SageManifolds/blob/master/Worksheets/v1.3/SM_sphere_S3_metric.ipynb ==> OK.

Thanks for the fix!

egourgoulhon commented 6 years ago

Description changed:

--- 
+++ 
@@ -1,2 +1,2 @@
-During parallelisation a varaible which is passed to the parallel function was not always defined.
+During parallelization introduced in #26168, a variable which is passed to the parallel function was not always defined.

tscrim commented 6 years ago

comment:5

cough Author name cough

309a26b2-e8cb-4cec-ac13-3c5452d05479 commented 6 years ago

Author: Marco Mancini

vbraun commented 6 years ago

Changed branch from public/manifolds/bug_in_26168 to 123872b