search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 481 forks source link

spkg-configure.m4 for arb #27270

Closed dimpase closed 5 years ago

dimpase commented 5 years ago 
SAGE_SPKG_CONFIGURE([arb], [
    AC_CHECK_HEADER(arb.h, [], [sage_spkg_install_arb=yes])
dnl below function added in version 2.16 of arb 
    AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])

we also take care of non-standard naming of arb's dylib here.

configure tarball http://users.ox.ac.uk/~coml0531/sage/configure-b5de8991395bbf58e663e69d6250de656897c4e2.tar.gz

Upstream: Reported upstream. No feedback yet.

CC: @embray @jdemeyer @tobihan @kiwifb

Component: build

Author: Dima Pasechnik, Isuru Fernando

Branch: 29d4ce2

Reviewer: François Bissey, Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/27270

dimpase commented 5 years ago

Description changed:

--- 
+++ 
@@ -1 +1,7 @@

+```
+SAGE_SPKG_CONFIGURE([arb], [
+    AC_CHECK_HEADER(arb.h, [], [sage_spkg_install_arb=yes])
+dnl below function added in version 2.16 of arb 
+    AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])
+```
dimpase commented 5 years ago

Dependencies: #27264

dimpase commented 5 years ago

Commit: 46b529e

dimpase commented 5 years ago
comment:3

this does not implement --with-arb=..., as I hope it's not needed. And no other packages have --with-arb=, too.

Last 10 new commits:

50aebabimplement --with-mpfr=system/install
0fc433fupdate for Sage 8.7.rc0, a typo fix
38427e1spkg-configure for mpc, adjustments for its dependees
ec32471Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423frebase, deal with --with-mpc
33edfa8Merge branch 'mpf' into flintconf - no spkg-configure yet
82772d7spkg-configure for flint
24f17d5testi for GC enabled
c1ac4f2proper nesting of tests
46b529espkg-configure for arb
dimpase commented 5 years ago

Branch: u/dimpase/packages/arbconfig

dimpase commented 5 years ago
comment:4

Tests pass, apart from this amusing doctest failure:

File "src/sage/misc/package.py", line 282, in sage.misc.package.installed_packages
Failed example:
    installed_packages()
Expected:
    {...'arb': ...'pynac': ...}
Got:
    {'.dummy': '',
     'alabaster': '0.7.12',
     'appnope': '0.1.0.p0',
...

Less amusing is that with arb manually installed to /usr/local on Gentoo Linux, I get a import error upon Sage startup, from deep inside sagelib.

I have to start Sage as LD_LIBRARY_PATH=/usr/local/lib64 ./sage, otherwise I get 

ImportError: libarb.so.2: cannot open shared object file: No such file or directory

I do have /usr/local/lib64 in /etc/ld.so.conf, by the way. Does this mean we need do jump through some linking hoops here?

I certainly can add a proper runtime test in spkg-configure.m4, but why?

dimpase commented 5 years ago
comment:5

Replying to @dimpase:

Less amusing is that with arb manually installed to /usr/local on Gentoo Linux, I get a import error upon Sage startup, from deep inside sagelib.

oops, my fault. Forgot to run ldconfig after the installation. (maybe arb should do it for you, cf. https://github.com/fredrik-johansson/arb/issues/273).

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 46b529e to 961886d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

961886darb can be dummy, don't mention it in packages doctest
dimpase commented 5 years ago

Upstream: Reported upstream. No feedback yet.

dimpase commented 5 years ago
comment:7

upstream report not directly relevant to this ticket, bit OK.

embray commented 5 years ago
comment:8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 961886d to 7a9c768

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7a9c768typo in parameter
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 7a9c768 to 1ed5dbb

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1357befimplement --with-mpfr=system/install
e7d04e7spkg-configure for mpc, adjustments for its dependees
fb3aec7rebase, deal with --with-mpc
30b85f7spkg-configure for flint
e17167etesti for GC enabled
d7f3747proper nesting of tests
88209e0typo in parameter
329b835rebase, deal with --with-mpc
447ab2dspkg-configure for arb
1ed5dbbarb can be dummy, don't mention it in packages doctest
dimpase commented 5 years ago
comment:11

OK, so this branch has mpfr (#27258) mpc (#27259) ntl (#27265) flint (#27264) and, naturally, arb. Would be great to have it all reviewed in one go...

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

c09667dconfigure bump
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 1ed5dbb to c09667d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from c09667d to a247437

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago
comment:13

Attachment: configure-320.tar.gz

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a867838typo
c4e7778rebase, deal with --with-mpc
cd15ac1spkg-configure for arb
07276c8arb can be dummy, don't mention it in packages doctest
a247437configure bump
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

0392e76rebase, deal with --with-mpc
73ce2a9spkg-configure for flint
37fa1a1testi for GC enabled
4f6434cproper nesting of tests
a672706typo in parameter
013dfbetypo
e698ffccorrected rebase
8fc4fb6add dependency checks, remove unneeded `-with` handling
1ad182dSAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
9de7419added dependency check
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from a247437 to 9de7419

dimpase commented 5 years ago
comment:15

rebased over #27264, added dependency check

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 9de7419 to 483233b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d23d9dbadd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
4222018testi for GC enabled
02dd624proper nesting of tests
4fb6a73SAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
483233badded dependency check
dimpase commented 5 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 dnl below function added in version 2.16 of arb 
     AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])

+ +configure tarball https://github.com/sagemath/sage-prod/files/10659249/configure-323.tar.gz

dimpase commented 5 years ago
comment:17

Attachment: configure-323.tar.gz

this is now bundled with flint ticket. New configure tarball attached. I also squashed some commits, and rebased over 8.8.beta7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fc876edconfigure bump
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 483233b to fc876ed

fchapoton commented 5 years ago
comment:19

How come that 8.8.rc0 needs configure-323, which is here, not yet merged ??

EDIT:

And how can this depend on a duplicate/invalid/wontfix ticket ??

dimpase commented 5 years ago
comment:20

version numbers of these tarballs are autogenerated. they are otherwise pretty much meaningless.

it is merely a bug in our release process that is needed to be workedaround, as builbots don’t have autotools and cannot generate the stuff on the fly...

vbraun commented 5 years ago
comment:21

Needs a new confball. I'd suggest to merge this in 8.9.beta0 so hold the horses until 8.8 is out.

You should remove the dependency on tickets that cannot be merged, the release script will wait until the dependencies are merged which, right now, is never.

dimpase commented 5 years ago

Changed dependencies from #27264 to none

dimpase commented 5 years ago
comment:23

the branch here bundles the work done on #27264.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from fc876ed to bd14dd2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

848279cadd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
2bea28btesti for GC enabled
b5ac981proper nesting of tests
f81225aSAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
bd14dd2added dependency check
dimpase commented 5 years ago
comment:25

rebased over 8.8.rc0 (without configure bump, for the time being)

embray commented 5 years ago
comment:26

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

dimpase commented 5 years ago
comment:27

Replying to @vbraun:

Needs a new confball. I'd suggest to merge this in 8.9.beta0 so hold the horses until 8.8 is out.

Would you like to get #27978 first?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d91e84aadd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
f7b77dftesti for GC enabled
22100a4proper nesting of tests
f7826c4SAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
5cd4aacadded dependency check
8d1a647configure bump
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from bd14dd2 to 8d1a647

dimpase commented 5 years ago

Description changed:

--- 
+++ 
@@ -6,4 +6,4 @@
     AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])

-configure tarball https://github.com/sagemath/sage-prod/files/10659249/configure-323.tar.gz +configure tarball http://users.ox.ac.uk/~coml0531/sage/configure-328.tar.gz

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 8d1a647 to 45cb1e4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d0cdca7add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
370e481testi for GC enabled
032620dproper nesting of tests
e6b3d53SAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
13235f9added dependency check
45cb1e4configure version bump
dimpase commented 5 years ago

Description changed:

--- 
+++ 
@@ -6,4 +6,5 @@
     AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])

-configure tarball http://users.ox.ac.uk/~coml0531/sage/configure-328.tar.gz +configure tarball +http://users.ox.ac.uk/~coml0531/sage/configure-13235f9997462c2349a452f2dfb6b2097deb7d56.tar.gz

dimpase commented 5 years ago
comment:31

now rebased over 8.9.beta1, using sha1-based configure tarball

Please test!

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

46f2ba9add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
456ad04testi for GC enabled
52c3ae4proper nesting of tests
37d2d12SAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
1f53bebadded dependency check
32f294bsage should be called with ./ in bootstrap
c758851Debian names the arb library differently
54d45bamention flint and arb (and one more forgotten package) for debian
605260cconfigure version bump
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 45cb1e4 to 605260c

dimpase commented 5 years ago
comment:33

rebased, config bump, added another name for the arb library (in Debian), mention it and flint in docs