Update FriCAS to 1.3.6 - Githubissues

mantepse commented 5 years ago

This ticket is to upgrade to FriCAS 1.3.6 and track dependencies.

Tarball: see checksums.ini

Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub, but the homepage remains at Sourceforge:

https://fricas.sourceforge.net

and we still get source tarballs from Sourceforge since those available at GitHub are not the full source archives we need.

Our last update was to Fricas 1.3.5 in #25962 in February 2019.

To try this ticket from your Sage root directory, with git-trac-command installed:

git trac try 27309
SAGE_SPKG="sage-spkg -o" ./sage -i fricas (or use ./configure --enable-download-from-upstream-url first)
./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py

CC: @slel

Component: packages: optional

Keywords: FriCAS, upgrade

Author: Frédéric Chapoton

Branch: b811a1d

Reviewer: Matthias Koeppe, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/27309

embray commented 5 years ago

comment:1

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

embray commented 5 years ago

comment:2

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

slel commented 4 years ago

comment:3

Fricas 1.3.6 was released. Release announcement:

https://groups.google.com/d/topic/fricas-devel/nU1HDg9Q_4s/discussion

slel commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,9 +1,27 @@
-This ticket is to track dependencies of FriCAS 1.3.6, which is not released as of today. To track the release, check
+This ticket is to upgrade to FriCAS 1.3.6 and track dependencies.
+
+Tarball:
+
+- https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download
+
+FriCAS releases appear at:

 - http://fricas.sourceforge.net/
 - https://github.com/fricas/fricas/releases

+Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub.
+
+The svn repository at 
+
 Our last update was to Fricas 1.3.5 in #25962 in February 2019.

-Instructions to try this ticket, once 1.3.6 is released, can be found at #25962.
+To try this ticket, change to your `SAGE_ROOT` directory and do:

+1. `git trac try 27309`
+2. `cd upstream`
+3. `wget -O fricas-1.3.6-full.tar.bz2 https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download
+4. `cd ..`
+4. `./sage -i fricas`
+5. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`
+
+

mantepse commented 4 years ago

comment:4

In case you have time, could you check whether #27310 works?

fchapoton commented 4 years ago

Description changed:

--- 
+++ 
@@ -2,7 +2,7 @@

 Tarball:

-- https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download
+- https://github.com/fricas/fricas/archive/1.3.6.tar.gz

 FriCAS releases appear at:

@@ -19,7 +19,7 @@

 1. `git trac try 27309`
 2. `cd upstream`
-3. `wget -O fricas-1.3.6-full.tar.bz2 https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download
+3. `wget -O fricas-1.3.6-full.tar.bz2 https://github.com/fricas/fricas/archive/1.3.6.tar.gz
 4. `cd ..`
 4. `./sage -i fricas`
 5. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

fchapoton commented 4 years ago

Commit: 29d0e02

fchapoton commented 4 years ago

New commits:

29d0e02 update fricas to 1.3.6

fchapoton commented 4 years ago

Branch: u/chapoton/27309

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 29d0e02 to 086cbf0

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

086cbf0 fix fricas doctest

fchapoton commented 4 years ago

comment:9

Passes all doctests. This seems to be good to go.

slel commented 4 years ago

Description changed:

--- 
+++ 
@@ -4,14 +4,16 @@

 - https://github.com/fricas/fricas/archive/1.3.6.tar.gz

-FriCAS releases appear at:
+FriCAS releases appear both at Sourceforge and at !Github:

 - http://fricas.sourceforge.net/
 - https://github.com/fricas/fricas/releases

 Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub.

-The svn repository at 
+The homepage remains at Sourceforge:
+
+- https://fricas.sourceforge.net

 Our last update was to Fricas 1.3.5 in #25962 in February 2019.

@@ -19,9 +21,8 @@

 1. `git trac try 27309`
 2. `cd upstream`
-3. `wget -O fricas-1.3.6-full.tar.bz2 https://github.com/fricas/fricas/archive/1.3.6.tar.gz
+3. `wget -O fricas-1.3.6-full.tar.bz2 https://github.com/fricas/fricas/archive/1.3.6.tar.gz`
 4. `cd ..`
 4. `./sage -i fricas`
 5. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

-

slel commented 4 years ago

Description changed:

--- 
+++ 
@@ -17,12 +17,12 @@

 Our last update was to Fricas 1.3.5 in #25962 in February 2019.

-To try this ticket, change to your `SAGE_ROOT` directory and do:
+To try this ticket from your Sage root directory, with `git-trac-command` installed:

 1. `git trac try 27309`
-2. `cd upstream`
-3. `wget -O fricas-1.3.6-full.tar.bz2 https://github.com/fricas/fricas/archive/1.3.6.tar.gz`
-4. `cd ..`
+2. `VER=1.3.6`
+3. `URL=https://github.com/fricas/fricas/archive/$VER.tar.gz`
+4. `wget -O upstream/fricas-$VER.tar.gz $URL`
 4. `./sage -i fricas`
 5. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

slel commented 4 years ago

comment:11

In build/pkgs/fricas/checksums.ini maybe change:

-tarball=fricas-VERSION-full.tar.bz2
+tarball=fricas-VERSION.tar.gz

fchapoton commented 4 years ago

comment:12

why ?

mkoeppe commented 4 years ago

comment:13

I see:

upstream_url=https://github.com/fricas/fricas/archive/VERSION.tar.gz

I don't think this the URL of a release tarball. This is just the automatic git archive corresponding to the tag. Upstream seems to continue using sourceforge for distributing release tarballs.

slel commented 4 years ago

comment:15

In that case do we need in checksums.ini the following (with updated checksums):

tarball=fricas-VERSION-full.tar.bz2
...
upstream_url=https://sourceforge.net/projects/fricas/files/fricas/VERSION/fricas-VERSION-full.tar.bz2/download

Or are these Sourceforge download urls problematic?

slel commented 4 years ago

Description changed:

--- 
+++ 
@@ -2,18 +2,16 @@

 Tarball:

-- https://github.com/fricas/fricas/archive/1.3.6.tar.gz
+- https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download

-FriCAS releases appear both at Sourceforge and at !Github:
+Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub, but the homepage remains at Sourceforge:
+
+- https://fricas.sourceforge.net
+
+and we still get source tarballs from Sourceforge since those available at GitHub are not the full source archives we need.

 - http://fricas.sourceforge.net/
 - https://github.com/fricas/fricas/releases
-
-Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub.
-
-The homepage remains at Sourceforge:
-
-- https://fricas.sourceforge.net

 Our last update was to Fricas 1.3.5 in #25962 in February 2019.

@@ -21,8 +19,8 @@

 1. `git trac try 27309`
 2. `VER=1.3.6`
-3. `URL=https://github.com/fricas/fricas/archive/$VER.tar.gz`
-4. `wget -O upstream/fricas-$VER.tar.gz $URL`
-4. `./sage -i fricas`
-5. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`
+3. `URL=https://sourceforge.net/projects/fricas/files/fricas/VERSION/fricas-VERSION-full.tar.bz2/download`
+4. `wget -O upstream/fricas-$VER-full.tar.bz2 $URL`
+5. `./sage -i fricas`
+6. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

slel commented 4 years ago

comment:17

Ideally, rebase on Sage 9.2.beta9.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 086cbf0 to b811a1d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b811a1d update fricas to 1.3.6

fchapoton commented 4 years ago

comment:19

better like that ?

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,6 @@
 This ticket is to upgrade to FriCAS 1.3.6 and track dependencies.

-Tarball:
-
-- https://sourceforge.net/projects/fricas/files/fricas/1.3.6/fricas-1.3.6-full.tar.bz2/download
+Tarball: see checksums.ini

 Note that FriCAS has switched to using Git and the primary repository is now the one at GitHub, but the homepage remains at Sourceforge:

@@ -18,9 +16,6 @@
 To try this ticket from your Sage root directory, with `git-trac-command` installed:

 1. `git trac try 27309`
-2. `VER=1.3.6`
-3. `URL=https://sourceforge.net/projects/fricas/files/fricas/VERSION/fricas-VERSION-full.tar.bz2/download`
-4. `wget -O upstream/fricas-$VER-full.tar.bz2 $URL`
-5. `./sage -i fricas`
-6. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`
+2. `SAGE_SPKG="sage-spkg -o" ./sage -i fricas`
+3. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -16,6 +16,6 @@
 To try this ticket from your Sage root directory, with `git-trac-command` installed:

 1. `git trac try 27309`
-2. `SAGE_SPKG="sage-spkg -o" ./sage -i fricas`
+2. `SAGE_SPKG="sage-spkg -o" ./sage -i fricas` (or use `./configure --enable-download-from-upstream-url` first)
 3. `./sage -t --optional=fricas,sage src/sage/interfaces/fricas.py`

mkoeppe commented 4 years ago

Changed author from Martin Rubey to Frédéric Chapoton

mkoeppe commented 4 years ago

Reviewer: Matthias Koeppe

mkoeppe commented 4 years ago

comment:23

Works for me on macOS.

slel commented 4 years ago

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Samuel Lelièvre

slel commented 4 years ago

comment:24

Success on Debian too:

$ ./sage -i fricas && ./sage -t --optional=fricas,build,dochtml,sage --all
All tests passed!

vbraun commented 4 years ago

Changed branch from u/chapoton/27309 to b811a1d

fchapoton commented 4 years ago

Changed commit from b811a1d to none

fchapoton commented 4 years ago

comment:26

I now have problems with "sage -i fricas", which does not seem to be able to find the tarball in the mirrors..

sagemath / sage

Update FriCAS to 1.3.6 #27309