subs of multi-variate polynomial ring with no variables: fix parent

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.45k stars 481 forks source link

Closed dkrenn closed 5 years ago

dkrenn commented 5 years ago

We want

+            sage: P = PolynomialRing(QQ, 't', 0)
+            sage: a = P(1)
+            sage: a(()).parent()

returning QQ and not P.

Component: commutative algebra

Author: Daniel Krenn

Branch/Commit: 14d81bb

Reviewer: Travis Scrimshaw

dkrenn commented 5 years ago

dkrenn commented 5 years ago

New commits:

14d81bb Trac #27446: fix parent of subs of multi-variate polynomial ring with no variables

dkrenn commented 5 years ago

Commit: 14d81bb

embray commented 5 years ago

comment:3

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

tscrim commented 5 years ago

Reviewer: Travis Scrimshaw

tscrim commented 5 years ago

comment:4

This would be consistent with other substitutions (e.g., setting all variables equal to 0) and seems like the more natural result. So LGTM.

vbraun commented 5 years ago