search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.48k stars 488 forks source link

Upgrade: lrslib 071b and polymake 4.4, deprecate PolymakeExpect #27745

Closed mkoeppe closed 3 years ago

mkoeppe commented 5 years ago

lrslib is now at 071b.

polymake 4.4 tarball: https://polymake.org/lib/exe/fetch.php/download/polymake-4.4-minimal.tar.bz2

Polymake 4.4 was released 2021-05-18, we are several releases behind:

For updated instructions regarding the Perl prerequisites, see #31830. Let's keep that a separate ticket.

CC: @slel @yuan-zhou @kliem @videlec @kiwifb @dimpase @simon-king-jena

Component: packages: optional

Keywords: upgrade, lrslib

Author: Matthias Koeppe, Jonathan Kliem, Travis Scrimshaw

Branch/Commit: ff69f28

Reviewer: Thierry Monteil, Matthias Koeppe, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27745

mkoeppe commented 5 years ago

Description changed:

--- 
+++ 
@@ -1 +1,5 @@
+http://cgm.cs.mcgill.ca/~avis/C/lrs.html

+http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-070.tar.gz
+
+Sage package built from https://github.com/mkoeppe/lrslib (not updated yet).
embray commented 5 years ago
comment:2

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

mkoeppe commented 4 years ago
comment:3

Moving some tickets to 9.2. This is not a promise that I will be working on them.

slel commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 http://cgm.cs.mcgill.ca/~avis/C/lrs.html

-http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-070.tar.gz
+http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-071.tar.gz

 Sage package built from https://github.com/mkoeppe/lrslib (not updated yet).
slel commented 4 years ago

Changed keywords from none to upgrade, lrslib

mkoeppe commented 3 years ago
comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -1,5 +1,6 @@
 http://cgm.cs.mcgill.ca/~avis/C/lrs.html

-http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-071.tar.gz
+http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-071a.tar.gz

 Sage package built from https://github.com/mkoeppe/lrslib (not updated yet).
+
mkoeppe commented 3 years ago

Branch: u/mkoeppe/upgrade__lrslib_071a

mkoeppe commented 3 years ago

Commit: 6f34801

mkoeppe commented 3 years ago

Author: Matthias Koeppe

mkoeppe commented 3 years ago

New commits:

6f34801build/pkgs/lrslib: Update lrslib to 071a+autotools-2021-05-17
mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -4,3 +4,5 @@

 Sage package built from https://github.com/mkoeppe/lrslib (not updated yet).

+To test:
+`make configure && eval ./configure $(./config.status --config) --enable-download-from-upstream-url && make lrslib`
mkoeppe commented 3 years ago
comment:11

Various failures in ./sage -tp src/sage/game_theory/, needs work

mkoeppe commented 3 years ago
comment:12

Does anyone already have patches to support lrslib 071a in the Sage library?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a6ba760build/pkgs/lrslib/spkg-install.in: Remove LRS_QUIET - in 071a, it makes the output unusable
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 6f34801 to a6ba760

mkoeppe commented 3 years ago
comment:14

This is better, but the rather shocking lrs format parser in src/sage/game_theory/parser.py will need fixing

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from a6ba760 to d1bbfe4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

d1bbfe4src/sage/features/lrs.py: Accept output from lrslib 071a
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from d1bbfe4 to 5d256d5

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

5d256d5src/sage/game_theory/parser.py: Make the parser accept lrslib-072a output
mkoeppe commented 3 years ago

Dependencies: #28435

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

d09bb90build/pkgs/polymake: Update to 4.3
70c112dbuild/pkgs/polymake/patches/: Remove
6a15c98Merge #28435
5161de9build/pkgs/lrslib: Use lrslib-071a+autotools-2021-05-17a
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 5d256d5 to 5161de9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

29a2e12build/pkgs/lrslib: Use lrslib-071a+autotools-2021-05-17b
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 5161de9 to 29a2e12

dimpase commented 3 years ago
comment:21

Should #28435 be dependent on this ticket, not the other way around?

dimpase commented 3 years ago

Changed dependencies from #28435 to none

mkoeppe commented 3 years ago

Dependencies: #28435

mkoeppe commented 3 years ago

Changed dependencies from #28435 to none

mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,17 @@
-http://cgm.cs.mcgill.ca/~avis/C/lrs.html
+lrslib is now at 071a.

-http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-071a.tar.gz
+- http://cgm.cs.mcgill.ca/~avis/C/lrs.html
+- http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/
+- Sage package built from https://github.com/mkoeppe/lrslib
+- To test:
+`make configure && eval ./configure $(./config.status --config) --enable-download-from-upstream-url && make lrslib`

-Sage package built from https://github.com/mkoeppe/lrslib (not updated yet).
+Polymake 4.3 was released Dec 2020, we are several releases behind:
+- https://polymake.org/doku.php/news/release_4_3
+- https://polymake.org/doku.php/news/release_4_2
+- https://polymake.org/doku.php/news/release_4_1
+- https://polymake.org/doku.php/news/release_4_0
+- https://polymake.org/doku.php/news/release_3_6
+- https://polymake.org/doku.php/news/release_3_5, 

-To test:
-`make configure && eval ./configure $(./config.status --config) --enable-download-from-upstream-url && make lrslib`
+For updated instructions regarding the Perl prerequisites, see #31830. Let's keep that a separate ticket.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

bc66490build/pkgs/libxml2/spkg-install: Make it executable
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 29a2e12 to bc66490

antonio-rojas commented 3 years ago
comment:28

FYI polymake 4.4 was just released

dimpase commented 3 years ago
comment:29

should we do a bump to 4.4 here now?

mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -6,7 +6,8 @@
 - To test:
 `make configure && eval ./configure $(./config.status --config) --enable-download-from-upstream-url && make lrslib`

-Polymake 4.3 was released Dec 2020, we are several releases behind:
+Polymake 4.4 was released 2021-05-18, we are several releases behind:
+- https://polymake.org/doku.php/news/release_4_4
 - https://polymake.org/doku.php/news/release_4_3
 - https://polymake.org/doku.php/news/release_4_2
 - https://polymake.org/doku.php/news/release_4_1
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from bc66490 to 3456c2c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3456c2cbuild/pkgs/polymake: Update to 4.4
mkoeppe commented 3 years ago
comment:34

tested on macOS Catalina only

edd8e884-f507-429a-b577-5d554626c0fe commented 3 years ago
comment:35

lrslib does not compile on my Debian buster x86_64, see the attached log.

edd8e884-f507-429a-b577-5d554626c0fe commented 3 years ago

Reviewer: Thierry Monteil

edd8e884-f507-429a-b577-5d554626c0fe commented 3 years ago

Attachment: lrslib-071a+autotools-2021-05-17b.log

dimpase commented 3 years ago
comment:36

it build for me on Fedora. Something is not right with openmpi in your log.

mkoeppe commented 3 years ago
comment:37

I haven't tested at all with openmpi yet -- PRs are welcome

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

720c624build/pkgs/lrslib: Use 071a+autotools-2021-05-18
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 3456c2c to 720c624

mkoeppe commented 3 years ago
comment:39

OK, mpi is fixed now

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3504a7dbuild/pkgs/polymake/spkg-install.in: Pass number of threads to ninja
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 720c624 to 3504a7d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

06284e9Fixup