sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 481 forks source link

get k-regular sequence from certain recurrence relations #27940

Closed galipnik closed 3 years ago

galipnik commented 5 years ago

Code for constructing the linear representation of k-regular sequences given by certain recurrence relations.

See also Meta ticket #21202.

Depends on #21295 Depends on #21203

CC: @dkrenn

Component: combinatorics

Author: Gabriel F. Lipnik, Daniel Krenn

Branch/Commit: 488123c

Reviewer: Clemens Heuberger, Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/27940

galipnik commented 3 years ago
comment:66

Replying to @cheuberg:

@galipnik: could you please also have a look on dkrenn's changes?

Done, the changes are fine for me. Thank you!

galipnik commented 3 years ago

Changed branch from u/dkrenn/k-regular-recurions-rebased to u/galipnik/k-regular-recurions-rebased

galipnik commented 3 years ago

Changed commit from 6db5f58 to 288995e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

6ff29baTrac #27940: fix doctests (use RecurrenceParser)
22cb3f0Trac #27940: remove underscores from helper methods
293905aTrac #27940: remove "_from_recurrence" from method names
75fe130Trac #27940: remove "get_" from method names
952d724Trac #27940: consistently use coefficient_ring
fbf3a81Trac #27940: adapt/complete docstrings
16de2abTrac #27940: unify input parameters
86c5df7Trac #27940: fix indention (due to renamings)
6db5f58Trac #27940 review 67: change signature of output of RecurrenceParser.__call__
488123cTrac #27940: remove redundant line
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 288995e to 488123c

galipnik commented 3 years ago
comment:69

Sorry for the late change, but I incidentally found a redundant line of code and removed it in the last commit 488123c. I've restarted the patchbot.

cheuberg commented 3 years ago
comment:70

488123c is fine. Patchbot is happy. Time to set it to positive.

vbraun commented 3 years ago

Changed branch from u/galipnik/k-regular-recurions-rebased to 488123c