Fixing bug in ClusterSeed involving coefficients

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.4k stars 474 forks source link

Fixing bug in ClusterSeed involving coefficients #28264

Open a9a57cdf-9183-46c4-a1f6-41c1b5271dce opened 5 years ago

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

EARLIER: Bug found in S.interact() or Q.interact() for ClusterSeed or ClusterQuiver. (This appears to be an issue with interact() in CoCalc as opposed to in our code.)

NEW Description: In process of debugging handling of coefficients and frozen variables in cluster seed.

CC: @egunawan

Component: combinatorics

Keywords: cluster

Branch/Commit: u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed @ 5274b5f

Issue created by migration from https://trac.sagemath.org/ticket/28264

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

comment:1

Current code (in a Jupyter notebbok) mutates at last clicked value as opposed to the current clicked value, and always mutates at 0 first.

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

Branch: u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

Changed branch from u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed to none

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-Bug found in S.interact() or Q.interact() for ClusterSeed or ClusterQuiver.
+EARLIER: Bug found in S.interact() or Q.interact() for ClusterSeed or ClusterQuiver. (This appears to be an issue with interact() in CoCalc as opposed to in our code.)
+
+NEW Description: In process of debugging handling of coefficients and frozen variables in cluster seed.

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

comment:3

First step: ensure that any cluster seed comes with a "user_label", even if it needs to be automatically populated to be [0,1,2,...n-1].

Later: this attribute name will be renamed to make it clear it is not only user_label.

a9a57cdf-9183-46c4-a1f6-41c1b5271dce commented 5 years ago

Branch: u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed

fchapoton commented 5 years ago

Commit: 5274b5f

fchapoton commented 5 years ago

comment:5

Please add a doctest for what it fixes.

New commits:

`5f3d830`	`Trying To Debug principal_extension`
`5274b5f`	`Changed code so that user_labels are always assigned, even if it is [0,1,2,...,n-1]`

fchapoton commented 5 years ago

Changed keywords from none to cluster

embray commented 4 years ago

comment:7

Ticket retargeted after milestone closed

mkoeppe commented 4 years ago

comment:8

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

mkoeppe commented 3 years ago

comment:10

Moving to 9.4, as 9.3 has been released.