search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.4k stars 473 forks source link

py3: final polishing of the last failing doctests #28298

Closed fchapoton closed 4 years ago

fchapoton commented 5 years ago

After #26212, there remains only a few failing doctests (not using any optional package).

Fixed:

Those that are not yet handled are the following.

On several machines:

but not on these machines: macOS mojave (several different machines)

OS X only:

Table summary:
Issue ref. patchbot ubuntu, debian OS X
(F) fail ?
(K) fail (intermittent)
(L) fail (intermittent)

CC: @vinklein @embray @jm58660 @timokau @jhpalmieri @dcoudert @Etn40ff @antonio-rojas

Component: python3

Issue created by migration from https://trac.sagemath.org/ticket/28298

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -32,9 +32,9 @@

 Table summary:

-|       |               |                |              |
-|-------|---------------|----------------|--------------|
-| Issue | ref. patchbot | ubuntu, debian | OS X, CentOS |
+|       |               |                |      |
+|-------|---------------|----------------|------|
+| Issue | ref. patchbot | ubuntu, debian | OS X |
 |  (E)  |          | fail   |      |
 |  (F)  |   fail ?       |        |      |
 |  (G)  |          | fail   |      |
jhpalmieri commented 5 years ago
comment:48

Regarding (H), (I), (J): I don't see them ordinarily on OS X, even when running make ptestlong, but I do see them on my OS X patchbot. Is there something different about patchbots which could lead to these failures?

jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -29,6 +29,7 @@
 OS X only:

 - (K) 2 in src/sage/symbolic/expression.py #28489
+- (L) 1 in src/sage/numerical/linear_tensor_element.pyx #28559

 Table summary:

@@ -42,4 +43,5 @@
 |  (I)  |   fail   | fail (ptestlong only) |      |
 |  (J)  |   fail   | fail (ptestlong only) |      |
 |  (K)  |          |                       | fail (intermittent) |
+|  (L)  |          |                       | fail (intermittent) |
fchapoton commented 5 years ago

Description changed:

--- 
+++ 
@@ -9,12 +9,12 @@
 - (C) 1 in src/sage/symbolic/expression.pyx #28219 #28412
 - (K) 2 in src/sage/crypto/block_cipher/present.py #28403
 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
+- (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472

 Those that are not yet handled are the following.

 *On several machines*:

-- (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472
 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py (not seen since some time. random ? could be ignored ?)
 - (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334

@@ -36,7 +36,6 @@
 |       |               |                |      |
 |-------|---------------|----------------|------|
 | Issue | ref. patchbot | ubuntu, debian | OS X |
-|  (E)  |          | fail   |      |
 |  (F)  |   fail ?       |        |      |
 |  (G)  |          | fail   |      |
 |  (H)  |   fail   | fail (ptestlong only) |      |
jhpalmieri commented 5 years ago

Description changed:

--- 
+++ 
@@ -22,9 +22,9 @@

 *On the reference patchbot machine (named atlas, running Ubuntu 16.04.6) and on Ubuntu 18.04 with `make ptestlong`*:

-- (H) 1 in src/sage/libs/singular/function.pyx
-- (I) 2 in src/sage/numerical/backends/generic_backend.pyx
-- (J) 4 in src/sage/repl/attach.py
+- (H) 1 in src/sage/libs/singular/function.pyx #28622
+- (I) 2 in src/sage/numerical/backends/generic_backend.pyx #28622
+- (J) 4 in src/sage/repl/attach.py #28622

 OS X only:
jhpalmieri commented 5 years ago
comment:51

Replying to @jhpalmieri:

Regarding (H), (I), (J): I don't see them ordinarily on OS X, even when running make ptestlong, but I do see them on my OS X patchbot. Is there something different about patchbots which could lead to these failures?

I really think this is the case. I've opened #28622 for this, not that I have any ideas how to fix it.

jhpalmieri commented 5 years ago
comment:52

These failures seem to also occur outside of the patchbot, but they are very repeatable when using the patchbot, as described at #28622, so I hope if we can fix the patchbot problems, it will either fix them outside of the patchbot or at least give us some clues.

jhpalmieri commented 4 years ago
comment:53

I still don't know if anyone else has seen (K) or (L). (F) maybe hasn't been seen for a long time. Things are looking good!

timokau commented 4 years ago
comment:54

If all remaining failures are transient, maybe its time to switch the betas over to py3 and do some more extensive testing?

mwageringel commented 4 years ago
comment:55

Replying to @jhpalmieri:

I still don't know if anyone else has seen (K) or (L).

I can reproduce (K) on macOS reliably, but have not seen (L).

jhpalmieri commented 4 years ago

Description changed:

--- 
+++ 
@@ -16,7 +16,7 @@
 *On several machines*:

 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py (not seen since some time. random ? could be ignored ?)
-- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334
+- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334 #28649

 but not on these machines: macOS mojave (several different machines)
fchapoton commented 4 years ago

Description changed:

--- 
+++ 
@@ -10,21 +10,18 @@
 - (K) 2 in src/sage/crypto/block_cipher/present.py #28403
 - (B) 7 in src/sage/combinat/root_system/weyl_group.py #27967 #28351
 - (E) 1 at line 597 in src/sage/libs/eclib/interface.py #28454 #28472
+- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334 #28649
+- (H) 1 in src/sage/libs/singular/function.pyx #28622
+- (I) 2 in src/sage/numerical/backends/generic_backend.pyx #28622
+- (J) 4 in src/sage/repl/attach.py #28622

 Those that are not yet handled are the following.

 *On several machines*:

 - (F) 1 in src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py (not seen since some time. random ? could be ignored ?)
-- (G) src/sage/rings/polynomial/polynomial_rational_flint.pyx #28334 #28649

 but not on these machines: macOS mojave (several different machines)
-
-*On the reference patchbot machine (named atlas, running Ubuntu 16.04.6) and on Ubuntu 18.04 with `make ptestlong`*:
-
-- (H) 1 in src/sage/libs/singular/function.pyx #28622
-- (I) 2 in src/sage/numerical/backends/generic_backend.pyx #28622
-- (J) 4 in src/sage/repl/attach.py #28622

 OS X only:

@@ -37,10 +34,6 @@
 |-------|---------------|----------------|------|
 | Issue | ref. patchbot | ubuntu, debian | OS X |
 |  (F)  |   fail ?       |        |      |
-|  (G)  |          | fail   |      |
-|  (H)  |   fail   | fail (ptestlong only) |      |
-|  (I)  |   fail   | fail (ptestlong only) |      |
-|  (J)  |   fail   | fail (ptestlong only) |      |
 |  (K)  |          |                       | fail (intermittent) |
 |  (L)  |          |                       | fail (intermittent) |
jhpalmieri commented 4 years ago
comment:58

I haven't seen (L) in a while. I haven't heard any other reports of it, either. So I would put a very low priority on it.

kwankyu commented 4 years ago
comment:59

I propose to clear up (F), (K), and (L) here. They are all intermittent failures with obscure causes, and do not seem likely to get any solution in the near future, and just blocking sage on python 3. They can change to regular tickets. Any one object?

fchapoton commented 4 years ago
comment:60

These are not blocking anything. The switch to python3 is happening.

embray commented 4 years ago
comment:61

Ticket retargeted after milestone closed