search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 462 forks source link

Metaticket - improvements to the Macaulay2 interface #28573

Open saliola opened 5 years ago

saliola commented 5 years ago

"There are too many changes going on at once, so that a merge in the end might be difficult. In order to avoid such difficulties and to keep an overview of things that are happening (for me and others), I use this ticket from now on as a metaticket, where all latest changes are merged together." (copied from #28519).

Tickets:

CC: @saliola @dimpase @antonleykin

Component: interfaces: optional

Keywords: macaulay2, IMA Coding Sprint

Branch/Commit: public/interfaces/m2/28573 @ 1368231

Issue created by migration from https://trac.sagemath.org/ticket/28573

saliola commented 5 years ago

Description changed:

--- 
+++ 
@@ -8,4 +8,4 @@
 - #28567: allow user to specify strategy for Groebner basis computations with Macaulay2
 - #28568: implement _install_hints method for the Macaulay2 interface
 - #28571: pass 'macaulay2' as argument to '_macaulay2_init_()'
-- #28572: conversion of quotient rings to macaulay2
+- #28572: conversion of quotient rings to macaulay2 [Dependencies: #28571, #28074]
saliola commented 5 years ago

Description changed:

--- 
+++ 
@@ -8,4 +8,4 @@
 - #28567: allow user to specify strategy for Groebner basis computations with Macaulay2
 - #28568: implement _install_hints method for the Macaulay2 interface
 - #28571: pass 'macaulay2' as argument to '_macaulay2_init_()'
-- #28572: conversion of quotient rings to macaulay2 [Dependencies: #28571, #28074]
+- #28572: conversion of quotient rings to macaulay2 (Dependencies: #28571, #28074)
saliola commented 5 years ago

Description changed:

--- 
+++ 
@@ -7,5 +7,5 @@
 - #28566: improve conversions between Macaulay2 and Sage
 - #28567: allow user to specify strategy for Groebner basis computations with Macaulay2
 - #28568: implement _install_hints method for the Macaulay2 interface
-- #28571: pass 'macaulay2' as argument to '_macaulay2_init_()'
+- #28571: pass 'macaulay2' as argument to '_macaulay2_init_()' (Dependencies: #28074)
 - #28572: conversion of quotient rings to macaulay2 (Dependencies: #28571, #28074)
saliola commented 5 years ago

Commit: db63b5f

saliola commented 5 years ago
comment:4

I created a branch that merges all the tickets together to see if there was any merge conflict. There was one, but it was easy to resolve.

Last 10 new commits:

1a873f7Merge remote-tracking branch 'origin/public/interfaces/m2/macaulay2_init' into m2_quotient_rings
6e734c6conversion of quotient rings to macaulay2 & improvements to conversion of ideals
6a537c828572: fix conversion of quotient rings from Macaulay2 to Sage
5ddbe5cmark m2 doctests as optional
4b256a1add _macaulay2_init_ method to QuotientRingElement
d1566e5correct inaccuracy in doctest description
bd06a80properly handle conversion of quotient ring elements & inherit variable names when converting from M2 quotient rings
ec1773edisable caching of M2 conversion of polynomials in quotient rings (change _macaulay2_init_ to _macaulay2_)
25afa2fsimplify doctest
db63b5fMerge remote-tracking branch 'origin/public/interfaces/m2/m2_quotient_rings' into m2-metaticket
saliola commented 5 years ago

Branch: public/interfaces/m2/28573

saliola commented 5 years ago

Description changed:

--- 
+++ 
@@ -9,3 +9,4 @@
 - #28568: implement _install_hints method for the Macaulay2 interface
 - #28571: pass 'macaulay2' as argument to '_macaulay2_init_()' (Dependencies: #28074)
 - #28572: conversion of quotient rings to macaulay2 (Dependencies: #28571, #28074)
+- #28574: conversion of nested polynomial rings to Macaulay2 (Dependencies: #28571, #28074)
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

af595de28574: construct Macaulay2 polynomial rings over arbitrary base rings
e85472028574: fix conversion of polynomials to M2
49d5c0b28574: convert elements of nested polynomial rings from M2 to sage
35d4205Merge remote-tracking branch 'trac/u/gh-mwageringel/28574' into m2-metaticket
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from db63b5f to 35d4205

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Changed commit from 35d4205 to d870598

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 5 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

00c028f28567: add missing optional doctest flag
1ab09eaMerge commit '00c028f94219dd8f5fbc68f566027ae1e80' into m2-metaticket
19d999528572: remove unnecessary doctests
d870598Merge commit '19d9995883416aa73f370904c8cc2' into m2-metaticket
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from d870598 to 1368231

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

15d35e3Merge remote-tracking branch 'origin/public/interfaces/m2/f4etc' into public/interfaces/m2/m2_quotient_rings
14dadd0Merge remote-tracking branch 'origin/public/interfaces/m2/m2_quotient_rings' into m2-metaticket
af595de28574: construct Macaulay2 polynomial rings over arbitrary base rings
e85472028574: fix conversion of polynomials to M2
49d5c0b28574: convert elements of nested polynomial rings from M2 to sage
23b2bf4add "optional - macaulay2" flag to doctests
0c1e001Merge remote-tracking branch 'origin/public/interfaces/m2/28566' into public/interfaces/m2/28574
72abe24finish merging
a312b15Merge branch 'public/interfaces/m2/m2_quotient_rings' into public/interfaces/m2/28574
1368231Merge remote-tracking branch 'origin/public/interfaces/m2/28574' into m2-metaticket
saliola commented 4 years ago

Description changed:

--- 
+++ 
@@ -8,5 +8,5 @@
 - #28567: allow user to specify strategy for Groebner basis computations with Macaulay2
 - #28568: implement _install_hints method for the Macaulay2 interface
 - #28571: pass 'macaulay2' as argument to '_macaulay2_init_()' (Dependencies: #28074)
-- #28572: conversion of quotient rings to macaulay2 (Dependencies: #28571, #28074)
-- #28574: conversion of nested polynomial rings to Macaulay2 (Dependencies: #28571, #28074)
+- #28572: conversion of quotient rings to macaulay2 (Dependencies: #28567, #28571, #28074)
+- #28574: conversion of nested polynomial rings to Macaulay2 (Dependencies: #28566, #28571, #28572, #28074)
saliola commented 4 years ago
comment:10

The current branch merges all the tickets in the following order:

and everything merges cleanly.

mwageringel commented 4 years ago

Description changed:

--- 
+++ 
@@ -10,3 +10,4 @@
 - #28571: pass 'macaulay2' as argument to '_macaulay2_init_()' (Dependencies: #28074)
 - #28572: conversion of quotient rings to macaulay2 (Dependencies: #28567, #28571, #28074)
 - #28574: conversion of nested polynomial rings to Macaulay2 (Dependencies: #28566, #28571, #28572, #28074)
+- #28591: convert chain complexes from Macaulay2 to Sage (Dependencies: #28566)
embray commented 4 years ago
comment:12

Ticket retargeted after milestone closed

mkoeppe commented 4 years ago
comment:13

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

mkoeppe commented 3 years ago
comment:15

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.