search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.42k stars 478 forks source link

MR38: Fix documentation of spkg-configure.m4 and make output more verbose #28788

Closed f588ca1e-f96a-4dea-804d-c55eab873dab closed 4 years ago

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

This now produces the following output:

...
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG yasm...
checking for yasm supporting the adox instruction... /usr/local/bin/yasm
configure: will use system package and not install SPKG yasm
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG zeromq...
configure: zeromq has already been installed by SageMath
## ----------------------------------------------------------------------- ##
## Build status for each package:                                          ##
## ----------------------------------------------------------------------- ##
4ti2-1.6.7.p0:                               does not support check for system package; optional, use "./configure --enable-4ti2" to install
alabaster-0.7.12:                            does not support check for system package; will be installed as an SPKG
appnope-0.1.0.p0:                            does not support check for system package; will be installed as an SPKG
arb-2.16.0.p0:                               no suitable system package; will be installed as an SPKG
atlas-3.10.2.p3:                             not required on your platform; SPKG will not be installed
autotools-20141105.p0:                       does not support check for system package; experimental, use "./configure --enable-autotools" to install
awali-1.0.2-190218:                          does not support check for system package; experimental, use "./configure --enable-awali" to install
babel-2.6.0:                                 does not support check for system package; will be installed as an SPKG
backports_abc-0.5:                           does not support check for system package; will be installed as an SPKG
backports_functools_lru_cache-1.5:           does not support check for system package; will be installed as an SPKG
backports_shutil_get_terminal_size-1.0.0.p1: does not support check for system package; will be installed as an SPKG
backports_ssl_match_hostname-3.5.0.1.p0:     does not support check for system package; will be installed as an SPKG
barvinok-0.41.1:                             does not support check for system package; optional, use "./configure --enable-barvinok" to install
benzene-20130630:                            does not support check for system package; optional, use "./configure --enable-benzene" to install
bleach-3.1.0:                                does not support check for system package; will be installed as an SPKG
bliss-0.73+debian-1+sage-2016-08-02.p0:      does not support check for system package; optional, use "./configure --enable-bliss" to install
boost-1_66_0:                                no suitable system package; optional, use "./configure --enable-boost" to install
boost_cropped-1.66.0.p0:                     already installed as an SPKG
brial-1.2.5:                                 does not support check for system package; will be installed as an SPKG
buckygen-1.1:                                does not support check for system package; optional, use "./configure --enable-buckygen" to install
bzip2-1.0.6-20150304.p0:                     using system package; SPKG will not be installed
cbc-2.9.4.p0:                                no suitable system package; optional, use "./configure --enable-cbc" to install
ccache-3.3.4:                                does not support check for system package; optional, use "./configure --enable-ccache" to install
cddlib-0.94j:                                does not support check for system package; will be installed as an SPKG
certifi-2019.3.9:                            does not support check for system package; will be installed as an SPKG
cliquer-1.21.p4:                             already installed as an SPKG
cmake-3.11.0:                                using system package; SPKG will not be installed
cocoalib-0.99564:                            does not support check for system package; experimental, use "./configure --enable-cocoalib" to install
combinatorial_designs-20140630.p0:           does not support check for system package; will be installed as an SPKG
compilerwrapper-1.2:                         does not support check for system package; experimental, use "./configure --enable-compilerwrapper" to install
configparser-3.7.4:                          does not support check for system package; will be installed as an SPKG
configure-e4607fdd24b7921f03499d3cba645ea2d14f7d87:does not support check for system package; came preinstalled with the SageMath tarball
conway_polynomials-0.5:                      does not support check for system package; will be installed as an SPKG
coxeter3-8ac9c71723c8ca57a836d6381aed125261e44e9e:does not support check for system package; optional, use "./configure --enable-coxeter3" to install
cryptominisat-5.6.8:                         does not support check for system package; optional, use "./configure --enable-cryptominisat" to install
csdp-6.2.p0:                                 does not support check for system package; optional, use "./configure --enable-csdp" to install
curl-7.62.0.p0:                              using system package; SPKG will not be installed
cvxopt-1.2.3:                                does not support check for system package; will be installed as an SPKG
cycler-0.10.0.p0:                            does not support check for system package; will be installed as an SPKG
cypari-2.1.1:                                does not support check for system package; will be installed as an SPKG
cysignals-1.10.2:                            does not support check for system package; will be installed as an SPKG
cython-0.29.12.p0:                           does not support check for system package; will be installed as an SPKG
d3js-3.4.8:                                  does not support check for system package; optional, use "./configure --enable-d3js" to install
database_cremona_ellcurve-20190911:          does not support check for system package; optional, use "./configure --enable-database_cremona_ellcurve" to install
database_jones_numfield-4:                   does not support check for system package; optional, use "./configure --enable-database_jones_numfield" to install
...

(Earlier version: merge request at https://gitlab.com/sagemath/sage/-/merge_requests/38)

Depends on #29120

CC: @embray @jhpalmieri @mkoeppe

Component: build: configure

Author: Julian Rüth, Matthias Koeppe

Branch: bef6d57

Reviewer: Matthias Koeppe, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/28788

saraedum commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,10 +1,7 @@
-Julian Rüth ([@saraedum](https://gitlab.com/saraedum)) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/38:
+I found the documentation of these macros quite misleading, so I tried to fix the documentation and added comments in the actual macros that I would have liked to see to understand what is going on.
+
+In the end I made quite some modifications to cleanup the control flow. I hope I didn't overdo it.

 ---

-
-
-
-
-
-
+Let's use https://gitlab.com/sagemath/sage/merge_requests/38 to discuss this further as it's easier to comment on the changeset there.
saraedum commented 4 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 ---

 Let's use https://gitlab.com/sagemath/sage/merge_requests/38 to discuss this further as it's easier to comment on the changeset there.
+
+See #28785 for some previous discussion.
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Changed commit from 84a6e82 to cabfe1f

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago
comment:3

New commits added to merge request. I updated the commit SHA-1. New commits:

cabfe1ffix use of polymorphic variable
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,9 +1,55 @@
-I found the documentation of these macros quite misleading, so I tried to fix the documentation and added comments in the actual macros that I would have liked to see to understand what is going on.
-
-In the end I made quite some modifications to cleanup the control flow. I hope I didn't overdo it.
+Julian Rüth ([@saraedum](https://gitlab.com/saraedum)) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/38:

 ---

-Let's use https://gitlab.com/sagemath/sage/merge_requests/38 to discuss this further as it's easier to comment on the changeset there.
+```markdown
+This now produces the following output for me which is hopefully a bit more friendly:

-See #28785 for some previous discussion.
+```
+[…]
+## ------------------------------------------------- ##
+## checking whether SageMath should install SPKG gcc ##
+## ------------------------------------------------- ##
+checking for C++ compiler vendor... gnu
+checking whether /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ supports C++11 features with -std=gnu++11... yes
+checking for /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-cc option to accept ISO C99... none needed
+checking if gcc accepts -dumpversion option... yes
+checking gcc version... 7.3.0
+checking if g++ accepts -dumpversion option... yes
+checking g++ version... 7.3.0
+configure: Installing GCC because there is a mismatch of assemblers
+configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/as
+configure:   $AS equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-as
+configure: Installing GCC because there is a mismatch of linkers
+configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld
+configure:   $LD equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-ld
+configure: no suitable system package found for SPKG gcc
+checking for the location of crti.o... /home/jule/proj/conda/miniconda3/envs/sage/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/../lib
+## -------------------------------------------------------------------- ##
+## checking whether SageMath should install SPKG perl_term_readline_gnu ##
+## -------------------------------------------------------------------- ##
+checking for perl module Term::ReadLine... ok
+checking Term::ReadLine module...... non-GNU
+configure: no suitable system package found for SPKG perl_term_readline_gnu
+## -------------------------------------------------- ##
+## checking whether SageMath should install SPKG mpir ##
+## -------------------------------------------------- ##
+checking gmp.h usability... yes
+checking gmp.h presence... yes
+checking for gmp.h... yes
+checking gmpxx.h usability... yes
+checking gmpxx.h presence... yes
+checking for gmpxx.h... yes
+checking for library containing __gmpq_cmp_z... -lgmp
+configure: will use system package and not install SPKG mpir
+checking absolute name of <gmp.h>... checking for gmp.h... (cached) yes
+///home/jule/proj/conda/miniconda3/envs/sage/include/gmp.h
+using GMP-compatible library from the system
+[…]
+configure: make will build and install the following SPKGs... [shortened by the author]
+    gcc-9.2.0 (no suitable system package)
+    mpfrcx-0.5
+    mpir-3.0.0-644faf502c56f97d9accd301965fc57d6ec70868.p0 (using system package; will not be installed)
+```
+```
+
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Changed commit from cabfe1f to 146eaab

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago
comment:5

New commits added to merge request. I updated the commit SHA-1. New commits:

146eaabalign code for readability
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Changed commit from 146eaab to 7f889c1

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago
comment:6

New commits added to merge request. I updated the commit SHA-1. New commits:

7f889c1fix yasm require check
saraedum commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,55 +1,5 @@
-Julian Rüth ([@saraedum](https://gitlab.com/saraedum)) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/38:
-
+In the end I made quite some modifications to cleanup the control flow. I hope I didn't overdo it.
+   
 ---
-
-```markdown
-This now produces the following output for me which is hopefully a bit more friendly:
-
-```
-[…]
-## ------------------------------------------------- ##
-## checking whether SageMath should install SPKG gcc ##
-## ------------------------------------------------- ##
-checking for C++ compiler vendor... gnu
-checking whether /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ supports C++11 features with -std=gnu++11... yes
-checking for /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-cc option to accept ISO C99... none needed
-checking if gcc accepts -dumpversion option... yes
-checking gcc version... 7.3.0
-checking if g++ accepts -dumpversion option... yes
-checking g++ version... 7.3.0
-configure: Installing GCC because there is a mismatch of assemblers
-configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/as
-configure:   $AS equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-as
-configure: Installing GCC because there is a mismatch of linkers
-configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld
-configure:   $LD equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-ld
-configure: no suitable system package found for SPKG gcc
-checking for the location of crti.o... /home/jule/proj/conda/miniconda3/envs/sage/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/../lib
-## -------------------------------------------------------------------- ##
-## checking whether SageMath should install SPKG perl_term_readline_gnu ##
-## -------------------------------------------------------------------- ##
-checking for perl module Term::ReadLine... ok
-checking Term::ReadLine module...... non-GNU
-configure: no suitable system package found for SPKG perl_term_readline_gnu
-## -------------------------------------------------- ##
-## checking whether SageMath should install SPKG mpir ##
-## -------------------------------------------------- ##
-checking gmp.h usability... yes
-checking gmp.h presence... yes
-checking for gmp.h... yes
-checking gmpxx.h usability... yes
-checking gmpxx.h presence... yes
-checking for gmpxx.h... yes
-checking for library containing __gmpq_cmp_z... -lgmp
-configure: will use system package and not install SPKG mpir
-checking absolute name of <gmp.h>... checking for gmp.h... (cached) yes
-///home/jule/proj/conda/miniconda3/envs/sage/include/gmp.h
-using GMP-compatible library from the system
-[…]
-configure: make will build and install the following SPKGs... [shortened by the author]
-    gcc-9.2.0 (no suitable system package)
-    mpfrcx-0.5
-    mpir-3.0.0-644faf502c56f97d9accd301965fc57d6ec70868.p0 (using system package; will not be installed)
-```
-```
-
+Let's use https://gitlab.com/sagemath/sage/merge_requests/38 to discuss this further as it's easier to comment on the changeset there.
+See #28785 for some previous discussion.
saraedum commented 4 years ago
comment:8

I made some remarks on GitLab. Looking forward to comments at https://gitlab.com/sagemath/sage/merge_requests/38.

jhpalmieri commented 4 years ago
comment:9

config.log is still misleading:

result: no
no suitable system package found for SPKG rw
configure:20250: make will build and install the following SPKGs...
     4ti2-1.6.7.p0
     alabaster-0.7.12
     appnope-0.1.0.p0
     arb-2.16.0.p0 (no suitable system package)
     atlas-3.10.2.p3
     ...
     bzip2-1.0.6-20150304.p0 (using system package; will not be installed)
     ...

4ti2 and atlas are optional, and so they will not in fact be installed unless explicitly instructed via a command like make 4ti2. The package bzip2 is listed in this group of packages that make will build and installed, but with a note saying that it won't be installed. (Note also that make bzip2 will install bzip2, even though there is a valid system package.)

Also it would help to have a divider between the last test ("no suitable system package found for SPKG rw") and the start of the summary.

I would prefer to see something like

checking for library containing calculate_level... no
configure: no suitable system package found for SPKG rw
------------
configure: build status for each package:
   4ti2-1.6.7.p0: optional; not installed by default
   alabaster-0.7.12: will be installed
   appnope-0.1.0.p0: will be installed
   arb-2.16.0.p0: no suitable system package; will be installed
   atlas-3.10.2.p3: optional; not installed by default
   ...
   bzip2-1.0.6-20150304.p0: using system package; will not be installed
   ...
embray commented 4 years ago
comment:10

Ticket retargeted after milestone closed

mkoeppe commented 4 years ago
comment:12

Related: #28095 - Add --enable-OPTIONALSPKG options to configure

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago
comment:13

New commits added to merge request. I updated the commit SHA-1. New commits:

275225achange wording & layout of build status header
455b550Explain which packages are not going to be installed
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Changed commit from 7f889c1 to 455b550

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,5 +1,336 @@
-In the end I made quite some modifications to cleanup the control flow. I hope I didn't overdo it.
-   
+Julian Rüth ([@saraedum](https://gitlab.com/saraedum)) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/38:
+
 ---
-Let's use https://gitlab.com/sagemath/sage/merge_requests/38 to discuss this further as it's easier to comment on the changeset there.
-See #28785 for some previous discussion.
+
+```markdown
+This now produces the following output for me which is hopefully a bit more friendly:
+
+```
+[…]
+## ------------------------------------------------- ##
+## checking whether SageMath should install SPKG gcc ##
+## ------------------------------------------------- ##
+checking for C++ compiler vendor... gnu
+checking whether /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ supports C++11 features with -std=gnu++11... yes
+checking for /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-cc option to accept ISO C99... none needed
+checking if gcc accepts -dumpversion option... yes
+checking gcc version... 7.3.0
+checking if g++ accepts -dumpversion option... yes
+checking g++ version... 7.3.0
+configure: Installing GCC because there is a mismatch of assemblers
+configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/as
+configure:   $AS equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-as
+configure: Installing GCC because there is a mismatch of linkers
+configure:   /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld
+configure:   $LD equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-ld
+configure: no suitable system package found for SPKG gcc
+checking for the location of crti.o... /home/jule/proj/conda/miniconda3/envs/sage/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/../lib
+## -------------------------------------------------------------------- ##
+## checking whether SageMath should install SPKG perl_term_readline_gnu ##
+## -------------------------------------------------------------------- ##
+checking for perl module Term::ReadLine... ok
+checking Term::ReadLine module...... non-GNU
+configure: no suitable system package found for SPKG perl_term_readline_gnu
+## -------------------------------------------------- ##
+## checking whether SageMath should install SPKG mpir ##
+## -------------------------------------------------- ##
+checking gmp.h usability... yes
+checking gmp.h presence... yes
+checking for gmp.h... yes
+checking gmpxx.h usability... yes
+checking gmpxx.h presence... yes
+checking for gmpxx.h... yes
+checking for library containing __gmpq_cmp_z... -lgmp
+configure: will use system package and not install SPKG mpir
+checking absolute name of <gmp.h>... checking for gmp.h... (cached) yes
+///home/jule/proj/conda/miniconda3/envs/sage/include/gmp.h
+using GMP-compatible library from the system
+[…]
+## ------------------------------ ##
+## build status for each package: ##
+## ------------------------------ ##
+    4ti2-1.6.7.p0: does not support check for system package yet; optional, will not be installed unless requested
+    alabaster-0.7.12: does not support check for system package yet; will be installed
+    appnope-0.1.0.p0: does not support check for system package yet; will be installed
+    arb-2.16.0.p0: using system package; will not be installed
+    atlas-3.10.2.p3: does not support check for system package yet; optional, will not be installed unless requested
+    autotools-20141105.p0: does not support check for system package yet; experimental, will not be installed unless requested
+    awali-1.0.2-190218: does not support check for system package yet; experimental, will not be installed unless requested
+    babel-2.6.0: does not support check for system package yet; will be installed
+    backports_abc-0.5: does not support check for system package yet; will be installed
+    backports_functools_lru_cache-1.5: does not support check for system package yet; will be installed
+    backports_shutil_get_terminal_size-1.0.0.p1: does not support check for system package yet; will be installed
+    backports_ssl_match_hostname-3.5.0.1.p0: does not support check for system package yet; will be installed
+    barvinok-0.41.1: does not support check for system package yet; optional, will not be installed unless requested
+    benzene-20130630: does not support check for system package yet; optional, will not be installed unless requested
+    bleach-3.1.0: does not support check for system package yet; will be installed
+    bliss-0.73+debian-1+sage-2016-08-02.p0: does not support check for system package yet; optional, will not be installed unless requested
+    boost-1_66_0: does not support check for system package yet; optional, will not be installed unless requested
+    boost_cropped-1.66.0.p0: does not support check for system package yet; will be installed
+    brial-1.2.5: does not support check for system package yet; will be installed
+    buckygen-1.0: does not support check for system package yet; experimental, will not be installed unless requested
+    bzip2-1.0.6-20150304.p0: using system package; will not be installed
+    cbc-2.9.4.p0: does not support check for system package yet; optional, will not be installed unless requested
+    ccache-3.3.4: does not support check for system package yet; optional, will not be installed unless requested
+    cddlib-0.94j: does not support check for system package yet; will be installed
+    certifi-2019.3.9: does not support check for system package yet; will be installed
+    cliquer-1.21.p4: does not support check for system package yet; will be installed
+    cmake-3.11.0: using system package; will not be installed
+    cocoalib-0.99564: does not support check for system package yet; experimental, will not be installed unless requested
+    combinatorial_designs-20140630.p0: does not support check for system package yet; will be installed
+    compilerwrapper-1.2: does not support check for system package yet; experimental, will not be installed unless requested
+    configparser-3.7.4: does not support check for system package yet; will be installed
+    configure-026a216fa444461e3a5d4b76a11c074784f5fdf7: does not support check for system package yet; came preinstalled with the SageMath tarball
+    conway_polynomials-0.5: does not support check for system package yet; will be installed
+    coxeter3-8ac9c71723c8ca57a836d6381aed125261e44e9e: does not support check for system package yet; optional, will not be installed unless requested
+    cryptominisat-5.6.8: does not support check for system package yet; optional, will not be installed unless requested
+    csdp-6.2.p0: does not support check for system package yet; optional, will not be installed unless requested
+    curl-7.62.0.p0: using system package; will not be installed
+    cvxopt-1.1.8.p2: does not support check for system package yet; will be installed
+    cycler-0.10.0.p0: does not support check for system package yet; will be installed
+    cypari-2.1.1: does not support check for system package yet; will be installed
+    cysignals-1.10.2: does not support check for system package yet; will be installed
+    cython-0.29.12.p0: does not support check for system package yet; will be installed
+    d3js-3.4.8: does not support check for system package yet; optional, will not be installed unless requested
+    database_cremona_ellcurve-20190911: does not support check for system package yet; optional, will not be installed unless requested
+    database_jones_numfield-4: does not support check for system package yet; optional, will not be installed unless requested
+    database_kohel-20160724: does not support check for system package yet; optional, will not be installed unless requested
+    database_mutation_class-1.0: does not support check for system package yet; optional, will not be installed unless requested
+    database_odlyzko_zeta-20061209: does not support check for system package yet; optional, will not be installed unless requested
+    database_stein_watkins-20110713: does not support check for system package yet; optional, will not be installed unless requested
+    database_stein_watkins_mini-20070827: does not support check for system package yet; optional, will not be installed unless requested
+    database_symbolic_data-20070206: does not support check for system package yet; optional, will not be installed unless requested
+    dateutil-2.5.3: does not support check for system package yet; will be installed
+    decorator-4.4.0: does not support check for system package yet; will be installed
+    deformation-d05941b.p0: does not support check for system package yet; optional, will not be installed unless requested
+    defusedxml-0.6.0: does not support check for system package yet; will be installed
+    docutils-0.14: does not support check for system package yet; will be installed
+    dot2tex-2.11.3.p0: does not support check for system package yet; optional, will not be installed unless requested
+    e_antic-0.1.3: does not support check for system package yet; optional, will not be installed unless requested
+    ecl-16.1.2.p5: does not support check for system package yet; will be installed
+    eclib-20190909: no suitable system package; will be installed
+    ecm-7.0.4.p1: using system package; will not be installed
+    elliptic_curves-0.8.1: does not support check for system package yet; will be installed
+    entrypoints-0.3: does not support check for system package yet; will be installed
+    enum34-1.1.6: does not support check for system package yet; will be installed
+    fflas_ffpack-2.4.3: does not support check for system package yet; will be installed
+    flask-0.10.1.p0: does not support check for system package yet; will be installed
+    flask_autoindex-0.6.p0: does not support check for system package yet; will be installed
+    flask_babel-0.9.p0: does not support check for system package yet; will be installed
+    flask_oldsessions-0.10.p0: does not support check for system package yet; will be installed
+    flask_openid-1.2.5.p0: does not support check for system package yet; will be installed
+    flask_silk-0.2.p0: does not support check for system package yet; will be installed
+    flint-2.5.2.p5: using system package; will not be installed
+    flintqs-1.0.p0: does not support check for system package yet; will be installed
+    fplll-5.2.1: does not support check for system package yet; will be installed
+    fpylll-0.4.1dev: does not support check for system package yet; will be installed
+    freetype-2.9.1: using system package; will not be installed
+    fricas-1.3.5: does not support check for system package yet; optional, will not be installed unless requested
+    frobby-0.9.0.p2: does not support check for system package yet; optional, will not be installed unless requested
+    functools32-3.2.3-2.p0: does not support check for system package yet; will be installed
+    future-0.17.1: does not support check for system package yet; will be installed
+    gambit-15.1.1.p0: does not support check for system package yet; experimental, will not be installed unless requested
+    gap-4.10.2.p1: does not support check for system package yet; will be installed
+    gap3-04jul17: does not support check for system package yet; experimental, will not be installed unless requested
+    gap_jupyter-0.9: does not support check for system package yet; optional, will not be installed unless requested
+    gap_packages-4.10.2.p1: does not support check for system package yet; optional, will not be installed unless requested
+    gc-7.6.4.p0: does not support check for system package yet; will be installed
+    gcc-9.2.0: using system package; will not be installed
+    gdb-8.2: does not support check for system package yet; experimental, will not be installed unless requested
+    gf2x-1.2.p0: no suitable system package; will be installed
+    gfan-0.6.2.p1: does not support check for system package yet; will be installed
+    gfortran-9.2.0: using system package; will not be installed
+    giac-1.5.0.63.p0: does not support check for system package yet; will be installed
+    giacpy_sage-0.6.8: does not support check for system package yet; optional, will not be installed unless requested
+    git-2.11.0: using system package; will not be installed
+    git_trac-20160625.p0: does not support check for system package yet; optional, will not be installed unless requested
+    givaro-4.1.1: using system package; will not be installed
+    glpk-4.65.p0: using system package; will not be installed
+    glucose-4.1: does not support check for system package yet; optional, will not be installed unless requested
+    gmp-6.1.2: using system package; will not be installed
+    gmpy2-2.1.0b1: does not support check for system package yet; will be installed
+    gp2c-0.0.10.p0: no suitable system package; optional, will not be installed unless requested
+    graphs-20161026.p0: does not support check for system package yet; will be installed
+    gsl-2.5: does not support check for system package yet; will be installed
+    html5lib-1.0.1: does not support check for system package yet; will be installed
+    iconv-1.15: using system package; will not be installed
+    igraph-0.7.1999.p0: does not support check for system package yet; optional, will not be installed unless requested
+    imagesize-1.1.0: does not support check for system package yet; will be installed
+    iml-1.0.4p1.p2: does not support check for system package yet; will be installed
+    ipaddress-1.0.22: does not support check for system package yet; will be installed
+    ipykernel-4.8.2: does not support check for system package yet; will be installed
+    ipython-5.8.0: does not support check for system package yet; will be installed
+    ipython_genutils-0.2.0: does not support check for system package yet; will be installed
+    ipywidgets-7.4.2: does not support check for system package yet; will be installed
+    isl-0.20: no suitable system package; optional, will not be installed unless requested
+    itsdangerous-1.1.0: does not support check for system package yet; will be installed
+    jinja2-2.10: does not support check for system package yet; will be installed
+    jmol-14.29.52: does not support check for system package yet; will be installed
+    jsonschema-2.6.0: does not support check for system package yet; will be installed
+    jupymake-0.9: does not support check for system package yet; optional, will not be installed unless requested
+    jupyter_client-5.2.4: does not support check for system package yet; will be installed
+    jupyter_core-4.4.0: does not support check for system package yet; will be installed
+    kenzo-1.1.7-r3: does not support check for system package yet; optional, will not be installed unless requested
+    kiwisolver-1.0.1: does not support check for system package yet; will be installed
+    latte_int-1.7.5.p0: does not support check for system package yet; optional, will not be installed unless requested
+    lcalc-1.23.p19: no suitable system package; will be installed
+    libatomic_ops-7.6.2: does not support check for system package yet; will be installed
+    libbraiding-1.0: does not support check for system package yet; will be installed
+    libffi-3.2.1: using system package; will not be installed
+    libgd-2.1.1.1.p1: using system package; will not be installed
+    libhomfly-1.02r4: does not support check for system package yet; will be installed
+    libogg-1.3.1.p0: does not support check for system package yet; optional, will not be installed unless requested
+    libpng-1.6.29.p1: using system package; will not be installed
+    libsemigroups-0.6.7: no suitable system package; optional, will not be installed unless requested
+    libtheora-1.1.1: does not support check for system package yet; experimental, will not be installed unless requested
+    lidia-2.3.0+latte-patches-2019-05-02: does not support check for system package yet; optional, will not be installed unless requested
+    lie-2.2.2: does not support check for system package yet; experimental, will not be installed unless requested
+    linbox-1.6.3: does not support check for system package yet; will be installed
+    lrcalc-1.2.p1: using system package; will not be installed
+    lrslib-062+autotools-2017-03-03.p1: does not support check for system package yet; optional, will not be installed unless requested
+    m4ri-20140914.p0: using system package; will not be installed
+    m4rie-20150908.p0: using system package; will not be installed
+    markupsafe-1.1.0: does not support check for system package yet; will be installed
+    mathjax-2.7.4.p0: does not support check for system package yet; will be installed
+    matplotlib-2.2.4.p0: does not support check for system package yet; will be installed
+    maxima-5.42.2: does not support check for system package yet; will be installed
+    mcqd-1.0: does not support check for system package yet; optional, will not be installed unless requested
+    meataxe-1.0.p0: does not support check for system package yet; optional, will not be installed unless requested
+    mistune-0.8.4: does not support check for system package yet; will be installed
+    modular_decomposition-20100607: does not support check for system package yet; experimental, will not be installed unless requested
+    mpc-1.1.0: using system package; will not be installed
+    mpfi-1.5.2: using system package; will not be installed
+    mpfr-4.0.1.p0: using system package; will not be installed
+    mpfrcx-0.5: does not support check for system package yet; optional, will not be installed unless requested
+    mpir-3.0.0-644faf502c56f97d9accd301965fc57d6ec70868.p0: using system package; will not be installed
+    mpmath-1.1.0: does not support check for system package yet; will be installed
+    nauty-26r1.p0: does not support check for system package yet; will be installed
+    nbconvert-5.4.0: does not support check for system package yet; will be installed
+    nbformat-4.4.0: does not support check for system package yet; will be installed
+    ncurses-6.0.p0: using system package; will not be installed
+    networkx-2.2: does not support check for system package yet; will be installed
+    ninja_build-1.8.2: using system package; will not be installed
+    normaliz-3.7.2: does not support check for system package yet; optional, will not be installed unless requested
+    nose-1.3.7: does not support check for system package yet; will be installed
+    notebook-5.7.6.p0: does not support check for system package yet; will be installed
+    notedown-1.5.1: does not support check for system package yet; optional, will not be installed unless requested
+    ntl-11.3.2: using system package; will not be installed
+    numpy-1.16.1: does not support check for system package yet; will be installed
+    openblas-0.3.6.p0: does not support check for system package yet; will be installed
+    openssl-1.1.1b: does not support check for system package yet; optional, will not be installed unless requested
+    ore_algebra-0.3: does not support check for system package yet; optional, will not be installed unless requested
+    p_group_cohomology-3.3: does not support check for system package yet; optional, will not be installed unless requested
+    packaging-18.0: does not support check for system package yet; will be installed
+    palp-2.1.p2: does not support check for system package yet; will be installed
+    pandoc_attributes-8bc82f6d: does not support check for system package yet; optional, will not be installed unless requested
+    pandocfilters-1.4.2: does not support check for system package yet; will be installed
+    pari-2.11.1.p2: no suitable system package; will be installed
+    pari_elldata-20161017: no suitable system package; optional, will not be installed unless requested
+    pari_galdata-20080411.p0: no suitable system package; will be installed
+    pari_galpol-20180625: no suitable system package; optional, will not be installed unless requested
+    pari_jupyter-1.3.2: does not support check for system package yet; optional, will not be installed unless requested
+    pari_nftables-20080929: no suitable system package; optional, will not be installed unless requested
+    pari_seadata-20090618: no suitable system package; optional, will not be installed unless requested
+    pari_seadata_small-20090618.p0: no suitable system package; will be installed
+    patch-2.7.5: using system package; will not be installed
+    pathlib2-2.3.3: does not support check for system package yet; will be installed
+    pathpy-7.1.p0: does not support check for system package yet; will be installed
+    pcre-8.40.p2: using system package; will not be installed
+    perl_term_readline_gnu-1.35: using system package; will not be installed
+    pexpect-4.6.0.p0: does not support check for system package yet; will be installed
+    pickleshare-0.7.5: does not support check for system package yet; will be installed
+    pillow-5.3.0.p0: does not support check for system package yet; will be installed
+    pip-18.1: does not support check for system package yet; will be installed
+    pkgconf-0.9.7.p2: using system package; will not be installed
+    pkgconfig-1.4.0: does not support check for system package yet; will be installed
+    planarity-3.0.0.5.p0: does not support check for system package yet; will be installed
+    plantri-4.5: does not support check for system package yet; optional, will not be installed unless requested
+    polylib-5.22.5: does not support check for system package yet; optional, will not be installed unless requested
+    polymake-3.4: does not support check for system package yet; experimental, will not be installed unless requested
+    polytopes_db-20170220.p0: does not support check for system package yet; will be installed
+    ppl-1.2.p1: does not support check for system package yet; will be installed
+    pplpy-0.8.4: does not support check for system package yet; will be installed
+    primecount-5.1: does not support check for system package yet; optional, will not be installed unless requested
+    prometheus_client-0.5.0: does not support check for system package yet; will be installed
+    prompt_toolkit-1.0.15: does not support check for system package yet; will be installed
+    psutil-5.2.0.p2: does not support check for system package yet; will be installed
+    ptyprocess-0.5.1.p0: does not support check for system package yet; will be installed
+    pycosat-0.6.3: does not support check for system package yet; optional, will not be installed unless requested
+    pycygwin-0.1: does not support check for system package yet; will be installed
+    pygments-2.3.1.p0: does not support check for system package yet; will be installed
+    pynac-0.7.26: does not support check for system package yet; will be installed
+    pynormaliz-2.7: does not support check for system package yet; optional, will not be installed unless requested
+    pyparsing-2.3.0: does not support check for system package yet; will be installed
+    pysingular-0.9.5: does not support check for system package yet; optional, will not be installed unless requested
+    python2-2.7.15.p1: does not support check for system package yet; optional, will not be installed unless requested
+    python3-3.7.3.p1: does not support check for system package yet; will be installed
+    python_igraph-0.7.1999: does not support check for system package yet; optional, will not be installed unless requested
+    python_openid-2.2.5.p0: does not support check for system package yet; will be installed
+    pytz-2018.7: does not support check for system package yet; will be installed
+    pyzmq-18.1.0: does not support check for system package yet; will be installed
+    qepcad-B.1.71: does not support check for system package yet; experimental, will not be installed unless requested
+    qhull-2015-src-7.2.0.p1: does not support check for system package yet; optional, will not be installed unless requested
+    r-3.6.1: does not support check for system package yet; will be installed
+    ratpoints-2.1.3.p5: does not support check for system package yet; will be installed
+    readline-6.3.008.p0: using system package; will not be installed
+    requests-2.13.0: does not support check for system package yet; will be installed
+    rpy2-2.8.2.p1: does not support check for system package yet; will be installed
+    rst2ipynb-0.2.2.p0: does not support check for system package yet; optional, will not be installed unless requested
+    rubiks-20070912.p21: does not support check for system package yet; will be installed
+    rw-0.7.p0: using system package; will not be installed
+    saclib-2.2.7: does not support check for system package yet; optional, will not be installed unless requested
+    sagenb-1.1.2: does not support check for system package yet; optional, will not be installed unless requested
+    sagenb_export-3.3: does not support check for system package yet; will be installed
+    sagetex-3.3: does not support check for system package yet; will be installed
+    scandir-1.9.0: does not support check for system package yet; will be installed
+    scipoptsuite-5.0.1: does not support check for system package yet; experimental, will not be installed unless requested
+    scipy-1.2.0: does not support check for system package yet; will be installed
+    scons-1.2.0: does not support check for system package yet; experimental, will not be installed unless requested
+    send2trash-1.5.0: does not support check for system package yet; will be installed
+    setuptools-40.6.3: does not support check for system package yet; will be installed
+    setuptools_scm-3.1.0: does not support check for system package yet; will be installed
+    simplegeneric-0.8.1.p0: does not support check for system package yet; will be installed
+    singledispatch-3.4.0.3.p0: does not support check for system package yet; will be installed
+    singular-4.1.1p2.p0: does not support check for system package yet; will be installed
+    singular_jupyter-0.9.7: does not support check for system package yet; optional, will not be installed unless requested
+    sip-4.18: does not support check for system package yet; optional, will not be installed unless requested
+    sirocco-2.0.p0: does not support check for system package yet; optional, will not be installed unless requested
+    six-1.12.0: does not support check for system package yet; will be installed
+    snowballstemmer-1.2.1.p0: does not support check for system package yet; will be installed
+    speaklater-1.3.p0: does not support check for system package yet; will be installed
+    sphinx-1.8.5.p0: does not support check for system package yet; will be installed
+    sphinxcontrib_websupport-1.1.0: does not support check for system package yet; will be installed
+    sqlite-3290000: does not support check for system package yet; will be installed
+    subprocess32-3.5.3: does not support check for system package yet; will be installed
+    surf-1.0.6-gcc6: does not support check for system package yet; experimental, will not be installed unless requested
+    symmetrica-2.0.p11: using system package; will not be installed
+    sympow-1.018.1.p13: does not support check for system package yet; will be installed
+    sympy-1.4.p0: does not support check for system package yet; will be installed
+    tachyon-0.98.9.p7: does not support check for system package yet; will be installed
+    tdlib-0.3.1.p0: does not support check for system package yet; optional, will not be installed unless requested
+    termcap-1.3.1.p3: does not support check for system package yet; optional, will not be installed unless requested
+    terminado-0.8.1: does not support check for system package yet; will be installed
+    testpath-0.4.2: does not support check for system package yet; will be installed
+    thebe-9624e0a0.p0: does not support check for system package yet; will be installed
+    threejs-r110: does not support check for system package yet; will be installed
+    tides-2.0.p0: does not support check for system package yet; optional, will not be installed unless requested
+    topcom-0.17.7: does not support check for system package yet; optional, will not be installed unless requested
+    tornado-4.5.2: does not support check for system package yet; will be installed
+    traitlets-4.3.2: does not support check for system package yet; will be installed
+    twisted-16.3.0.p0: does not support check for system package yet; will be installed
+    typing-3.6.6: does not support check for system package yet; will be installed
+    valgrind-3.14.0: does not support check for system package yet; experimental, will not be installed unless requested
+    vcversioner-2.16.0.0.p0: does not support check for system package yet; will be installed
+    wcwidth-0.1.7.p0: does not support check for system package yet; will be installed
+    webencodings-0.5.1: does not support check for system package yet; will be installed
+    werkzeug-0.14.1: does not support check for system package yet; will be installed
+    widgetsnbextension-3.4.2: does not support check for system package yet; will be installed
+    xz-5.2.2.p0: using system package; will not be installed
+    yasm-1.3.0.p0: using system package; will not be installed
+    zeromq-4.2.5: using system package; will not be installed
+    zlib-1.2.11.p0: using system package; will not be installed
+    zn_poly-0.9.1.p0: does not support check for system package yet; will be installed
+    zope_interface-4.6.0: does not support check for system package yet; will be installed
+```
+```
+
f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago

Changed commit from 455b550 to 5863ac7

f588ca1e-f96a-4dea-804d-c55eab873dab commented 4 years ago
comment:15

New commits added to merge request. I updated the commit SHA-1. New commits:

5863ac7Make sage_require_ follow the documentation
mkoeppe commented 4 years ago

Description changed:

mkoeppe commented 4 years ago
comment:16

This is a great improvement and seems to work fine on top of current develop. I'm setting this to positive review, although I have suggestions for improvements:

mkoeppe commented 4 years ago

Reviewer: Matthias Koeppe

jhpalmieri commented 4 years ago
comment:18

I get a merge failure with 9.1.beta3. Once fixed, please feel free to set back to positive review.

jhpalmieri commented 4 years ago
comment:19

Actually, I have another request. The output in the ticket description, including

configure: will use system package and not install SPKG zeromq
## ------------------------------ ##
## build status for each package: ##
## ------------------------------ ##
    4ti2-1.6.7.p0: does not support check for system package yet; optional, will not be installed unless requested

is what is printed on the screen, but the config.log file shows

configure:25323: will use system package and not install SPKG zeromq
configure:28740: result:     4ti2-1.6.7.p0: does not support check for system package yet; optional, will not be installed unless requested

with no text separating the last test from the summary. Can you add some text there so I can easily search config.log to find the spot where the summary starts?

Indeed, perhaps all of the summary text ("checking whether SageMath should install SPKG tachyon", etc.) should be included in the log file, not just on the screen.

jhpalmieri commented 4 years ago
comment:20

To explain a bit more about my last comment: I am much more likely to look through the log file than to see the mass of text whiz by on the screen, so (assuming I'm not the only one) the log file should have formatting at least as good as what's on the screen.

mkoeppe commented 4 years ago
comment:21

I agree, everything that is printed on the screen should also appear in the log file.

saraedum commented 4 years ago
comment:22

I won't continue on this one. If you are unhappy with autoconf defaults, feel free to work around them.

jhpalmieri commented 4 years ago
comment:23

mkoeppe: I don't know autoconf syntax, but if you can do the last fixes, I can review.

mkoeppe commented 4 years ago

Changed branch from u/galois/mrs/38/verbose-configure to u/mkoeppe/mrs/38/verbose-configure

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

bef6d57Improve spkg messages
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 5863ac7 to bef6d57

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,336 +1,67 @@
-Julian Rüth ([@saraedum](https://gitlab.com/saraedum)) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/38:
-
----
-
-```markdown
-This now produces the following output for me which is hopefully a bit more friendly:
+This now produces the following output:

-[…] -## ------------------------------------------------- ## -## checking whether SageMath should install SPKG gcc ## -## ------------------------------------------------- ## -checking for C++ compiler vendor... gnu -checking whether /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ supports C++11 features with -std=gnu++11... yes -checking for /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-cc option to accept ISO C99... none needed -checking if gcc accepts -dumpversion option... yes -checking gcc version... 7.3.0 -checking if g++ accepts -dumpversion option... yes -checking g++ version... 7.3.0 -configure: Installing GCC because there is a mismatch of assemblers -configure: /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/as -configure: $AS equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-as -configure: Installing GCC because there is a mismatch of linkers -configure: /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 uses /home/jule/proj/conda/miniconda3/envs/sage/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld -configure: $LD equal to /home/jule/proj/conda/miniconda3/envs/sage/bin/x86_64-conda_cos6-linux-gnu-ld -configure: no suitable system package found for SPKG gcc -checking for the location of crti.o... /home/jule/proj/conda/miniconda3/envs/sage/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/../lib -## -------------------------------------------------------------------- ## -## checking whether SageMath should install SPKG perl_term_readline_gnu ## -## -------------------------------------------------------------------- ## -checking for perl module Term::ReadLine... ok -checking Term::ReadLine module...... non-GNU -configure: no suitable system package found for SPKG perl_term_readline_gnu -## -------------------------------------------------- ## -## checking whether SageMath should install SPKG mpir ## -## -------------------------------------------------- ## -checking gmp.h usability... yes -checking gmp.h presence... yes -checking for gmp.h... yes -checking gmpxx.h usability... yes -checking gmpxx.h presence... yes -checking for gmpxx.h... yes -checking for library containing __gmpq_cmp_z... -lgmp -configure: will use system package and not install SPKG mpir -checking absolute name of ... checking for gmp.h... (cached) yes -///home/jule/proj/conda/miniconda3/envs/sage/include/gmp.h -using GMP-compatible library from the system -[…] -## ------------------------------ ## -## build status for each package: ## -## ------------------------------ ##

mkoeppe commented 4 years ago

Changed author from Julian Rüth to Julian Rüth, Matthias Koeppe

mkoeppe commented 4 years ago

Dependencies: #29120

mkoeppe commented 4 years ago
comment:28

Replying to @jhpalmieri:

mkoeppe: I don't know autoconf syntax, but if you can do the last fixes, I can review.

Ready for review.

jhpalmieri commented 4 years ago

Changed reviewer from Matthias Koeppe to Matthias Koeppe, John Palmieri

jhpalmieri commented 4 years ago
comment:29

Looks good to me, thanks! And thanks very much to saraedum for leading the efforts on this. Sorry to be so picky.

mkoeppe commented 4 years ago
comment:31

Thank you!

vbraun commented 4 years ago

Changed branch from u/mkoeppe/mrs/38/verbose-configure to bef6d57

mkoeppe commented 4 years ago
comment:33

Follow up: #29211

mkoeppe commented 4 years ago

Changed commit from bef6d57 to none