search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 481 forks source link

Polyhedron: Let affine hull fully respect backend #28876

Closed kliem closed 4 years ago

kliem commented 4 years ago

The method affine hull does not preserve backend, when orthogonal or orthonormal is True.

We fix this.

normaliz should be able to handle most base rings that appear with this method, so this is mostly usefull for the backend normaliz.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, backend, affine hull

Author: Jonathan Kliem

Branch/Commit: 2cb50f4

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28876

kliem commented 4 years ago

Commit: 2cb50f4

kliem commented 4 years ago

Branch: public/28876

kliem commented 4 years ago

New commits:

2cb50f4affine hull preservers backend if orthogonal or orthonormal
LaisRast commented 4 years ago

Reviewer: Laith Rastanawi

LaisRast commented 4 years ago
comment:2

It looks good to me. I will put it on positive review once the patchbots are done.

vbraun commented 4 years ago

Changed branch from public/28876 to 2cb50f4