sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.4k stars 473 forks source link

extract code from OEIS #29217

Closed fchapoton closed 4 years ago

fchapoton commented 4 years ago

at least try to, and open the possibility to check the code there

CC: @sagetrac-tmonteil @mo271 @videlec @seblabbe @tscrim @kcrisman

Component: combinatorics

Author: Frédéric Chapoton

Branch: c0d93fc

Reviewer: Thierry Monteil, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29217

fchapoton commented 4 years ago
comment:30

Comments anybody ?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from b3cc4c4 to bc7ce9c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bc7ce9ctrying to extract pari,sage,maxima code from OEIS program field
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from bc7ce9c to fc63b8b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fc63b8bfix
fchapoton commented 4 years ago
comment:33

Salut Thierry. Est-ce que tu aurais un petit moment pour regarder à nouveau, en particulier ma réponse à tes critiques dans le comment:26 ?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from fc63b8b to 38c4efc

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

38c4efctrying to extract pari,sage,maxima code from OEIS program field
fchapoton commented 4 years ago
comment:35

green bot. Thierry, s'il te plait ?

fchapoton commented 4 years ago
comment:36

anybody else for a review ?

tscrim commented 4 years ago
comment:37

Is this correct?

raise True
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 38c4efc to 1f8587c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b749cd2Merge branch 'u/chapoton/29217' of ssh://trac.sagemath.org:22/sage into oeis
1f8587cfix handling of dead ticket in testing-code function
DaveWitteMorris commented 4 years ago
comment:39

I noticed a minor typo in a docstring (not your fault). In line 108 there is a single backquote where double is needed:

-What does the Taylor expansion of the `e^(e^x-1)`` function have to do with
+What does the Taylor expansion of the ``e^(e^x-1)`` function have to do with

New commits:

b749cd2Merge branch 'u/chapoton/29217' of ssh://trac.sagemath.org:22/sage into oeis
1f8587cfix handling of dead ticket in testing-code function
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 1f8587c to a62f873

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a62f873some doc details in oeis.py
fchapoton commented 4 years ago
comment:41

Thanks, fixed both the wrong raise and the doc typo (using single quote for latex).

DaveWitteMorris commented 4 years ago
comment:42

If you want to use latex on line 108, then I think you need to change the round brackets ( ) to curly brackets { }. As it is now, I think the exponent only has the first round bracket, and e^x-1) is back on the baseline.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from a62f873 to c0d93fc

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

c0d93fcfix latex
fchapoton commented 4 years ago
comment:44

indeed, done, thanks

fchapoton commented 4 years ago
comment:45

any other comment, someone ?

tscrim commented 4 years ago
comment:46

I have no other comments, and I would be willing to set a positive review if there are no objections.

fchapoton commented 4 years ago
comment:47

Well. Thierry has got ample time to answer comment:25, and never did, in spite of repeated sollicitations.

tscrim commented 4 years ago
comment:48

Then positive review.

tscrim commented 4 years ago

Changed reviewer from Thierry Monteil to Thierry Monteil, Travis Scrimshaw

vbraun commented 4 years ago

Changed branch from u/chapoton/29217 to c0d93fc

seblabbe commented 4 years ago
comment:50

See a follow-up ticket: #30019

seblabbe commented 4 years ago

Changed commit from c0d93fc to none