Closed fchapoton closed 4 years ago
Comments anybody ?
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bc7ce9c | trying to extract pari,sage,maxima code from OEIS program field |
Branch pushed to git repo; I updated commit sha1. New commits:
fc63b8b | fix |
Salut Thierry. Est-ce que tu aurais un petit moment pour regarder à nouveau, en particulier ma réponse à tes critiques dans le comment:26 ?
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
38c4efc | trying to extract pari,sage,maxima code from OEIS program field |
green bot. Thierry, s'il te plait ?
anybody else for a review ?
Is this correct?
raise True
I noticed a minor typo in a docstring (not your fault). In line 108 there is a single backquote where double is needed:
-What does the Taylor expansion of the `e^(e^x-1)`` function have to do with
+What does the Taylor expansion of the ``e^(e^x-1)`` function have to do with
New commits:
b749cd2 | Merge branch 'u/chapoton/29217' of ssh://trac.sagemath.org:22/sage into oeis |
1f8587c | fix handling of dead ticket in testing-code function |
Branch pushed to git repo; I updated commit sha1. New commits:
a62f873 | some doc details in oeis.py |
Thanks, fixed both the wrong raise and the doc typo (using single quote for latex).
If you want to use latex on line 108, then I think you need to change the round brackets ( )
to curly brackets { }
. As it is now, I think the exponent only has the first round bracket, and e^x-1)
is back on the baseline.
Branch pushed to git repo; I updated commit sha1. New commits:
c0d93fc | fix latex |
indeed, done, thanks
any other comment, someone ?
I have no other comments, and I would be willing to set a positive review if there are no objections.
Well. Thierry has got ample time to answer comment:25, and never did, in spite of repeated sollicitations.
Then positive review.
Changed reviewer from Thierry Monteil to Thierry Monteil, Travis Scrimshaw
Changed branch from u/chapoton/29217 to c0d93fc
See a follow-up ticket: #30019
at least try to, and open the possibility to check the code there
CC: @sagetrac-tmonteil @mo271 @videlec @seblabbe @tscrim @kcrisman
Component: combinatorics
Author: Frédéric Chapoton
Branch:
c0d93fc
Reviewer: Thierry Monteil, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/29217