search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.47k stars 486 forks source link

Fix or disable failing package testsuites (spkg-check) #29322

Open mkoeppe opened 4 years ago

mkoeppe commented 4 years ago

There are many spkgs whose testsuites fail.

sage-spkg uses the following defaults:

# Since Python's self-tests seem to fail on all platforms, we disable
# its test suite by default.
if [ -z "$SAGE_CHECK_PACKAGES" ]; then
    SAGE_CHECK_PACKAGES='!python2,!python3'
fi

More should be added to adjust for expected failures.

See also:

CC: @dimpase @jhpalmieri

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/29322

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -12,4 +12,7 @@

 More should be added to adjust for expected failures.

-See also:  #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
+See also:  
+- #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
+- #22866 - Cygwin spkg-check meta-ticket
+
mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -12,6 +12,8 @@

 More should be added to adjust for expected failures.

+- `pathpy` -- `spkg-check` picks up top-level `tox.ini` and gets confused
+
 See also:  
 - #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
 - #22866 - Cygwin spkg-check meta-ticket
mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -17,4 +17,5 @@
 See also:  
 - #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
 - #22866 - Cygwin spkg-check meta-ticket
+- #28998 - Add script-type _spkg_check package that installs tox, mock, pytest etc.
jhpalmieri commented 4 years ago
comment:4

See also https://groups.google.com/d/msg/sage-devel/abysgIIVGZI/fF7efL9RAwAJ

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -18,4 +18,5 @@
 - #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
 - #22866 - Cygwin spkg-check meta-ticket
 - #28998 - Add script-type _spkg_check package that installs tox, mock, pytest etc.
-
+  - #29087 - Add [GitHub](../wiki/GitHub) Actions workflow ... 
+     has comments in `tox.ini` on skipping some testsuites
mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -18,5 +18,5 @@
 - #29301 - `sage-spkg`: Add an option `-w` for warning only if `spkg-check` fails
 - #22866 - Cygwin spkg-check meta-ticket
 - #28998 - Add script-type _spkg_check package that installs tox, mock, pytest etc.
-  - #29087 - Add [GitHub](../wiki/GitHub) Actions workflow ... 
+- #29087 - Add [GitHub](../wiki/GitHub) Actions workflow ... 
      has comments in `tox.ini` on skipping some testsuites
mkoeppe commented 4 years ago
comment:8

Let's update the default list of SAGE_CHECK_PACKAGES -- and perhaps also invent another syntax in addition to '!SPKG', perhaps '?SPKG', to indicate that this package should only be run like SAGE_CHECK=warn.

mkoeppe commented 4 years ago
comment:9

Also there are some additional packages for which it just does not make any sense to run the testsuite: curl, git, ...

jhpalmieri commented 4 years ago
comment:10

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

mkoeppe commented 4 years ago
comment:11

Replying to @jhpalmieri:

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

That (+ a comment why it is disabled) sounds good.

jhpalmieri commented 4 years ago
comment:12

See #30093.

jhpalmieri commented 4 years ago

Description changed:

--- 
+++ 
@@ -20,3 +20,4 @@
 - #28998 - Add script-type _spkg_check package that installs tox, mock, pytest etc.
 - #29087 - Add [GitHub](../wiki/GitHub) Actions workflow ... 
      has comments in `tox.ini` on skipping some testsuites
+- #30093 - skip test suite for curl, git
mkoeppe commented 3 years ago
comment:14

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage