kliem commented 4 years ago

We run more stable test for polyhedra using TestSuite.

Bug fixes:

29836: normaliz backend isn't ready for generators
29898: vertex facet graph for trivial polyhedra fails
29899: Two bugs with dilation
29904: Broken double description of hypercube
30328: Need to convert values before passing them to cdd
30330: cdd backend fails to initialize empty polyhedron from double description
31820: Fix pickling of normaliz representation objects

29903: Run test suites for many examples. (All the following tickets depend on this one.)

Add new test methods:

29905: _test_basic_properties
29908is_combinatorially_equivalent,
29906: an_affine_basis,
29907: dilation,
29918: gale transform
29934: product
30293: lawrence construction
30292: pyramid
31821: Run the test suite of self.combinatorial_polyhedron()
31823: a_maximal_chain
constructors and check such as pyramid -> is_pyramid

Depends on #29836 Depends on #29898 Depends on #29899

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedra, test suite

Branch/Commit: public/29842 @ c42b966

Issue created by migration from https://trac.sagemath.org/ticket/29842

kliem commented 4 years ago

Dependencies: #29836

kliem commented 4 years ago

Changed dependencies from #29836 to #29836, #29898

kliem commented 4 years ago

Changed dependencies from #29836, #29898 to #29836, #29898, #29899

kliem commented 4 years ago

Last 10 new commits:

`21f9d90`	`optional tag again`
`bc2b7b7`	`Merge branch 'public/29836' of git://trac.sagemath.org/sage into public/29842`
`b1d200b`	`add testsuite for dilation`
`e41d698`	`fix universe from Hrep for cdd`
`e055bc7`	`correctly detect the empty polyhedron`
`444a178`	`Merge branch 'public/29899' of git://trac.sagemath.org/sage into public/29842`
`7eba64d`	`trivial inequality`
`8c4c083`	`Merge branch 'public/29899' of git://trac.sagemath.org/sage into public/29842`
`067fb16`	`also fix it for initialization from Hrep and Vrep`
`383b24e`	`Merge branch 'public/29899' of git://trac.sagemath.org/sage into public/29842`

kliem commented 4 years ago

Commit: 383b24e

kliem commented 4 years ago

Branch: public/29842

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,15 @@
-[#29836 comment:7](https://github.com/sagemath/sage/issues/29836#comment:7)
+We run more stable test for polyhedra using `TestSuite`.

-[#29836 comment:9](https://github.com/sagemath/sage/issues/29836#comment:9)
+Bug fixtures:
+
+- #29836: normaliz backend isn't ready for generators 
+- #29898: vertex facet graph for trivial polyhedra fails 
+- #29899: Two bugs with dilation
+
+Run test suites for many examples. (All the following tickets depend on this one.)
+
+Add new test methods:
+- `is_combinatorially_equivalent`,
+- `an_affine_basis`,
+- `dilation`,
+- `_test_basic_properties` (some test run to test if basic things work)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`790dfbc`	`fix trivial vertex facet graphs`
`b8b8898`	`Merge branch 'public/29898' of git://trac.sagemath.org/sage into public/29842`
`6ccbe4a`	`test is_combinatorially_isomorphic`
`d7cca49`	`correct fix for 0-dimensional polyhedron`
`4eea213`	`Merge branch 'public/29898' of git://trac.sagemath.org/sage into public/29842`
`c42b966`	`test basic properties and test_an_affine_basis`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 383b24e to c42b966

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -6,7 +6,7 @@
 - #29898: vertex facet graph for trivial polyhedra fails 
 - #29899: Two bugs with dilation

-Run test suites for many examples. (All the following tickets depend on this one.)
+#29903: Run test suites for many examples. (All the following tickets depend on this one.)

 Add new test methods:
 - `is_combinatorially_equivalent`,

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -5,6 +5,7 @@
 - #29836: normaliz backend isn't ready for generators 
 - #29898: vertex facet graph for trivial polyhedra fails 
 - #29899: Two bugs with dilation
+- #29904: Broken double description of hypercube 

 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -14,3 +14,6 @@
 - `an_affine_basis`,
 - `dilation`,
 - `_test_basic_properties` (some test run to test if basic things work)
+- `gale_transform_to_polytope`
+- `a_maximal_chain`
+- constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -10,10 +10,10 @@
 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

 Add new test methods:
+- #29905: b`_test_basic_properties`
 - `is_combinatorially_equivalent`,
 - `an_affine_basis`,
 - `dilation`,
-- `_test_basic_properties` (some test run to test if basic things work)
 - `gale_transform_to_polytope`
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -10,7 +10,7 @@
 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

 Add new test methods:
-- #29905: b`_test_basic_properties`
+- #29905: `_test_basic_properties`
 - `is_combinatorially_equivalent`,
 - `an_affine_basis`,
 - `dilation`,

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -12,7 +12,7 @@
 Add new test methods:
 - #29905: `_test_basic_properties`
 - `is_combinatorially_equivalent`,
-- `an_affine_basis`,
+- #29906: `an_affine_basis`,
 - `dilation`,
 - `gale_transform_to_polytope`
 - `a_maximal_chain`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -13,7 +13,7 @@
 - #29905: `_test_basic_properties`
 - `is_combinatorially_equivalent`,
 - #29906: `an_affine_basis`,
-- `dilation`,
+- #29907: `dilation`,
 - `gale_transform_to_polytope`
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -11,7 +11,7 @@

 Add new test methods:
 - #29905: `_test_basic_properties`
-- `is_combinatorially_equivalent`,
+- #29908`is_combinatorially_equivalent`,
 - #29906: `an_affine_basis`,
 - #29907: `dilation`,
 - `gale_transform_to_polytope`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -14,6 +14,6 @@
 - #29908`is_combinatorially_equivalent`,
 - #29906: `an_affine_basis`,
 - #29907: `dilation`,
-- `gale_transform_to_polytope`
+- #29918: gale transform
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -15,5 +15,6 @@
 - #29906: `an_affine_basis`,
 - #29907: `dilation`,
 - #29918: gale transform
+- #29934: product
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 We run more stable test for polyhedra using `TestSuite`.

-Bug fixtures:
+Bug fixes:

 - #29836: normaliz backend isn't ready for generators 
 - #29898: vertex facet graph for trivial polyhedra fails

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -5,7 +5,8 @@
 - #29836: normaliz backend isn't ready for generators 
 - #29898: vertex facet graph for trivial polyhedra fails 
 - #29899: Two bugs with dilation
-- #29904: Broken double description of hypercube 
+- #29904: Broken double description of hypercube
+- #30328: Need to convert values before passing them to `cdd` 

 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -17,5 +17,6 @@
 - #29907: `dilation`,
 - #29918: gale transform
 - #29934: product
+- #30293: lawrence construction
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -6,7 +6,8 @@
 - #29898: vertex facet graph for trivial polyhedra fails 
 - #29899: Two bugs with dilation
 - #29904: Broken double description of hypercube
-- #30328: Need to convert values before passing them to `cdd` 
+- #30328: Need to convert values before passing them to `cdd`
+- #30330: `cdd` backend fails to initialize empty polyhedron from double description

 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -19,5 +19,6 @@
 - #29918: gale transform
 - #29934: product
 - #30293: lawrence construction
+- #30292: pyramid
 - `a_maximal_chain`
 - constructores and check such as `pyramid` -> `is_pyramid`

kliem commented 4 years ago

Description changed:

--- 
+++ 
@@ -21,4 +21,4 @@
 - #30293: lawrence construction
 - #30292: pyramid
 - `a_maximal_chain`
-- constructores and check such as `pyramid` -> `is_pyramid`
+- constructors and check such as `pyramid` -> `is_pyramid`

mkoeppe commented 3 years ago

comment:24

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

kliem commented 3 years ago

Description changed:

--- 
+++ 
@@ -8,6 +8,7 @@
 - #29904: Broken double description of hypercube
 - #30328: Need to convert values before passing them to `cdd`
 - #30330: `cdd` backend fails to initialize empty polyhedron from double description
+- #31820: Fix pickling of normaliz representation objects 

 #29903: Run test suites for many examples. (All the following tickets depend on this one.)

@@ -20,5 +21,6 @@
 - #29934: product
 - #30293: lawrence construction
 - #30292: pyramid
-- `a_maximal_chain`
+- #31821: Run the test suite of `self.combinatorial_polyhedron()`
+- #31823: `a_maximal_chain`
 - constructors and check such as `pyramid` -> `is_pyramid`

sagemath / sage

Meta-ticket: Run a more stable test suite on polyhedra #29842

29836: normaliz backend isn't ready for generators

29898: vertex facet graph for trivial polyhedra fails

29899: Two bugs with dilation

29904: Broken double description of hypercube

30328: Need to convert values before passing them to `cdd`

30330: `cdd` backend fails to initialize empty polyhedron from double description

31820: Fix pickling of normaliz representation objects

29903: Run test suites for many examples. (All the following tickets depend on this one.)

29905: `_test_basic_properties`

29908`is_combinatorially_equivalent`,

29906: `an_affine_basis`,

29907: `dilation`,

29918: gale transform

29934: product

30293: lawrence construction

30292: pyramid

31821: Run the test suite of `self.combinatorial_polyhedron()`

31823: `a_maximal_chain`

sagemath / sage

Meta-ticket: Run a more stable test suite on polyhedra #29842

29836: normaliz backend isn't ready for generators

29898: vertex facet graph for trivial polyhedra fails

29899: Two bugs with dilation

29904: Broken double description of hypercube

30328: Need to convert values before passing them to cdd

30330: cdd backend fails to initialize empty polyhedron from double description

31820: Fix pickling of normaliz representation objects

29903: Run test suites for many examples. (All the following tickets depend on this one.)

29905: _test_basic_properties

29908is_combinatorially_equivalent,

29906: an_affine_basis,

29907: dilation,

29918: gale transform

29934: product

30293: lawrence construction

30292: pyramid

31821: Run the test suite of self.combinatorial_polyhedron()

31823: a_maximal_chain

30328: Need to convert values before passing them to `cdd`

30330: `cdd` backend fails to initialize empty polyhedron from double description

29905: `_test_basic_properties`

29908`is_combinatorially_equivalent`,

29906: `an_affine_basis`,

29907: `dilation`,

31821: Run the test suite of `self.combinatorial_polyhedron()`

31823: `a_maximal_chain`