Test method `is_combinatorially_isomorphic`

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.36k stars 462 forks source link

Test method `is_combinatorially_isomorphic` #29908

Closed kliem closed 4 years ago

kliem commented 4 years ago

We add a method that tests is_combinatorially_isomorphic.

Depends on #29898 Depends on #29899 Depends on #29903

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedra, test suite

Author: Jonathan Kliem

Branch/Commit: a6d49a1

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29908

kliem commented 4 years ago

Dependencies: #29898

kliem commented 4 years ago

Changed dependencies from #29898 to #29898, #29899

kliem commented 4 years ago

Last 10 new commits:

`790dfbc`	`fix trivial vertex facet graphs`
`d7cca49`	`correct fix for 0-dimensional polyhedron`
`7c15f9e`	`Merge branch 'public/29898' of git://trac.sagemath.org/sage into public/29908`
`bc5d247`	`implement _test_is_combinatorially_isomorphic`
`e41d698`	`fix universe from Hrep for cdd`
`e055bc7`	`correctly detect the empty polyhedron`
`7eba64d`	`trivial inequality`
`067fb16`	`also fix it for initialization from Hrep and Vrep`
`4609aff`	`Merge branch 'public/29899' of git://trac.sagemath.org/sage into public/29908`
`2ba5275`	`remove numerically complicated test`

kliem commented 4 years ago

Commit: 2ba5275

kliem commented 4 years ago

Branch: public/29908

kliem commented 4 years ago

Changed dependencies from #29898, #29899 to #29898, #29899, #29903

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

26890de unused import, unused variable

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 2ba5275 to 26890de

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 26890de to a6d49a1

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a6d49a1 typo

mkoeppe commented 4 years ago

Reviewer: Matthias Koeppe

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-We add a method that tests `is_combinatorially_equivalent`.
+We add a method that tests `is_combinatorially_isomorphic`.

kliem commented 4 years ago

comment:7

Thank you.

vbraun commented 4 years ago

Changed branch from public/29908 to a6d49a1