Closed heluani closed 4 years ago
patchbot reports failing doctests and one unused import
Branch pushed to git repo; I updated commit sha1. New commits:
bec2e2c | Remove unused import and some blank lines |
Replying to @fchapoton:
patchbot reports failing doctests and one unused import
Thanks I do not know how my pyflakes script missed that. I don't see the doctest failutre though in that report. I updated this removing the unused import
see the "shortlog" link for the doctest failures (something moved, should be easy to fix by changing some imports)
Replying to @fchapoton:
see the "shortlog" link for the doctest failures (something moved, should be easy to fix by changing some imports)
Ohh I see thanks, repr_lincomb was changed in develop. I'll fix it right away.
Branch pushed to git repo; I updated commit sha1. New commits:
0f39045 | Relocated repr_lincomb import |
Ok, now it's green. I don't think I can do much about the startup time.
I think this is good to go into Sage. We can continue to make improvements to the code here as things progress in the later tickets. With the current version, it is flexible enough to change without major difficulties IMO.
Thank you for all your hard work and discussions on this ticket.
Replying to @tscrim:
I think this is good to go into Sage. We can continue to make improvements to the code here as things progress in the later tickets. With the current version, it is flexible enough to change without major difficulties IMO.
Thank you for all your hard work and discussions on this ticket.
Great, thanks for your work and time. I'll prepare the other tickets right away. The examples ones should be easy. The vertex algebras one will take me a little bit cause I'll implement the same category changes that you asked in this one. Do you have an idea for the stub category name?
Ah, I see that you already requested a rebase of the examples ticket. Since no one seems to care about commit messages, do you think I can merge this ticket into that one? It would be much easier to merge this than to rebase. Otherwise I might get away with first merging, reset and then rebase with rerere.
Replying to @heluani:
Replying to @tscrim:
I think this is good to go into Sage. We can continue to make improvements to the code here as things progress in the later tickets. With the current version, it is flexible enough to change without major difficulties IMO.
Thank you for all your hard work and discussions on this ticket.
Great, thanks for your work and time. I'll prepare the other tickets right away. The examples ones should be easy. The vertex algebras one will take me a little bit cause I'll implement the same category changes that you asked in this one. Do you have an idea for the stub category name?
I am not sure what the base category should be called. However, it can be a fairly generic and/or descriptive name as it is not something the user will see too much of.
Ah, I see that you already requested a rebase of the examples ticket. Since no one seems to care about commit messages, do you think I can merge this ticket into that one? It would be much easier to merge this than to rebase. Otherwise I might get away with first merging, reset and then rebase with rerere.
We can discuss more on that ticket.
Changed branch from u/heluani/lie_conformal_algebras to 0f39045
Thanks for adding the section in the release tours! Looking great.
Just a quick note on is_even_odd
-- this strikes me as nonstandard naming from a Python point of view. One would expect that a method that starts with is_
returns a boolean.
Would it be better to rename it to is_odd
and return a boolean, or to rename it to something like parity
?
Replying to @mkoeppe:
Thanks for adding the section in the release tours! Looking great.
Just a quick note on
is_even_odd
-- this strikes me as nonstandard naming from a Python point of view. One would expect that a method that starts withis_
returns a boolean. Would it be better to rename it tois_odd
and return a boolean, or to rename it to something likeparity
?
That may be hard to change. It was forced on me by SuperModules
.
Oh, I see -- thanks for the clarification
This ticket is a bare-bones version of the Lie conformal algebra version of #29610 by request of the reviewer.
CC: @tscrim @heluani
Component: algebra
Author: Reimundo Heluani
Branch:
0f39045
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/30032